mirror of
https://github.com/status-im/nimbus-eth2.git
synced 2025-01-09 13:56:23 +00:00
Separate validator duties from the Beacon Node (#976)
* Separate validator duties from the Beacon Node * remove duplicate MaxEmptySlotCOunt * imports * have beacnde properly compile
This commit is contained in:
parent
a56e18bb0c
commit
621c2e38a6
3
.gitignore
vendored
3
.gitignore
vendored
@ -28,5 +28,4 @@ build/
|
|||||||
*.log
|
*.log
|
||||||
*.sqlite3
|
*.sqlite3
|
||||||
|
|
||||||
/local_testnet_data
|
/local_testnet_data*/
|
||||||
|
|
||||||
|
20
FixtureSSZGeneric-mainnet.md
Normal file
20
FixtureSSZGeneric-mainnet.md
Normal file
@ -0,0 +1,20 @@
|
|||||||
|
FixtureSSZGeneric-mainnet
|
||||||
|
===
|
||||||
|
## Official - SSZ generic types
|
||||||
|
```diff
|
||||||
|
+ **Skipping** bitlist inputs - valid - skipped altogether OK
|
||||||
|
Testing basic_vector inputs - invalid - skipping Vector[uint128, N] and Vector[uint256, N] Skip
|
||||||
|
+ Testing basic_vector inputs - valid - skipping Vector[uint128, N] and Vector[uint256, N] OK
|
||||||
|
Testing bitvector inputs - invalid Skip
|
||||||
|
+ Testing bitvector inputs - valid OK
|
||||||
|
+ Testing boolean inputs - invalid OK
|
||||||
|
+ Testing boolean inputs - valid OK
|
||||||
|
+ Testing containers inputs - invalid - skipping VarTestStruct, ComplexTestStruct, BitsStr OK
|
||||||
|
+ Testing containers inputs - valid - skipping VarTestStruct, ComplexTestStruct, BitsStruc OK
|
||||||
|
+ Testing uints inputs - invalid - skipping uint128 and uint256 OK
|
||||||
|
+ Testing uints inputs - valid - skipping uint128 and uint256 OK
|
||||||
|
```
|
||||||
|
OK: 9/11 Fail: 0/11 Skip: 2/11
|
||||||
|
|
||||||
|
---TOTAL---
|
||||||
|
OK: 9/11 Fail: 0/11 Skip: 2/11
|
@ -18,22 +18,23 @@ import
|
|||||||
eth/p2p/enode, eth/[keys, async_utils], eth/p2p/discoveryv5/[protocol, enr],
|
eth/p2p/enode, eth/[keys, async_utils], eth/p2p/discoveryv5/[protocol, enr],
|
||||||
|
|
||||||
# Local modules
|
# Local modules
|
||||||
spec/[datatypes, digest, crypto, beaconstate, helpers, validator, network,
|
spec/[datatypes, digest, crypto, beaconstate, helpers, network],
|
||||||
state_transition_block], spec/presets/custom,
|
spec/presets/custom,
|
||||||
conf, time, beacon_chain_db, validator_pool, extras,
|
conf, time, beacon_chain_db, validator_pool, extras,
|
||||||
attestation_pool, block_pool, eth2_network, eth2_discovery,
|
attestation_pool, block_pool, eth2_network, eth2_discovery,
|
||||||
beacon_node_types, mainchain_monitor, version, ssz, ssz/dynamic_navigator,
|
beacon_node_common, beacon_node_types,
|
||||||
|
mainchain_monitor, version, ssz, ssz/dynamic_navigator,
|
||||||
sync_protocol, request_manager, validator_keygen, interop, statusbar,
|
sync_protocol, request_manager, validator_keygen, interop, statusbar,
|
||||||
attestation_aggregation, sync_manager, state_transition, sszdump
|
sync_manager, state_transition,
|
||||||
|
validator_duties
|
||||||
|
|
||||||
const
|
const
|
||||||
genesisFile = "genesis.ssz"
|
genesisFile = "genesis.ssz"
|
||||||
hasPrompt = not defined(withoutPrompt)
|
hasPrompt = not defined(withoutPrompt)
|
||||||
maxEmptySlotCount = uint64(10*60) div SECONDS_PER_SLOT
|
|
||||||
|
|
||||||
type
|
type
|
||||||
|
RpcServer* = RpcHttpServer
|
||||||
KeyPair = eth2_network.KeyPair
|
KeyPair = eth2_network.KeyPair
|
||||||
RpcServer = RpcHttpServer
|
|
||||||
|
|
||||||
template init(T: type RpcHttpServer, ip: IpAddress, port: Port): T =
|
template init(T: type RpcHttpServer, ip: IpAddress, port: Port): T =
|
||||||
newRpcHttpServer([initTAddress(ip, port)])
|
newRpcHttpServer([initTAddress(ip, port)])
|
||||||
@ -43,49 +44,16 @@ declareGauge beacon_slot,
|
|||||||
"Latest slot of the beacon chain state"
|
"Latest slot of the beacon chain state"
|
||||||
declareGauge beacon_head_slot,
|
declareGauge beacon_head_slot,
|
||||||
"Slot of the head block of the beacon chain"
|
"Slot of the head block of the beacon chain"
|
||||||
declareGauge beacon_head_root,
|
|
||||||
"Root of the head block of the beacon chain"
|
|
||||||
|
|
||||||
# Metrics for tracking attestation and beacon block loss
|
# Metrics for tracking attestation and beacon block loss
|
||||||
declareCounter beacon_attestations_sent,
|
|
||||||
"Number of beacon chain attestations sent by this peer"
|
|
||||||
declareCounter beacon_attestations_received,
|
declareCounter beacon_attestations_received,
|
||||||
"Number of beacon chain attestations received by this peer"
|
"Number of beacon chain attestations received by this peer"
|
||||||
declareCounter beacon_blocks_proposed,
|
|
||||||
"Number of beacon chain blocks sent by this peer"
|
|
||||||
declareCounter beacon_blocks_received,
|
declareCounter beacon_blocks_received,
|
||||||
"Number of beacon chain blocks received by this peer"
|
"Number of beacon chain blocks received by this peer"
|
||||||
|
|
||||||
logScope: topics = "beacnde"
|
logScope: topics = "beacnde"
|
||||||
|
|
||||||
type
|
|
||||||
BeaconNode = ref object
|
|
||||||
nickname: string
|
|
||||||
network: Eth2Node
|
|
||||||
netKeys: KeyPair
|
|
||||||
requestManager: RequestManager
|
|
||||||
db: BeaconChainDB
|
|
||||||
config: BeaconNodeConf
|
|
||||||
attachedValidators: ValidatorPool
|
|
||||||
blockPool: BlockPool
|
|
||||||
attestationPool: AttestationPool
|
|
||||||
mainchainMonitor: MainchainMonitor
|
|
||||||
beaconClock: BeaconClock
|
|
||||||
rpcServer: RpcServer
|
|
||||||
forkDigest: ForkDigest
|
|
||||||
topicBeaconBlocks: string
|
|
||||||
topicAggregateAndProofs: string
|
|
||||||
syncLoop: Future[void]
|
|
||||||
|
|
||||||
proc onBeaconBlock*(node: BeaconNode, signedBlock: SignedBeaconBlock) {.gcsafe.}
|
proc onBeaconBlock*(node: BeaconNode, signedBlock: SignedBeaconBlock) {.gcsafe.}
|
||||||
proc updateHead(node: BeaconNode): BlockRef
|
|
||||||
|
|
||||||
proc saveValidatorKey(keyName, key: string, conf: BeaconNodeConf) =
|
|
||||||
let validatorsDir = conf.localValidatorsDir
|
|
||||||
let outputFile = validatorsDir / keyName
|
|
||||||
createDir validatorsDir
|
|
||||||
writeFile(outputFile, key)
|
|
||||||
info "Imported validator key", file = outputFile
|
|
||||||
|
|
||||||
proc getStateFromSnapshot(conf: BeaconNodeConf): NilableBeaconStateRef =
|
proc getStateFromSnapshot(conf: BeaconNodeConf): NilableBeaconStateRef =
|
||||||
var
|
var
|
||||||
@ -274,191 +242,6 @@ proc connectToNetwork(node: BeaconNode) {.async.} =
|
|||||||
let addressFile = node.config.dataDir / "beacon_node.address"
|
let addressFile = node.config.dataDir / "beacon_node.address"
|
||||||
writeFile(addressFile, node.network.announcedENR.toURI)
|
writeFile(addressFile, node.network.announcedENR.toURI)
|
||||||
|
|
||||||
template findIt(s: openarray, predicate: untyped): int =
|
|
||||||
var res = -1
|
|
||||||
for i, it {.inject.} in s:
|
|
||||||
if predicate:
|
|
||||||
res = i
|
|
||||||
break
|
|
||||||
res
|
|
||||||
|
|
||||||
proc addLocalValidator(node: BeaconNode,
|
|
||||||
state: BeaconState,
|
|
||||||
privKey: ValidatorPrivKey) =
|
|
||||||
let pubKey = privKey.toPubKey()
|
|
||||||
|
|
||||||
let idx = state.validators.findIt(it.pubKey == pubKey)
|
|
||||||
if idx == -1:
|
|
||||||
# We allow adding a validator even if its key is not in the state registry:
|
|
||||||
# it might be that the deposit for this validator has not yet been processed
|
|
||||||
warn "Validator not in registry (yet?)", pubKey
|
|
||||||
|
|
||||||
node.attachedValidators.addLocalValidator(pubKey, privKey)
|
|
||||||
|
|
||||||
proc addLocalValidators(node: BeaconNode, state: BeaconState) =
|
|
||||||
for validatorKey in node.config.validatorKeys:
|
|
||||||
node.addLocalValidator state, validatorKey
|
|
||||||
|
|
||||||
info "Local validators attached ", count = node.attachedValidators.count
|
|
||||||
|
|
||||||
func getAttachedValidator(node: BeaconNode,
|
|
||||||
state: BeaconState,
|
|
||||||
idx: ValidatorIndex): AttachedValidator =
|
|
||||||
let validatorKey = state.validators[idx].pubkey
|
|
||||||
node.attachedValidators.getValidator(validatorKey)
|
|
||||||
|
|
||||||
proc isSynced(node: BeaconNode, head: BlockRef): bool =
|
|
||||||
## TODO This function is here as a placeholder for some better heurestics to
|
|
||||||
## determine if we're in sync and should be producing blocks and
|
|
||||||
## attestations. Generally, the problem is that slot time keeps advancing
|
|
||||||
## even when there are no blocks being produced, so there's no way to
|
|
||||||
## distinguish validators geniunely going missing from the node not being
|
|
||||||
## well connected (during a network split or an internet outage for
|
|
||||||
## example). It would generally be correct to simply keep running as if
|
|
||||||
## we were the only legit node left alive, but then we run into issues:
|
|
||||||
## with enough many empty slots, the validator pool is emptied leading
|
|
||||||
## to empty committees and lots of empty slot processing that will be
|
|
||||||
## thrown away as soon as we're synced again.
|
|
||||||
|
|
||||||
let
|
|
||||||
# The slot we should be at, according to the clock
|
|
||||||
beaconTime = node.beaconClock.now()
|
|
||||||
wallSlot = beaconTime.toSlot()
|
|
||||||
|
|
||||||
# TODO if everyone follows this logic, the network will not recover from a
|
|
||||||
# halt: nobody will be producing blocks because everone expects someone
|
|
||||||
# else to do it
|
|
||||||
if wallSlot.afterGenesis and head.slot + maxEmptySlotCount < wallSlot.slot:
|
|
||||||
false
|
|
||||||
else:
|
|
||||||
true
|
|
||||||
|
|
||||||
proc updateHead(node: BeaconNode): BlockRef =
|
|
||||||
# Check pending attestations - maybe we found some blocks for them
|
|
||||||
node.attestationPool.resolve()
|
|
||||||
|
|
||||||
# Grab the new head according to our latest attestation data
|
|
||||||
let newHead = node.attestationPool.selectHead()
|
|
||||||
|
|
||||||
# Store the new head in the block pool - this may cause epochs to be
|
|
||||||
# justified and finalized
|
|
||||||
node.blockPool.updateHead(newHead)
|
|
||||||
beacon_head_root.set newHead.root.toGaugeValue
|
|
||||||
|
|
||||||
newHead
|
|
||||||
|
|
||||||
proc sendAttestation(node: BeaconNode,
|
|
||||||
fork: Fork,
|
|
||||||
genesis_validators_root: Eth2Digest,
|
|
||||||
validator: AttachedValidator,
|
|
||||||
attestationData: AttestationData,
|
|
||||||
committeeLen: int,
|
|
||||||
indexInCommittee: int) {.async.} =
|
|
||||||
logScope: pcs = "send_attestation"
|
|
||||||
|
|
||||||
let validatorSignature = await validator.signAttestation(attestationData,
|
|
||||||
fork, genesis_validators_root)
|
|
||||||
|
|
||||||
var aggregationBits = CommitteeValidatorsBits.init(committeeLen)
|
|
||||||
aggregationBits.setBit indexInCommittee
|
|
||||||
|
|
||||||
var attestation = Attestation(
|
|
||||||
data: attestationData,
|
|
||||||
signature: validatorSignature,
|
|
||||||
aggregation_bits: aggregationBits
|
|
||||||
)
|
|
||||||
|
|
||||||
# https://github.com/ethereum/eth2.0-specs/blob/v0.11.1/specs/phase0/validator.md#broadcast-attestation
|
|
||||||
node.network.broadcast(
|
|
||||||
getAttestationTopic(node.forkDigest, attestationData.index), attestation)
|
|
||||||
|
|
||||||
if node.config.dumpEnabled:
|
|
||||||
dump(node.config.dumpDir, attestationData, validator.pubKey)
|
|
||||||
|
|
||||||
info "Attestation sent",
|
|
||||||
attestation = shortLog(attestation),
|
|
||||||
validator = shortLog(validator),
|
|
||||||
indexInCommittee = indexInCommittee,
|
|
||||||
cat = "consensus"
|
|
||||||
|
|
||||||
beacon_attestations_sent.inc()
|
|
||||||
|
|
||||||
proc proposeBlock(node: BeaconNode,
|
|
||||||
validator: AttachedValidator,
|
|
||||||
head: BlockRef,
|
|
||||||
slot: Slot): Future[BlockRef] {.async.} =
|
|
||||||
logScope: pcs = "block_proposal"
|
|
||||||
|
|
||||||
if head.slot >= slot:
|
|
||||||
# We should normally not have a head newer than the slot we're proposing for
|
|
||||||
# but this can happen if block proposal is delayed
|
|
||||||
warn "Skipping proposal, have newer head already",
|
|
||||||
headSlot = shortLog(head.slot),
|
|
||||||
headBlockRoot = shortLog(head.root),
|
|
||||||
slot = shortLog(slot),
|
|
||||||
cat = "fastforward"
|
|
||||||
return head
|
|
||||||
|
|
||||||
# Advance state to the slot that we're proposing for - this is the equivalent
|
|
||||||
# of running `process_slots` up to the slot of the new block.
|
|
||||||
let (nroot, nblck) = node.blockPool.withState(
|
|
||||||
node.blockPool.tmpState, head.atSlot(slot)):
|
|
||||||
let (eth1data, deposits) =
|
|
||||||
if node.mainchainMonitor.isNil:
|
|
||||||
(get_eth1data_stub(state.eth1_deposit_index, slot.compute_epoch_at_slot()),
|
|
||||||
newSeq[Deposit]())
|
|
||||||
else:
|
|
||||||
node.mainchainMonitor.getBlockProposalData(state)
|
|
||||||
|
|
||||||
let message = makeBeaconBlock(
|
|
||||||
state,
|
|
||||||
head.root,
|
|
||||||
validator.genRandaoReveal(state.fork, state.genesis_validators_root, slot),
|
|
||||||
eth1data,
|
|
||||||
Eth2Digest(),
|
|
||||||
node.attestationPool.getAttestationsForBlock(state),
|
|
||||||
deposits)
|
|
||||||
|
|
||||||
if not message.isSome():
|
|
||||||
return head # already logged elsewhere!
|
|
||||||
var
|
|
||||||
newBlock = SignedBeaconBlock(
|
|
||||||
message: message.get()
|
|
||||||
)
|
|
||||||
|
|
||||||
let blockRoot = hash_tree_root(newBlock.message)
|
|
||||||
|
|
||||||
# Careful, state no longer valid after here because of the await..
|
|
||||||
newBlock.signature = await validator.signBlockProposal(
|
|
||||||
state.fork, state.genesis_validators_root, slot, blockRoot)
|
|
||||||
|
|
||||||
(blockRoot, newBlock)
|
|
||||||
|
|
||||||
let newBlockRef = node.blockPool.add(nroot, nblck)
|
|
||||||
if newBlockRef == nil:
|
|
||||||
warn "Unable to add proposed block to block pool",
|
|
||||||
newBlock = shortLog(newBlock.message),
|
|
||||||
blockRoot = shortLog(blockRoot),
|
|
||||||
cat = "bug"
|
|
||||||
return head
|
|
||||||
|
|
||||||
info "Block proposed",
|
|
||||||
blck = shortLog(newBlock.message),
|
|
||||||
blockRoot = shortLog(newBlockRef.root),
|
|
||||||
validator = shortLog(validator),
|
|
||||||
cat = "consensus"
|
|
||||||
|
|
||||||
if node.config.dumpEnabled:
|
|
||||||
dump(node.config.dumpDir, newBlock, newBlockRef)
|
|
||||||
node.blockPool.withState(
|
|
||||||
node.blockPool.tmpState, newBlockRef.atSlot(newBlockRef.slot)):
|
|
||||||
dump(node.config.dumpDir, hashedState, newBlockRef)
|
|
||||||
|
|
||||||
node.network.broadcast(node.topicBeaconBlocks, newBlock)
|
|
||||||
|
|
||||||
beacon_blocks_proposed.inc()
|
|
||||||
|
|
||||||
return newBlockRef
|
|
||||||
|
|
||||||
proc onAttestation(node: BeaconNode, attestation: Attestation) =
|
proc onAttestation(node: BeaconNode, attestation: Attestation) =
|
||||||
# We received an attestation from the network but don't know much about it
|
# We received an attestation from the network but don't know much about it
|
||||||
@ -486,7 +269,7 @@ proc onAttestation(node: BeaconNode, attestation: Attestation) =
|
|||||||
return
|
return
|
||||||
|
|
||||||
if attestation.data.slot > head.blck.slot and
|
if attestation.data.slot > head.blck.slot and
|
||||||
(attestation.data.slot - head.blck.slot) > maxEmptySlotCount:
|
(attestation.data.slot - head.blck.slot) > MaxEmptySlotCount:
|
||||||
warn "Ignoring attestation, head block too old (out of sync?)",
|
warn "Ignoring attestation, head block too old (out of sync?)",
|
||||||
attestationSlot = attestation.data.slot, headSlot = head.blck.slot
|
attestationSlot = attestation.data.slot, headSlot = head.blck.slot
|
||||||
return
|
return
|
||||||
@ -522,97 +305,6 @@ proc onBeaconBlock(node: BeaconNode, signedBlock: SignedBeaconBlock) =
|
|||||||
# don't know if it's part of the chain we're currently building.
|
# don't know if it's part of the chain we're currently building.
|
||||||
discard node.storeBlock(signedBlock)
|
discard node.storeBlock(signedBlock)
|
||||||
|
|
||||||
proc handleAttestations(node: BeaconNode, head: BlockRef, slot: Slot) =
|
|
||||||
## Perform all attestations that the validators attached to this node should
|
|
||||||
## perform during the given slot
|
|
||||||
logScope: pcs = "on_attestation"
|
|
||||||
|
|
||||||
if slot + SLOTS_PER_EPOCH < head.slot:
|
|
||||||
# The latest block we know about is a lot newer than the slot we're being
|
|
||||||
# asked to attest to - this makes it unlikely that it will be included
|
|
||||||
# at all.
|
|
||||||
# TODO the oldest attestations allowed are those that are older than the
|
|
||||||
# finalized epoch.. also, it seems that posting very old attestations
|
|
||||||
# is risky from a slashing perspective. More work is needed here.
|
|
||||||
notice "Skipping attestation, head is too recent",
|
|
||||||
headSlot = shortLog(head.slot),
|
|
||||||
slot = shortLog(slot)
|
|
||||||
return
|
|
||||||
|
|
||||||
let attestationHead = head.atSlot(slot)
|
|
||||||
if head != attestationHead.blck:
|
|
||||||
# In rare cases, such as when we're busy syncing or just slow, we'll be
|
|
||||||
# attesting to a past state - we must then recreate the world as it looked
|
|
||||||
# like back then
|
|
||||||
notice "Attesting to a state in the past, falling behind?",
|
|
||||||
headSlot = shortLog(head.slot),
|
|
||||||
attestationHeadSlot = shortLog(attestationHead.slot),
|
|
||||||
attestationSlot = shortLog(slot)
|
|
||||||
|
|
||||||
trace "Checking attestations",
|
|
||||||
attestationHeadRoot = shortLog(attestationHead.blck.root),
|
|
||||||
attestationSlot = shortLog(slot),
|
|
||||||
cat = "attestation"
|
|
||||||
|
|
||||||
# Collect data to send before node.stateCache grows stale
|
|
||||||
var attestations: seq[tuple[
|
|
||||||
data: AttestationData, committeeLen, indexInCommittee: int,
|
|
||||||
validator: AttachedValidator]]
|
|
||||||
|
|
||||||
# We need to run attestations exactly for the slot that we're attesting to.
|
|
||||||
# In case blocks went missing, this means advancing past the latest block
|
|
||||||
# using empty slots as fillers.
|
|
||||||
# https://github.com/ethereum/eth2.0-specs/blob/v0.8.4/specs/validator/0_beacon-chain-validator.md#validator-assignments
|
|
||||||
# TODO we could cache the validator assignment since it's valid for the entire
|
|
||||||
# epoch since it doesn't change, but that has to be weighed against
|
|
||||||
# the complexity of handling forks correctly - instead, we use an adapted
|
|
||||||
# version here that calculates the committee for a single slot only
|
|
||||||
node.blockPool.withState(node.blockPool.tmpState, attestationHead):
|
|
||||||
var cache = get_empty_per_epoch_cache()
|
|
||||||
let committees_per_slot = get_committee_count_at_slot(state, slot)
|
|
||||||
|
|
||||||
for committee_index in 0'u64..<committees_per_slot:
|
|
||||||
let committee = get_beacon_committee(
|
|
||||||
state, slot, committee_index.CommitteeIndex, cache)
|
|
||||||
|
|
||||||
for index_in_committee, validatorIdx in committee:
|
|
||||||
let validator = node.getAttachedValidator(state, validatorIdx)
|
|
||||||
if validator != nil:
|
|
||||||
let ad = makeAttestationData(state, slot, committee_index, blck.root)
|
|
||||||
attestations.add((ad, committee.len, index_in_committee, validator))
|
|
||||||
|
|
||||||
for a in attestations:
|
|
||||||
traceAsyncErrors sendAttestation(
|
|
||||||
node, state.fork, state.genesis_validators_root, a.validator, a.data,
|
|
||||||
a.committeeLen, a.indexInCommittee)
|
|
||||||
|
|
||||||
proc handleProposal(node: BeaconNode, head: BlockRef, slot: Slot):
|
|
||||||
Future[BlockRef] {.async.} =
|
|
||||||
## Perform the proposal for the given slot, iff we have a validator attached
|
|
||||||
## that is supposed to do so, given the shuffling in head
|
|
||||||
|
|
||||||
# TODO here we advance the state to the new slot, but later we'll be
|
|
||||||
# proposing for it - basically, we're selecting proposer based on an
|
|
||||||
# empty slot
|
|
||||||
|
|
||||||
let proposerKey = node.blockPool.getProposer(head, slot)
|
|
||||||
if proposerKey.isNone():
|
|
||||||
return head
|
|
||||||
|
|
||||||
let validator = node.attachedValidators.getValidator(proposerKey.get())
|
|
||||||
|
|
||||||
if validator != nil:
|
|
||||||
return await proposeBlock(node, validator, head, slot)
|
|
||||||
|
|
||||||
debug "Expecting block proposal",
|
|
||||||
headRoot = shortLog(head.root),
|
|
||||||
slot = shortLog(slot),
|
|
||||||
proposer = shortLog(proposerKey.get()),
|
|
||||||
cat = "consensus",
|
|
||||||
pcs = "wait_for_proposal"
|
|
||||||
|
|
||||||
return head
|
|
||||||
|
|
||||||
proc verifyFinalization(node: BeaconNode, slot: Slot) =
|
proc verifyFinalization(node: BeaconNode, slot: Slot) =
|
||||||
# Epoch must be >= 4 to check finalization
|
# Epoch must be >= 4 to check finalization
|
||||||
const SETTLING_TIME_OFFSET = 1'u64
|
const SETTLING_TIME_OFFSET = 1'u64
|
||||||
@ -628,150 +320,6 @@ proc verifyFinalization(node: BeaconNode, slot: Slot) =
|
|||||||
node.blockPool.finalizedHead.blck.slot.compute_epoch_at_slot()
|
node.blockPool.finalizedHead.blck.slot.compute_epoch_at_slot()
|
||||||
doAssert finalizedEpoch + 2 == epoch
|
doAssert finalizedEpoch + 2 == epoch
|
||||||
|
|
||||||
proc broadcastAggregatedAttestations(
|
|
||||||
node: BeaconNode, aggregationHead: BlockRef, aggregationSlot: Slot,
|
|
||||||
trailing_distance: uint64) =
|
|
||||||
# The index is via a
|
|
||||||
# locally attested validator. Unlike in handleAttestations(...) there's a
|
|
||||||
# single one at most per slot (because that's how aggregation attestation
|
|
||||||
# works), so the machinery that has to handle looping across, basically a
|
|
||||||
# set of locally attached validators is in principle not necessary, but a
|
|
||||||
# way to organize this. Then the private key for that validator should be
|
|
||||||
# the corresponding one -- whatver they are, they match.
|
|
||||||
|
|
||||||
let bs = BlockSlot(blck: aggregationHead, slot: aggregationSlot)
|
|
||||||
node.blockPool.withState(node.blockPool.tmpState, bs):
|
|
||||||
let
|
|
||||||
committees_per_slot = get_committee_count_at_slot(state, aggregationSlot)
|
|
||||||
var cache = get_empty_per_epoch_cache()
|
|
||||||
for committee_index in 0'u64..<committees_per_slot:
|
|
||||||
let committee = get_beacon_committee(
|
|
||||||
state, aggregationSlot, committee_index.CommitteeIndex, cache)
|
|
||||||
|
|
||||||
for index_in_committee, validatorIdx in committee:
|
|
||||||
let validator = node.getAttachedValidator(state, validatorIdx)
|
|
||||||
if validator != nil:
|
|
||||||
# This is slightly strange/inverted control flow, since really it's
|
|
||||||
# going to happen once per slot, but this is the best way to get at
|
|
||||||
# the validator index and private key pair. TODO verify it only has
|
|
||||||
# one isSome() with test.
|
|
||||||
let aggregateAndProof =
|
|
||||||
aggregate_attestations(node.attestationPool, state,
|
|
||||||
committee_index.CommitteeIndex,
|
|
||||||
# TODO https://github.com/status-im/nim-beacon-chain/issues/545
|
|
||||||
# this assumes in-process private keys
|
|
||||||
validator.privKey,
|
|
||||||
trailing_distance)
|
|
||||||
|
|
||||||
# Don't broadcast when, e.g., this node isn't an aggregator
|
|
||||||
if aggregateAndProof.isSome:
|
|
||||||
var signedAP = SignedAggregateAndProof(
|
|
||||||
message: aggregateAndProof.get,
|
|
||||||
# TODO Make the signing async here
|
|
||||||
signature: validator.signAggregateAndProof(
|
|
||||||
aggregateAndProof.get, state.fork,
|
|
||||||
state.genesis_validators_root))
|
|
||||||
node.network.broadcast(node.topicAggregateAndProofs, signedAP)
|
|
||||||
|
|
||||||
proc handleValidatorDuties(
|
|
||||||
node: BeaconNode, head: BlockRef, lastSlot, slot: Slot): Future[BlockRef] {.async.} =
|
|
||||||
## Perform validator duties - create blocks, vote and aggreagte existing votes
|
|
||||||
if node.attachedValidators.count == 0:
|
|
||||||
# Nothing to do because we have no validator attached
|
|
||||||
return head
|
|
||||||
|
|
||||||
if not node.isSynced(head):
|
|
||||||
notice "Node out of sync, skipping validator duties",
|
|
||||||
slot, headSlot = head.slot
|
|
||||||
return head
|
|
||||||
|
|
||||||
var curSlot = lastSlot + 1
|
|
||||||
var head = head
|
|
||||||
|
|
||||||
# Start by checking if there's work we should have done in the past that we
|
|
||||||
# can still meaningfully do
|
|
||||||
while curSlot < slot:
|
|
||||||
# TODO maybe even collect all work synchronously to avoid unnecessary
|
|
||||||
# state rewinds while waiting for async operations like validator
|
|
||||||
# signature..
|
|
||||||
notice "Catching up",
|
|
||||||
curSlot = shortLog(curSlot),
|
|
||||||
lastSlot = shortLog(lastSlot),
|
|
||||||
slot = shortLog(slot),
|
|
||||||
cat = "overload"
|
|
||||||
|
|
||||||
# For every slot we're catching up, we'll propose then send
|
|
||||||
# attestations - head should normally be advancing along the same branch
|
|
||||||
# in this case
|
|
||||||
# TODO what if we receive blocks / attestations while doing this work?
|
|
||||||
head = await handleProposal(node, head, curSlot)
|
|
||||||
|
|
||||||
# For each slot we missed, we need to send out attestations - if we were
|
|
||||||
# proposing during this time, we'll use the newly proposed head, else just
|
|
||||||
# keep reusing the same - the attestation that goes out will actually
|
|
||||||
# rewind the state to what it looked like at the time of that slot
|
|
||||||
# TODO smells like there's an optimization opportunity here
|
|
||||||
handleAttestations(node, head, curSlot)
|
|
||||||
|
|
||||||
curSlot += 1
|
|
||||||
|
|
||||||
head = await handleProposal(node, head, slot)
|
|
||||||
|
|
||||||
# We've been doing lots of work up until now which took time. Normally, we
|
|
||||||
# send out attestations at the slot thirds-point, so we go back to the clock
|
|
||||||
# to see how much time we need to wait.
|
|
||||||
# TODO the beacon clock might jump here also. It's probably easier to complete
|
|
||||||
# the work for the whole slot using a monotonic clock instead, then deal
|
|
||||||
# with any clock discrepancies once only, at the start of slot timer
|
|
||||||
# processing..
|
|
||||||
|
|
||||||
# https://github.com/ethereum/eth2.0-specs/blob/v0.11.1/specs/phase0/validator.md#attesting
|
|
||||||
# A validator should create and broadcast the attestation to the associated
|
|
||||||
# attestation subnet when either (a) the validator has received a valid
|
|
||||||
# block from the expected block proposer for the assigned slot or
|
|
||||||
# (b) one-third of the slot has transpired (`SECONDS_PER_SLOT / 3` seconds
|
|
||||||
# after the start of slot) -- whichever comes first.
|
|
||||||
template sleepToSlotOffset(extra: chronos.Duration, msg: static string) =
|
|
||||||
let
|
|
||||||
fromNow = node.beaconClock.fromNow(slot.toBeaconTime(extra))
|
|
||||||
|
|
||||||
if fromNow.inFuture:
|
|
||||||
trace msg,
|
|
||||||
slot = shortLog(slot),
|
|
||||||
fromNow = shortLog(fromNow.offset),
|
|
||||||
cat = "scheduling"
|
|
||||||
|
|
||||||
await sleepAsync(fromNow.offset)
|
|
||||||
|
|
||||||
# Time passed - we might need to select a new head in that case
|
|
||||||
head = node.updateHead()
|
|
||||||
|
|
||||||
sleepToSlotOffset(
|
|
||||||
seconds(int64(SECONDS_PER_SLOT)) div 3, "Waiting to send attestations")
|
|
||||||
|
|
||||||
handleAttestations(node, head, slot)
|
|
||||||
|
|
||||||
# https://github.com/ethereum/eth2.0-specs/blob/v0.11.1/specs/phase0/validator.md#broadcast-aggregate
|
|
||||||
# If the validator is selected to aggregate (is_aggregator), then they
|
|
||||||
# broadcast their best aggregate as a SignedAggregateAndProof to the global
|
|
||||||
# aggregate channel (beacon_aggregate_and_proof) two-thirds of the way
|
|
||||||
# through the slot-that is, SECONDS_PER_SLOT * 2 / 3 seconds after the start
|
|
||||||
# of slot.
|
|
||||||
if slot > 2:
|
|
||||||
sleepToSlotOffset(
|
|
||||||
seconds(int64(SECONDS_PER_SLOT * 2) div 3),
|
|
||||||
"Waiting to aggregate attestations")
|
|
||||||
|
|
||||||
const TRAILING_DISTANCE = 1
|
|
||||||
let
|
|
||||||
aggregationSlot = slot - TRAILING_DISTANCE
|
|
||||||
aggregationHead = getAncestorAt(head, aggregationSlot)
|
|
||||||
|
|
||||||
broadcastAggregatedAttestations(
|
|
||||||
node, aggregationHead, aggregationSlot, TRAILING_DISTANCE)
|
|
||||||
|
|
||||||
return head
|
|
||||||
|
|
||||||
proc onSlotStart(node: BeaconNode, lastSlot, scheduledSlot: Slot) {.gcsafe, async.} =
|
proc onSlotStart(node: BeaconNode, lastSlot, scheduledSlot: Slot) {.gcsafe, async.} =
|
||||||
## Called at the beginning of a slot - usually every slot, but sometimes might
|
## Called at the beginning of a slot - usually every slot, but sometimes might
|
||||||
## skip a few in case we're running late.
|
## skip a few in case we're running late.
|
||||||
|
60
beacon_chain/beacon_node_common.nim
Normal file
60
beacon_chain/beacon_node_common.nim
Normal file
@ -0,0 +1,60 @@
|
|||||||
|
# beacon_chain
|
||||||
|
# Copyright (c) 2018-2020 Status Research & Development GmbH
|
||||||
|
# Licensed and distributed under either of
|
||||||
|
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
|
||||||
|
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
|
||||||
|
# at your option. This file may not be copied, modified, or distributed except according to those terms.
|
||||||
|
|
||||||
|
# Common routines for a BeaconNode and a BeaconValidator node
|
||||||
|
|
||||||
|
import
|
||||||
|
# Nimble packages
|
||||||
|
chronos, json_rpc/rpcserver, metrics,
|
||||||
|
|
||||||
|
# Local modules
|
||||||
|
spec/[datatypes, crypto],
|
||||||
|
conf, time, beacon_chain_db, validator_pool,
|
||||||
|
attestation_pool, block_pool, eth2_network,
|
||||||
|
beacon_node_types, mainchain_monitor,
|
||||||
|
sync_protocol, request_manager
|
||||||
|
|
||||||
|
type
|
||||||
|
RpcServer* = RpcHttpServer
|
||||||
|
|
||||||
|
BeaconNode* = ref object
|
||||||
|
nickname*: string
|
||||||
|
network*: Eth2Node
|
||||||
|
netKeys*: KeyPair
|
||||||
|
requestManager*: RequestManager
|
||||||
|
db*: BeaconChainDB
|
||||||
|
config*: BeaconNodeConf
|
||||||
|
attachedValidators*: ValidatorPool
|
||||||
|
blockPool*: BlockPool
|
||||||
|
attestationPool*: AttestationPool
|
||||||
|
mainchainMonitor*: MainchainMonitor
|
||||||
|
beaconClock*: BeaconClock
|
||||||
|
rpcServer*: RpcServer
|
||||||
|
forkDigest*: ForkDigest
|
||||||
|
topicBeaconBlocks*: string
|
||||||
|
topicAggregateAndProofs*: string
|
||||||
|
syncLoop*: Future[void]
|
||||||
|
|
||||||
|
const MaxEmptySlotCount* = uint64(10*60) div SECONDS_PER_SLOT
|
||||||
|
|
||||||
|
# Metrics
|
||||||
|
declareGauge beacon_head_root,
|
||||||
|
"Root of the head block of the beacon chain"
|
||||||
|
|
||||||
|
proc updateHead*(node: BeaconNode): BlockRef =
|
||||||
|
# Check pending attestations - maybe we found some blocks for them
|
||||||
|
node.attestationPool.resolve()
|
||||||
|
|
||||||
|
# Grab the new head according to our latest attestation data
|
||||||
|
let newHead = node.attestationPool.selectHead()
|
||||||
|
|
||||||
|
# Store the new head in the block pool - this may cause epochs to be
|
||||||
|
# justified and finalized
|
||||||
|
node.blockPool.updateHead(newHead)
|
||||||
|
beacon_head_root.set newHead.root.toGaugeValue
|
||||||
|
|
||||||
|
newHead
|
452
beacon_chain/validator_duties.nim
Normal file
452
beacon_chain/validator_duties.nim
Normal file
@ -0,0 +1,452 @@
|
|||||||
|
# beacon_chain
|
||||||
|
# Copyright (c) 2018-2020 Status Research & Development GmbH
|
||||||
|
# Licensed and distributed under either of
|
||||||
|
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
|
||||||
|
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
|
||||||
|
# at your option. This file may not be copied, modified, or distributed except according to those terms.
|
||||||
|
|
||||||
|
import
|
||||||
|
# Standard library
|
||||||
|
os, tables, random, strutils, times,
|
||||||
|
|
||||||
|
# Nimble packages
|
||||||
|
stew/[objects, bitseqs, byteutils], stew/shims/macros,
|
||||||
|
chronos, confutils, metrics, json_rpc/[rpcserver, jsonmarshal],
|
||||||
|
chronicles, chronicles/helpers as chroniclesHelpers,
|
||||||
|
json_serialization/std/[options, sets, net], serialization/errors,
|
||||||
|
eth/db/kvstore, eth/db/kvstore_sqlite3,
|
||||||
|
eth/p2p/enode, eth/[keys, async_utils], eth/p2p/discoveryv5/[protocol, enr],
|
||||||
|
|
||||||
|
# Local modules
|
||||||
|
spec/[datatypes, digest, crypto, beaconstate, helpers, validator, network,
|
||||||
|
state_transition_block], spec/presets/custom,
|
||||||
|
conf, time, beacon_chain_db, validator_pool, extras,
|
||||||
|
attestation_pool, block_pool, eth2_network, eth2_discovery,
|
||||||
|
beacon_node_common, beacon_node_types,
|
||||||
|
mainchain_monitor, version, ssz, ssz/dynamic_navigator,
|
||||||
|
sync_protocol, request_manager, validator_keygen, interop, statusbar,
|
||||||
|
attestation_aggregation, sync_manager, state_transition, sszdump
|
||||||
|
|
||||||
|
# Metrics for tracking attestation and beacon block loss
|
||||||
|
declareCounter beacon_attestations_sent,
|
||||||
|
"Number of beacon chain attestations sent by this peer"
|
||||||
|
declareCounter beacon_blocks_proposed,
|
||||||
|
"Number of beacon chain blocks sent by this peer"
|
||||||
|
|
||||||
|
logScope: topics = "beacval"
|
||||||
|
|
||||||
|
proc saveValidatorKey*(keyName, key: string, conf: BeaconNodeConf) =
|
||||||
|
let validatorsDir = conf.localValidatorsDir
|
||||||
|
let outputFile = validatorsDir / keyName
|
||||||
|
createDir validatorsDir
|
||||||
|
writeFile(outputFile, key)
|
||||||
|
info "Imported validator key", file = outputFile
|
||||||
|
|
||||||
|
template findIt(s: openarray, predicate: untyped): int =
|
||||||
|
var res = -1
|
||||||
|
for i, it {.inject.} in s:
|
||||||
|
if predicate:
|
||||||
|
res = i
|
||||||
|
break
|
||||||
|
res
|
||||||
|
|
||||||
|
proc addLocalValidator*(node: BeaconNode,
|
||||||
|
state: BeaconState,
|
||||||
|
privKey: ValidatorPrivKey) =
|
||||||
|
let pubKey = privKey.toPubKey()
|
||||||
|
|
||||||
|
let idx = state.validators.findIt(it.pubKey == pubKey)
|
||||||
|
if idx == -1:
|
||||||
|
# We allow adding a validator even if its key is not in the state registry:
|
||||||
|
# it might be that the deposit for this validator has not yet been processed
|
||||||
|
warn "Validator not in registry (yet?)", pubKey
|
||||||
|
|
||||||
|
node.attachedValidators.addLocalValidator(pubKey, privKey)
|
||||||
|
|
||||||
|
proc addLocalValidators*(node: BeaconNode, state: BeaconState) =
|
||||||
|
for validatorKey in node.config.validatorKeys:
|
||||||
|
node.addLocalValidator state, validatorKey
|
||||||
|
|
||||||
|
info "Local validators attached ", count = node.attachedValidators.count
|
||||||
|
|
||||||
|
func getAttachedValidator*(node: BeaconNode,
|
||||||
|
state: BeaconState,
|
||||||
|
idx: ValidatorIndex): AttachedValidator =
|
||||||
|
let validatorKey = state.validators[idx].pubkey
|
||||||
|
node.attachedValidators.getValidator(validatorKey)
|
||||||
|
|
||||||
|
proc isSynced(node: BeaconNode, head: BlockRef): bool =
|
||||||
|
## TODO This function is here as a placeholder for some better heurestics to
|
||||||
|
## determine if we're in sync and should be producing blocks and
|
||||||
|
## attestations. Generally, the problem is that slot time keeps advancing
|
||||||
|
## even when there are no blocks being produced, so there's no way to
|
||||||
|
## distinguish validators geniunely going missing from the node not being
|
||||||
|
## well connected (during a network split or an internet outage for
|
||||||
|
## example). It would generally be correct to simply keep running as if
|
||||||
|
## we were the only legit node left alive, but then we run into issues:
|
||||||
|
## with enough many empty slots, the validator pool is emptied leading
|
||||||
|
## to empty committees and lots of empty slot processing that will be
|
||||||
|
## thrown away as soon as we're synced again.
|
||||||
|
|
||||||
|
let
|
||||||
|
# The slot we should be at, according to the clock
|
||||||
|
beaconTime = node.beaconClock.now()
|
||||||
|
wallSlot = beaconTime.toSlot()
|
||||||
|
|
||||||
|
# TODO if everyone follows this logic, the network will not recover from a
|
||||||
|
# halt: nobody will be producing blocks because everone expects someone
|
||||||
|
# else to do it
|
||||||
|
if wallSlot.afterGenesis and head.slot + MaxEmptySlotCount < wallSlot.slot:
|
||||||
|
false
|
||||||
|
else:
|
||||||
|
true
|
||||||
|
|
||||||
|
proc sendAttestation(node: BeaconNode,
|
||||||
|
fork: Fork,
|
||||||
|
genesis_validators_root: Eth2Digest,
|
||||||
|
validator: AttachedValidator,
|
||||||
|
attestationData: AttestationData,
|
||||||
|
committeeLen: int,
|
||||||
|
indexInCommittee: int) {.async.} =
|
||||||
|
logScope: pcs = "send_attestation"
|
||||||
|
|
||||||
|
let validatorSignature = await validator.signAttestation(attestationData,
|
||||||
|
fork, genesis_validators_root)
|
||||||
|
|
||||||
|
var aggregationBits = CommitteeValidatorsBits.init(committeeLen)
|
||||||
|
aggregationBits.setBit indexInCommittee
|
||||||
|
|
||||||
|
var attestation = Attestation(
|
||||||
|
data: attestationData,
|
||||||
|
signature: validatorSignature,
|
||||||
|
aggregation_bits: aggregationBits
|
||||||
|
)
|
||||||
|
|
||||||
|
# https://github.com/ethereum/eth2.0-specs/blob/v0.11.1/specs/phase0/validator.md#broadcast-attestation
|
||||||
|
node.network.broadcast(
|
||||||
|
getAttestationTopic(node.forkDigest, attestationData.index), attestation)
|
||||||
|
|
||||||
|
if node.config.dumpEnabled:
|
||||||
|
dump(node.config.dumpDir, attestationData, validator.pubKey)
|
||||||
|
|
||||||
|
info "Attestation sent",
|
||||||
|
attestation = shortLog(attestation),
|
||||||
|
validator = shortLog(validator),
|
||||||
|
indexInCommittee = indexInCommittee,
|
||||||
|
cat = "consensus"
|
||||||
|
|
||||||
|
beacon_attestations_sent.inc()
|
||||||
|
|
||||||
|
proc proposeBlock(node: BeaconNode,
|
||||||
|
validator: AttachedValidator,
|
||||||
|
head: BlockRef,
|
||||||
|
slot: Slot): Future[BlockRef] {.async.} =
|
||||||
|
logScope: pcs = "block_proposal"
|
||||||
|
|
||||||
|
if head.slot >= slot:
|
||||||
|
# We should normally not have a head newer than the slot we're proposing for
|
||||||
|
# but this can happen if block proposal is delayed
|
||||||
|
warn "Skipping proposal, have newer head already",
|
||||||
|
headSlot = shortLog(head.slot),
|
||||||
|
headBlockRoot = shortLog(head.root),
|
||||||
|
slot = shortLog(slot),
|
||||||
|
cat = "fastforward"
|
||||||
|
return head
|
||||||
|
|
||||||
|
# Advance state to the slot that we're proposing for - this is the equivalent
|
||||||
|
# of running `process_slots` up to the slot of the new block.
|
||||||
|
let (nroot, nblck) = node.blockPool.withState(
|
||||||
|
node.blockPool.tmpState, head.atSlot(slot)):
|
||||||
|
let (eth1data, deposits) =
|
||||||
|
if node.mainchainMonitor.isNil:
|
||||||
|
(get_eth1data_stub(state.eth1_deposit_index, slot.compute_epoch_at_slot()),
|
||||||
|
newSeq[Deposit]())
|
||||||
|
else:
|
||||||
|
node.mainchainMonitor.getBlockProposalData(state)
|
||||||
|
|
||||||
|
let message = makeBeaconBlock(
|
||||||
|
state,
|
||||||
|
head.root,
|
||||||
|
validator.genRandaoReveal(state.fork, state.genesis_validators_root, slot),
|
||||||
|
eth1data,
|
||||||
|
Eth2Digest(),
|
||||||
|
node.attestationPool.getAttestationsForBlock(state),
|
||||||
|
deposits)
|
||||||
|
|
||||||
|
if not message.isSome():
|
||||||
|
return head # already logged elsewhere!
|
||||||
|
var
|
||||||
|
newBlock = SignedBeaconBlock(
|
||||||
|
message: message.get()
|
||||||
|
)
|
||||||
|
|
||||||
|
let blockRoot = hash_tree_root(newBlock.message)
|
||||||
|
|
||||||
|
# Careful, state no longer valid after here because of the await..
|
||||||
|
newBlock.signature = await validator.signBlockProposal(
|
||||||
|
state.fork, state.genesis_validators_root, slot, blockRoot)
|
||||||
|
|
||||||
|
(blockRoot, newBlock)
|
||||||
|
|
||||||
|
let newBlockRef = node.blockPool.add(nroot, nblck)
|
||||||
|
if newBlockRef == nil:
|
||||||
|
warn "Unable to add proposed block to block pool",
|
||||||
|
newBlock = shortLog(newBlock.message),
|
||||||
|
blockRoot = shortLog(blockRoot),
|
||||||
|
cat = "bug"
|
||||||
|
return head
|
||||||
|
|
||||||
|
info "Block proposed",
|
||||||
|
blck = shortLog(newBlock.message),
|
||||||
|
blockRoot = shortLog(newBlockRef.root),
|
||||||
|
validator = shortLog(validator),
|
||||||
|
cat = "consensus"
|
||||||
|
|
||||||
|
if node.config.dumpEnabled:
|
||||||
|
dump(node.config.dumpDir, newBlock, newBlockRef)
|
||||||
|
node.blockPool.withState(
|
||||||
|
node.blockPool.tmpState, newBlockRef.atSlot(newBlockRef.slot)):
|
||||||
|
dump(node.config.dumpDir, hashedState, newBlockRef)
|
||||||
|
|
||||||
|
node.network.broadcast(node.topicBeaconBlocks, newBlock)
|
||||||
|
|
||||||
|
beacon_blocks_proposed.inc()
|
||||||
|
|
||||||
|
return newBlockRef
|
||||||
|
|
||||||
|
|
||||||
|
proc handleAttestations(node: BeaconNode, head: BlockRef, slot: Slot) =
|
||||||
|
## Perform all attestations that the validators attached to this node should
|
||||||
|
## perform during the given slot
|
||||||
|
logScope: pcs = "on_attestation"
|
||||||
|
|
||||||
|
if slot + SLOTS_PER_EPOCH < head.slot:
|
||||||
|
# The latest block we know about is a lot newer than the slot we're being
|
||||||
|
# asked to attest to - this makes it unlikely that it will be included
|
||||||
|
# at all.
|
||||||
|
# TODO the oldest attestations allowed are those that are older than the
|
||||||
|
# finalized epoch.. also, it seems that posting very old attestations
|
||||||
|
# is risky from a slashing perspective. More work is needed here.
|
||||||
|
notice "Skipping attestation, head is too recent",
|
||||||
|
headSlot = shortLog(head.slot),
|
||||||
|
slot = shortLog(slot)
|
||||||
|
return
|
||||||
|
|
||||||
|
let attestationHead = head.atSlot(slot)
|
||||||
|
if head != attestationHead.blck:
|
||||||
|
# In rare cases, such as when we're busy syncing or just slow, we'll be
|
||||||
|
# attesting to a past state - we must then recreate the world as it looked
|
||||||
|
# like back then
|
||||||
|
notice "Attesting to a state in the past, falling behind?",
|
||||||
|
headSlot = shortLog(head.slot),
|
||||||
|
attestationHeadSlot = shortLog(attestationHead.slot),
|
||||||
|
attestationSlot = shortLog(slot)
|
||||||
|
|
||||||
|
trace "Checking attestations",
|
||||||
|
attestationHeadRoot = shortLog(attestationHead.blck.root),
|
||||||
|
attestationSlot = shortLog(slot),
|
||||||
|
cat = "attestation"
|
||||||
|
|
||||||
|
# Collect data to send before node.stateCache grows stale
|
||||||
|
var attestations: seq[tuple[
|
||||||
|
data: AttestationData, committeeLen, indexInCommittee: int,
|
||||||
|
validator: AttachedValidator]]
|
||||||
|
|
||||||
|
# We need to run attestations exactly for the slot that we're attesting to.
|
||||||
|
# In case blocks went missing, this means advancing past the latest block
|
||||||
|
# using empty slots as fillers.
|
||||||
|
# https://github.com/ethereum/eth2.0-specs/blob/v0.8.4/specs/validator/0_beacon-chain-validator.md#validator-assignments
|
||||||
|
# TODO we could cache the validator assignment since it's valid for the entire
|
||||||
|
# epoch since it doesn't change, but that has to be weighed against
|
||||||
|
# the complexity of handling forks correctly - instead, we use an adapted
|
||||||
|
# version here that calculates the committee for a single slot only
|
||||||
|
node.blockPool.withState(node.blockPool.tmpState, attestationHead):
|
||||||
|
var cache = get_empty_per_epoch_cache()
|
||||||
|
let committees_per_slot = get_committee_count_at_slot(state, slot)
|
||||||
|
|
||||||
|
for committee_index in 0'u64..<committees_per_slot:
|
||||||
|
let committee = get_beacon_committee(
|
||||||
|
state, slot, committee_index.CommitteeIndex, cache)
|
||||||
|
|
||||||
|
for index_in_committee, validatorIdx in committee:
|
||||||
|
let validator = node.getAttachedValidator(state, validatorIdx)
|
||||||
|
if validator != nil:
|
||||||
|
let ad = makeAttestationData(state, slot, committee_index, blck.root)
|
||||||
|
attestations.add((ad, committee.len, index_in_committee, validator))
|
||||||
|
|
||||||
|
for a in attestations:
|
||||||
|
traceAsyncErrors sendAttestation(
|
||||||
|
node, state.fork, state.genesis_validators_root, a.validator, a.data,
|
||||||
|
a.committeeLen, a.indexInCommittee)
|
||||||
|
|
||||||
|
proc handleProposal(node: BeaconNode, head: BlockRef, slot: Slot):
|
||||||
|
Future[BlockRef] {.async.} =
|
||||||
|
## Perform the proposal for the given slot, iff we have a validator attached
|
||||||
|
## that is supposed to do so, given the shuffling in head
|
||||||
|
|
||||||
|
# TODO here we advance the state to the new slot, but later we'll be
|
||||||
|
# proposing for it - basically, we're selecting proposer based on an
|
||||||
|
# empty slot
|
||||||
|
|
||||||
|
let proposerKey = node.blockPool.getProposer(head, slot)
|
||||||
|
if proposerKey.isNone():
|
||||||
|
return head
|
||||||
|
|
||||||
|
let validator = node.attachedValidators.getValidator(proposerKey.get())
|
||||||
|
|
||||||
|
if validator != nil:
|
||||||
|
return await proposeBlock(node, validator, head, slot)
|
||||||
|
|
||||||
|
debug "Expecting block proposal",
|
||||||
|
headRoot = shortLog(head.root),
|
||||||
|
slot = shortLog(slot),
|
||||||
|
proposer = shortLog(proposerKey.get()),
|
||||||
|
cat = "consensus",
|
||||||
|
pcs = "wait_for_proposal"
|
||||||
|
|
||||||
|
return head
|
||||||
|
|
||||||
|
|
||||||
|
proc broadcastAggregatedAttestations(
|
||||||
|
node: BeaconNode, aggregationHead: BlockRef, aggregationSlot: Slot,
|
||||||
|
trailing_distance: uint64) =
|
||||||
|
# The index is via a
|
||||||
|
# locally attested validator. Unlike in handleAttestations(...) there's a
|
||||||
|
# single one at most per slot (because that's how aggregation attestation
|
||||||
|
# works), so the machinery that has to handle looping across, basically a
|
||||||
|
# set of locally attached validators is in principle not necessary, but a
|
||||||
|
# way to organize this. Then the private key for that validator should be
|
||||||
|
# the corresponding one -- whatver they are, they match.
|
||||||
|
|
||||||
|
let bs = BlockSlot(blck: aggregationHead, slot: aggregationSlot)
|
||||||
|
node.blockPool.withState(node.blockPool.tmpState, bs):
|
||||||
|
let
|
||||||
|
committees_per_slot = get_committee_count_at_slot(state, aggregationSlot)
|
||||||
|
var cache = get_empty_per_epoch_cache()
|
||||||
|
for committee_index in 0'u64..<committees_per_slot:
|
||||||
|
let committee = get_beacon_committee(
|
||||||
|
state, aggregationSlot, committee_index.CommitteeIndex, cache)
|
||||||
|
|
||||||
|
for index_in_committee, validatorIdx in committee:
|
||||||
|
let validator = node.getAttachedValidator(state, validatorIdx)
|
||||||
|
if validator != nil:
|
||||||
|
# This is slightly strange/inverted control flow, since really it's
|
||||||
|
# going to happen once per slot, but this is the best way to get at
|
||||||
|
# the validator index and private key pair. TODO verify it only has
|
||||||
|
# one isSome() with test.
|
||||||
|
let aggregateAndProof =
|
||||||
|
aggregate_attestations(node.attestationPool, state,
|
||||||
|
committee_index.CommitteeIndex,
|
||||||
|
# TODO https://github.com/status-im/nim-beacon-chain/issues/545
|
||||||
|
# this assumes in-process private keys
|
||||||
|
validator.privKey,
|
||||||
|
trailing_distance)
|
||||||
|
|
||||||
|
# Don't broadcast when, e.g., this node isn't an aggregator
|
||||||
|
if aggregateAndProof.isSome:
|
||||||
|
var signedAP = SignedAggregateAndProof(
|
||||||
|
message: aggregateAndProof.get,
|
||||||
|
# TODO Make the signing async here
|
||||||
|
signature: validator.signAggregateAndProof(
|
||||||
|
aggregateAndProof.get, state.fork,
|
||||||
|
state.genesis_validators_root))
|
||||||
|
node.network.broadcast(node.topicAggregateAndProofs, signedAP)
|
||||||
|
|
||||||
|
proc handleValidatorDuties*(
|
||||||
|
node: BeaconNode, head: BlockRef, lastSlot, slot: Slot): Future[BlockRef] {.async.} =
|
||||||
|
## Perform validator duties - create blocks, vote and aggreagte existing votes
|
||||||
|
if node.attachedValidators.count == 0:
|
||||||
|
# Nothing to do because we have no validator attached
|
||||||
|
return head
|
||||||
|
|
||||||
|
if not node.isSynced(head):
|
||||||
|
notice "Node out of sync, skipping validator duties",
|
||||||
|
slot, headSlot = head.slot
|
||||||
|
return head
|
||||||
|
|
||||||
|
var curSlot = lastSlot + 1
|
||||||
|
var head = head
|
||||||
|
|
||||||
|
# Start by checking if there's work we should have done in the past that we
|
||||||
|
# can still meaningfully do
|
||||||
|
while curSlot < slot:
|
||||||
|
# TODO maybe even collect all work synchronously to avoid unnecessary
|
||||||
|
# state rewinds while waiting for async operations like validator
|
||||||
|
# signature..
|
||||||
|
notice "Catching up",
|
||||||
|
curSlot = shortLog(curSlot),
|
||||||
|
lastSlot = shortLog(lastSlot),
|
||||||
|
slot = shortLog(slot),
|
||||||
|
cat = "overload"
|
||||||
|
|
||||||
|
# For every slot we're catching up, we'll propose then send
|
||||||
|
# attestations - head should normally be advancing along the same branch
|
||||||
|
# in this case
|
||||||
|
# TODO what if we receive blocks / attestations while doing this work?
|
||||||
|
head = await handleProposal(node, head, curSlot)
|
||||||
|
|
||||||
|
# For each slot we missed, we need to send out attestations - if we were
|
||||||
|
# proposing during this time, we'll use the newly proposed head, else just
|
||||||
|
# keep reusing the same - the attestation that goes out will actually
|
||||||
|
# rewind the state to what it looked like at the time of that slot
|
||||||
|
# TODO smells like there's an optimization opportunity here
|
||||||
|
handleAttestations(node, head, curSlot)
|
||||||
|
|
||||||
|
curSlot += 1
|
||||||
|
|
||||||
|
head = await handleProposal(node, head, slot)
|
||||||
|
|
||||||
|
# We've been doing lots of work up until now which took time. Normally, we
|
||||||
|
# send out attestations at the slot thirds-point, so we go back to the clock
|
||||||
|
# to see how much time we need to wait.
|
||||||
|
# TODO the beacon clock might jump here also. It's probably easier to complete
|
||||||
|
# the work for the whole slot using a monotonic clock instead, then deal
|
||||||
|
# with any clock discrepancies once only, at the start of slot timer
|
||||||
|
# processing..
|
||||||
|
|
||||||
|
# https://github.com/ethereum/eth2.0-specs/blob/v0.11.1/specs/phase0/validator.md#attesting
|
||||||
|
# A validator should create and broadcast the attestation to the associated
|
||||||
|
# attestation subnet when either (a) the validator has received a valid
|
||||||
|
# block from the expected block proposer for the assigned slot or
|
||||||
|
# (b) one-third of the slot has transpired (`SECONDS_PER_SLOT / 3` seconds
|
||||||
|
# after the start of slot) -- whichever comes first.
|
||||||
|
template sleepToSlotOffset(extra: chronos.Duration, msg: static string) =
|
||||||
|
let
|
||||||
|
fromNow = node.beaconClock.fromNow(slot.toBeaconTime(extra))
|
||||||
|
|
||||||
|
if fromNow.inFuture:
|
||||||
|
trace msg,
|
||||||
|
slot = shortLog(slot),
|
||||||
|
fromNow = shortLog(fromNow.offset),
|
||||||
|
cat = "scheduling"
|
||||||
|
|
||||||
|
await sleepAsync(fromNow.offset)
|
||||||
|
|
||||||
|
# Time passed - we might need to select a new head in that case
|
||||||
|
head = node.updateHead()
|
||||||
|
|
||||||
|
sleepToSlotOffset(
|
||||||
|
seconds(int64(SECONDS_PER_SLOT)) div 3, "Waiting to send attestations")
|
||||||
|
|
||||||
|
handleAttestations(node, head, slot)
|
||||||
|
|
||||||
|
# https://github.com/ethereum/eth2.0-specs/blob/v0.11.1/specs/phase0/validator.md#broadcast-aggregate
|
||||||
|
# If the validator is selected to aggregate (is_aggregator), then they
|
||||||
|
# broadcast their best aggregate as a SignedAggregateAndProof to the global
|
||||||
|
# aggregate channel (beacon_aggregate_and_proof) two-thirds of the way
|
||||||
|
# through the slot-that is, SECONDS_PER_SLOT * 2 / 3 seconds after the start
|
||||||
|
# of slot.
|
||||||
|
if slot > 2:
|
||||||
|
sleepToSlotOffset(
|
||||||
|
seconds(int64(SECONDS_PER_SLOT * 2) div 3),
|
||||||
|
"Waiting to aggregate attestations")
|
||||||
|
|
||||||
|
const TRAILING_DISTANCE = 1
|
||||||
|
let
|
||||||
|
aggregationSlot = slot - TRAILING_DISTANCE
|
||||||
|
aggregationHead = getAncestorAt(head, aggregationSlot)
|
||||||
|
|
||||||
|
broadcastAggregatedAttestations(
|
||||||
|
node, aggregationHead, aggregationSlot, TRAILING_DISTANCE)
|
||||||
|
|
||||||
|
return head
|
Loading…
x
Reference in New Issue
Block a user