avoid packing attestations from other forks (#3893)
When there is heavy forking, proposals may get missed due to including attestations from different forks that later fail verification. Checking attestation signatures when building blocks should fix this.
This commit is contained in:
parent
735c1df62f
commit
5dcfb0c4e7
|
@ -577,8 +577,7 @@ proc getAttestationsForBlock*(pool: var AttestationPool,
|
||||||
# Attestations are checked based on the state that we're adding the
|
# Attestations are checked based on the state that we're adding the
|
||||||
# attestation to - there might have been a fork between when we first
|
# attestation to - there might have been a fork between when we first
|
||||||
# saw the attestation and the time that we added it
|
# saw the attestation and the time that we added it
|
||||||
if not check_attestation(
|
if check_attestation(state.data, attestation, {}, cache).isErr():
|
||||||
state.data, attestation, {skipBlsValidation}, cache).isOk():
|
|
||||||
continue
|
continue
|
||||||
|
|
||||||
let score = attCache.score(
|
let score = attCache.score(
|
||||||
|
|
Loading…
Reference in New Issue