From 5b3c211285187c41cc452cee172f737506376738 Mon Sep 17 00:00:00 2001
From: Etan Kissling <etan@status.im>
Date: Tue, 9 May 2023 11:44:24 +0200
Subject: [PATCH] `checkedReject` > `errReject` for CI failure (#4909)

The `SignedContributionAndProof: invalid contribution signature` check
is sometimes hit around fork boundaries when running local testnet.
To avoid failing CI, revert this isntance to a plain `errReject` until
the underlying problem is addressed.
---
 beacon_chain/gossip_processing/gossip_validation.nim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/beacon_chain/gossip_processing/gossip_validation.nim b/beacon_chain/gossip_processing/gossip_validation.nim
index 0a2113071..ba2cac966 100644
--- a/beacon_chain/gossip_processing/gossip_validation.nim
+++ b/beacon_chain/gossip_processing/gossip_validation.nim
@@ -1217,7 +1217,7 @@ proc validateContribution*(
       let x = await contributionFut
       case x
       of BatchResult.Invalid:
-        return dag.checkedReject(
+        return errReject(  # TODO Triggers in local tests around fork transition
           "SignedContributionAndProof: invalid contribution signature")
       of BatchResult.Timeout:
         beacon_contributions_dropped_queue_full.inc()