status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

denote merge readiness in default graffiti 

Replace `-$versionBlob` in default graffiti with `/🐼` to indicate
merge readiness according to social consensus.

Our current default graffiti format currently uses 32 bytes, which is
right at the capacity of what is possible. If we ever have a .10 patch
in Oct/Nov/Dec, we would be surprised by an overflow.
```
Nimbus/v##.##.#-######-stateofus
```
This commit is contained in:
Etan Kissling 2022-09-06 23:44:13 +02:00
parent 8fbb3d975b
commit 495e443f11
No known key found for this signature in database
GPG Key ID: B21DA824C5A3D03D
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_chain/spec/datatypes/base.nim
View File

@ -871,7 +871,7 @@ func init*(
func defaultGraffitiBytes*(): GraffitiBytes = func defaultGraffitiBytes*(): GraffitiBytes =
const graffitiBytes = const graffitiBytes =
toBytes("Nimbus/" & fullVersionStr) toBytes("Nimbus/" & shortVersionStr & "/🐼") # PR #2875
static: doAssert graffitiBytes.len <= MAX_GRAFFITI_SIZE static: doAssert graffitiBytes.len <= MAX_GRAFFITI_SIZE
distinctBase(result)[0 ..< graffitiBytes.len] = graffitiBytes distinctBase(result)[0 ..< graffitiBytes.len] = graffitiBytes

5
beacon_chain/version.nim
View File

@ -20,7 +20,7 @@ const
versionMinor* = 8 versionMinor* = 8
versionBuild* = 2 versionBuild* = 2
versionBlob* = "stateofus" # Single word - ends up in the default graffiti versionBlob* = "stateofus" # Single word
gitRevision* = strip(staticExec("git rev-parse --short HEAD"))[0..5] gitRevision* = strip(staticExec("git rev-parse --short HEAD"))[0..5]
@ -29,7 +29,8 @@ const
versionAsStr* = versionAsStr* =
$versionMajor & "." & $versionMinor & "." & $versionBuild $versionMajor & "." & $versionMinor & "." & $versionBuild
fullVersionStr* = "v" & versionAsStr & "-" & gitRevision & "-" & versionBlob shortVersionStr* = "v" & versionAsStr & "-" & gitRevision
fullVersionStr* = shortVersionStr & "-" & versionBlob
func shortNimBanner*(): string = func shortNimBanner*(): string =
const gitPrefix = "git hash: " const gitPrefix = "git hash: "