From 47a1b11d5d7afdcf21665ddc217242ca7523c8d6 Mon Sep 17 00:00:00 2001 From: Etan Kissling Date: Thu, 14 Jul 2022 05:33:15 +0200 Subject: [PATCH] revert `requireAllFields` regression (#3870) #3864 introduced a regression by turning on `requireAllFields` globally for JSON parsing. Certain endpoints such as `RestSyncInfo` have optional fields that do not parse correctly without additional changes. This is reverted for now to restore previous behaviour and unblock CI testing. --- beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim b/beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim index 957a48b78..17dbdebd2 100644 --- a/beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim +++ b/beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim @@ -2179,7 +2179,7 @@ proc decodeBody*[T](t: typedesc[T], let data = try: RestJson.decode(body.data, T, - requireAllFields = true, + requireAllFields = false, allowUnknownFields = true) except SerializationError as exc: debug "Failed to deserialize REST JSON data", @@ -2233,7 +2233,7 @@ proc decodeBytes*[T: DecodeTypes](t: typedesc[T], value: openArray[byte], of "application/json": try: ok RestJson.decode(value, T, - requireAllFields = true, + requireAllFields = false, allowUnknownFields = true) except SerializationError as exc: debug "Failed to deserialize REST JSON data",