status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

rank peers by their score instead of their memory address 

The `<` function to compare peers was not exported, leading to the same
peer be acquired over and over again until kick. `mixin` doesn't pull it
into `peerCmp` without `*` export, and with the export no mixin needed.
This commit is contained in:
Etan Kissling 2024-03-27 23:10:09 +01:00
parent 885989f3df
commit 40242ac277
No known key found for this signature in database
GPG Key ID: B21DA824C5A3D03D
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
beacon_chain/networking/eth2_network.nim
View File

@ -456,15 +456,15 @@ func netKbps*(peer: Peer): float {.inline.} =
## Returns current network throughput average value in Kbps for peer ``peer``. ## Returns current network throughput average value in Kbps for peer ``peer``.
round(((peer.netThroughput.average / 1024) * 10_000) / 10_000) round(((peer.netThroughput.average / 1024) * 10_000) / 10_000)
func `<`(a, b: Peer): bool = # /!\ Must be exported to be seen by `peerCmp`
## Comparison function, which first checks peer's scores, and if the peers' func `<`*(a, b: Peer): bool =
## score is equal it compares peers' network throughput. ## Comparison function indicating `true` if peer `a` ranks worse than peer `b`
if a.score < b.score: if a.score != b.score:
true a.score < b.score
elif a.score == b.score: elif a.netThroughput.average != b.netThroughput.average:
(a.netThroughput.average < b.netThroughput.average) a.netThroughput.average < b.netThroughput.average
else: else:
false system.`<`(a, b)
const const
maxRequestQuota = 1000000 maxRequestQuota = 1000000