status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

detect excessively long graffiti strings

This commit is contained in:
Dustin Brody 2020-12-01 12:36:16 +01:00 committed by zah
parent 68c91d1d1b
commit 3e4b49462b
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
beacon_chain/spec/datatypes.nim
View File

@ -60,6 +60,7 @@ const
# Not part of spec. Still useful, pending removing usage if appropriate.
ZERO_HASH* = Eth2Digest()
MAX_GRAFFITI_SIZE = 32
# https://github.com/ethereum/eth2.0-specs/blob/v1.0.0/specs/phase0/p2p-interface.md#configuration
ATTESTATION_PROPAGATION_SLOT_RANGE* = 32
@ -257,7 +258,7 @@ type
object_root*: Eth2Digest
domain*: Domain
GraffitiBytes* = distinct array[32, byte]
GraffitiBytes* = distinct array[MAX_GRAFFITI_SIZE, byte]
# https://github.com/ethereum/eth2.0-specs/blob/v1.0.0/specs/phase0/beacon-chain.md#beaconblockbody
BeaconBlockBody* = object
@ -805,13 +806,14 @@ func init*(T: type GraffitiBytes, input: string): GraffitiBytes
hexToByteArray(input, distinctBase(result))
else:
if input.len > 32:
if input.len > MAX_GRAFFITI_SIZE:
raise newException(ValueError, "The graffiti value should be 32 characters or less")
distinctBase(result)[0 ..< input.len] = toBytes(input)
func defaultGraffitiBytes*(): GraffitiBytes =
let graffitiBytes =
const graffitiBytes =
toBytes("Nimbus/" & fullVersionStr)
static: doAssert graffitiBytes.len <= MAX_GRAFFITI_SIZE
distinctBase(result)[0 ..< graffitiBytes.len] = graffitiBytes
proc writeValue*(w: var JsonWriter, value: GraffitiBytes)