status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix remaining attester slashing tests from EF phase0 spec tests by checking for uniqueness

This commit is contained in:
Dustin Brody 2020-04-17 15:46:51 +02:00 committed by tersec
parent 05d1d1246a
commit 3df9a22ff7
5 changed files with 10 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
FixtureAll-mainnet.md
View File

@ -68,9 +68,11 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
```diff ```diff
+ [Invalid] att1_bad_extra_index OK + [Invalid] att1_bad_extra_index OK
+ [Invalid] att1_bad_replaced_index OK + [Invalid] att1_bad_replaced_index OK
+ [Invalid] att1_duplicate_index_double_signed OK
+ [Invalid] att1_duplicate_index_normal_signed OK + [Invalid] att1_duplicate_index_normal_signed OK
+ [Invalid] att2_bad_extra_index OK + [Invalid] att2_bad_extra_index OK
+ [Invalid] att2_bad_replaced_index OK + [Invalid] att2_bad_replaced_index OK
+ [Invalid] att2_duplicate_index_double_signed OK
+ [Invalid] att2_duplicate_index_normal_signed OK + [Invalid] att2_duplicate_index_normal_signed OK
+ [Invalid] invalid_sig_1 OK + [Invalid] invalid_sig_1 OK
+ [Invalid] invalid_sig_1_and_2 OK + [Invalid] invalid_sig_1_and_2 OK
@ -85,7 +87,7 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
+ [Valid] success_double OK + [Valid] success_double OK
+ [Valid] success_surround OK + [Valid] success_surround OK
``` ```
OK: 18/18 Fail: 0/18 Skip: 0/18 OK: 20/20 Fail: 0/20 Skip: 0/20
## Official - Operations - Block header [Preset: mainnet] ## Official - Operations - Block header [Preset: mainnet]
```diff ```diff
+ [Invalid] invalid_parent_root OK + [Invalid] invalid_parent_root OK
@ -163,4 +165,4 @@ OK: 19/19 Fail: 0/19 Skip: 0/19
OK: 5/5 Fail: 0/5 Skip: 0/5 OK: 5/5 Fail: 0/5 Skip: 0/5
---TOTAL--- ---TOTAL---
OK: 113/113 Fail: 0/113 Skip: 0/113 OK: 115/115 Fail: 0/115 Skip: 0/115

6
FixtureAll-minimal.md
View File

@ -68,9 +68,11 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
```diff ```diff
+ [Invalid] att1_bad_extra_index OK + [Invalid] att1_bad_extra_index OK
+ [Invalid] att1_bad_replaced_index OK + [Invalid] att1_bad_replaced_index OK
+ [Invalid] att1_duplicate_index_double_signed OK
+ [Invalid] att1_duplicate_index_normal_signed OK + [Invalid] att1_duplicate_index_normal_signed OK
+ [Invalid] att2_bad_extra_index OK + [Invalid] att2_bad_extra_index OK
+ [Invalid] att2_bad_replaced_index OK + [Invalid] att2_bad_replaced_index OK
+ [Invalid] att2_duplicate_index_double_signed OK
+ [Invalid] att2_duplicate_index_normal_signed OK + [Invalid] att2_duplicate_index_normal_signed OK
+ [Invalid] invalid_sig_1 OK + [Invalid] invalid_sig_1 OK
+ [Invalid] invalid_sig_1_and_2 OK + [Invalid] invalid_sig_1_and_2 OK
@ -85,7 +87,7 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
+ [Valid] success_double OK + [Valid] success_double OK
+ [Valid] success_surround OK + [Valid] success_surround OK
``` ```
OK: 18/18 Fail: 0/18 Skip: 0/18 OK: 20/20 Fail: 0/20 Skip: 0/20
## Official - Operations - Block header [Preset: minimal] ## Official - Operations - Block header [Preset: minimal]
```diff ```diff
+ [Invalid] invalid_parent_root OK + [Invalid] invalid_parent_root OK
@ -166,4 +168,4 @@ OK: 22/22 Fail: 0/22 Skip: 0/22
OK: 5/5 Fail: 0/5 Skip: 0/5 OK: 5/5 Fail: 0/5 Skip: 0/5
---TOTAL--- ---TOTAL---
OK: 116/116 Fail: 0/116 Skip: 0/116 OK: 118/118 Fail: 0/118 Skip: 0/118

2
beacon_chain/spec/beaconstate.nim
View File

@ -395,7 +395,7 @@ proc is_valid_indexed_attestation*(
return false return false
# Verify indices are sorted and unique # Verify indices are sorted and unique
if indices != sorted(indices, system.cmp): if indices != sorted(toSet(indices).toSeq, system.cmp):
notice "indexed attestation: indices not sorted" notice "indexed attestation: indices not sorted"
return false return false

2
beacon_chain/spec/state_transition_block.nim
View File

@ -222,7 +222,7 @@ func is_slashable_attestation_data(
(data_1.source.epoch < data_2.source.epoch and (data_1.source.epoch < data_2.source.epoch and
data_2.target.epoch < data_1.target.epoch) data_2.target.epoch < data_1.target.epoch)
# https://github.com/ethereum/eth2.0-specs/blob/v0.10.1/specs/phase0/beacon-chain.md#attester-slashings # https://github.com/ethereum/eth2.0-specs/blob/v0.11.1/specs/phase0/beacon-chain.md#attester-slashings
proc process_attester_slashing*( proc process_attester_slashing*(
state: var BeaconState, state: var BeaconState,
attester_slashing: AttesterSlashing, attester_slashing: AttesterSlashing,

15
tests/official/test_fixture_operations_attester_slashings.nim
View File

@ -65,20 +65,5 @@ proc runTest(identifier: string) =
`testImpl _ operations_attester_slashing _ identifier`() `testImpl _ operations_attester_slashing _ identifier`()
suiteReport "Official - Operations - Attester slashing " & preset(): suiteReport "Official - Operations - Attester slashing " & preset():
# TODO these are both valid and check BLS signatures, which isn't working
# since 0.10.x introduces new BLS signing/verifying interface with domain
# in particular handled differently through compute_signing_root() rather
# than through the bls_verify(...) call directly. This did not become the
# visible issue it now is because another bug had been masking it wherein
# crypto.nim's bls_verify(...) call had been creating false positives, in
# which cases signature checks had been incorrectly passing.
const expected_failures =
[
# TODO: Regressions introduced by BLS v0.10.1
"att1_duplicate_index_double_signed", "att2_duplicate_index_double_signed"
]
for kind, path in walkDir(OpAttSlashingDir, true): for kind, path in walkDir(OpAttSlashingDir, true):
if path in expected_failures:
echo "Skipping test: ", path
continue
runTest(path) runTest(path)