status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-01-31 16:58:31 +00:00
Code Issues Projects Releases Wiki Activity

Do not reward empty responses. (#1827)

Browse Source 
Request status from peers every StatusExpirationTime.
This commit is contained in:
Eugene Kabanov 2020-10-08 15:50:48 +03:00 committed by GitHub
parent d534570cf6
commit 3bd7ab4c20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
beacon_chain/sync_manager.nim
View File

@ -35,6 +35,9 @@ const
StatusUpdateInterval* = chronos.minutes(1)
## Minimum time between two subsequent calls to update peer's status
StatusExpirationTime* = chronos.minutes(2)
## Time time it takes for the peer's status information to expire.
type
SyncFailureKind* = enum
StatusInvalid,
@ -465,8 +468,10 @@ proc push*[T](sq: SyncQueue[T], sr: SyncRequest[T],
if res.isOk:
sq.outSlot = sq.outSlot + item.request.count
# If there no error we should reward peer with some bonus score.
item.request.item.updateScore(PeerScoreGoodBlocks)
if len(item.data) > 0:
# If there no error and response was not empty we should reward peer
# with some bonus score.
item.request.item.updateScore(PeerScoreGoodBlocks)
sq.wakeupWaiters()
else:
debug "Block pool rejected peer's response", peer = item.request.item,
@ -699,7 +704,7 @@ proc syncStep[A, B](man: SyncManager[A, B], index: int, peer: A) {.async.} =
return
# Check if we need to update peer's status information
if peerAge >= man.maxStatusAge:
if peerStatusAge >= StatusExpirationTime:
# Peer's status information is very old, its time to update it
man.workers[index].status = SyncWorkerStatus.UpdatingStatus
trace "Updating peer's status information", wall_clock_slot = wallSlot,