status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-02-17 00:47:03 +00:00
Code Issues Projects Releases Wiki Activity

ProveField cleanups in slashing_protection_common (#5477)

Browse Source 
Cleanup of `ProveField` warnings in `slashing_protection_common` module.
Note that `ProveField` is disabled by default in makefile, but sometimes
these pop up when doing a regular `nim c`, and cleaning these may allow
enabling the warning in some future.

As the `case` is over `a.kind`, `ProveField` warnings for `b` have to be
suppressed using `{.push.}` / `{.pop.}` for comparison operators.
This commit is contained in:
Etan Kissling 2023-10-04 10:26:52 +02:00 committed by GitHub
parent 24c68bbcf7
commit 37967ba03b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
beacon_chain/validators/slashing_protection_common.nim
View File

@ -141,6 +141,7 @@ type
of BadProposalKind.DatabaseError:
message*: string
{.push warning[ProveField]:off.}
func `==`*(a, b: BadVote): bool =
## Comparison operator.
## Used implictily by Result when comparing the
@ -167,6 +168,7 @@ func `==`*(a, b: BadVote): bool =
(a.candidateTarget == b.candidateTarget)
of BadVoteKind.DatabaseError:
true
{.pop.}
template `==`*(a, b: PubKey0x): bool =
PubKeyBytes(a) == PubKeyBytes(b)
@ -177,6 +179,7 @@ template `<`*(a, b: PubKey0x): bool =
template cmp*(a, b: PubKey0x): bool =
cmp(PubKeyBytes(a), PubKeyBytes(b))
{.push warning[ProveField]:off.}
func `==`*(a, b: BadProposal): bool =
## Comparison operator.
## Used implictily by Result when comparing the
@ -192,6 +195,7 @@ func `==`*(a, b: BadProposal): bool =
a.candidateSlot == b.candidateSlot
else: # Unreachable
false
{.pop.}
# Serialization
# --------------------------------------------