From 30b7c6153ff6505c5eb5a303562e0440de190698 Mon Sep 17 00:00:00 2001
From: Etan Kissling <etan@status.im>
Date: Sat, 17 Feb 2024 18:19:30 +0100
Subject: [PATCH] handle `Exception` during `EraFile.verify` (#5900)

`Taskpool.new()` is marked as `{.raises: [Exception].}`. Catch this.
---
 .github/workflows/ci.yml |  1 +
 beacon_chain/era_db.nim  | 17 +++++++++++------
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 360af79ab..bb6576a5e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -221,6 +221,7 @@ jobs:
       - name: Build files with isMainModule
         run: |
           source env.sh
+          nim c beacon_chain/era_db
           nim c beacon_chain/trusted_node_sync
 
   lint:
diff --git a/beacon_chain/era_db.nim b/beacon_chain/era_db.nim
index 2eb983115..3f3c71877 100644
--- a/beacon_chain/era_db.nim
+++ b/beacon_chain/era_db.nim
@@ -1,9 +1,12 @@
+# beacon_chain
 # Copyright (c) 2018-2024 Status Research & Development GmbH
 # Licensed and distributed under either of
 #   * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
 #   * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
 # at your option. This file may not be copied, modified, or distributed except according to those terms.
 
+{.push raises: [].}
+
 import
   std/os,
   chronicles,
@@ -186,15 +189,19 @@ proc verify*(f: EraFile, cfg: RuntimeConfig): Result[Eth2Digest, string] =
   # We'll load the full state and compute its root - then we'll load the blocks
   # and make sure that they match the state and that their signatures check out
   let
-    startSlot = f.stateIdx.startSlot
-    era = startSlot.era
+    slot = f.stateIdx.startSlot
+    era = slot.era
 
     rng = HmacDrbgContext.new()
-    taskpool = Taskpool.new()
+    taskpool =
+      try:
+        Taskpool.new()
+      except Exception as exc:
+        return err("Failed to initialize Taskpool: " & exc.msg)
   var verifier = BatchVerifier.init(rng, taskpool)
 
   var tmp: seq[byte]
-  ? f.getStateSSZ(startSlot, tmp)
+  ? f.getStateSSZ(slot, tmp)
 
   let
     state =
@@ -464,8 +471,6 @@ when isMainModule:
   # Testing EraDB gets messy because of the large amounts of data involved:
   # this snippet contains some sanity checks for mainnet at least
 
-  import stew/arrayops
-
   let
     dbPath =
       if os.paramCount() == 1: os.paramStr(1)