status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Don't store invalid gossipsub messages (#3471)

This commit is contained in:
Tanguy 2022-03-09 11:30:31 +01:00 committed by GitHub
parent 41c820bc66
commit 266fd98a13
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
beacon_chain/networking/eth2_network.nim
View File

@ -1820,15 +1820,14 @@ proc getPersistentNetKeys*(rng: var BrHmacDrbgContext,
NetKeyPair(seckey: privKey, pubkey: pubKey)
func gossipId(
data: openArray[byte], altairPrefix, topic: string, valid: bool): seq[byte] =
data: openArray[byte], altairPrefix, topic: string): seq[byte] =
# https://github.com/ethereum/consensus-specs/blob/v1.1.9/specs/phase0/p2p-interface.md#topics-and-messages
# https://github.com/ethereum/consensus-specs/blob/v1.1.10/specs/altair/p2p-interface.md#topics-and-messages
const
MESSAGE_DOMAIN_INVALID_SNAPPY = [0x00'u8, 0x00, 0x00, 0x00]
MESSAGE_DOMAIN_VALID_SNAPPY = [0x01'u8, 0x00, 0x00, 0x00]
let messageDigest = withEth2Hash:
h.update(
if valid: MESSAGE_DOMAIN_VALID_SNAPPY else: MESSAGE_DOMAIN_INVALID_SNAPPY)
h.update(MESSAGE_DOMAIN_VALID_SNAPPY)
if topic.startsWith(altairPrefix):
h.update topic.len.uint64.toBytesLE
@ -1918,9 +1917,9 @@ proc createEth2Node*(rng: ref BrHmacDrbgContext,
# This doesn't have to be a tight bound, just enough to avoid denial of
# service attacks.
let decoded = snappy.decode(m.data, maxGossipMaxSize())
ok(gossipId(decoded, altairPrefix, topic, true))
ok(gossipId(decoded, altairPrefix, topic))
except CatchableError:
ok(gossipId(m.data, altairPrefix, topic, false))
err(ValidationResult.Reject)
let
params = GossipSubParams(