status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-02-08 12:44:34 +00:00
Code Issues Projects Releases Wiki Activity

remove incorrect block gossip validation condition (#4044)

Browse Source 
* remove incorrect block gossip validation condition

* clarify explanation
This commit is contained in:
tersec 2022-08-29 10:01:32 +00:00 committed by GitHub
parent d7e9c334ac
commit 2545d1d053
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
beacon_chain/gossip_processing/gossip_validation.nim
View File

@ -210,12 +210,12 @@ template validateBeaconBlockBellatrix(
quarantine[].addUnviable(signed_beacon_block.root) quarantine[].addUnviable(signed_beacon_block.root)
return errReject("BeaconBlock: mismatched execution payload timestamp") return errReject("BeaconBlock: mismatched execution payload timestamp")
if signed_beacon_block.message.parent_root in dag.optimisticRoots: # The condition:
# Definitely don't mark this as unviable. # [REJECT] The block's parent (defined by `block.parent_root`) passes all
# [REJECT] The block's parent (defined by `block.parent_root`) passes all # validation (excluding execution node verification of the
# validation (excluding execution node verification of the # `block.body.execution_payload`).
# `block.body.execution_payload`). # cannot occur here, because Nimbus's optimistic sync waits for either
return errReject("BeaconBlock: execution payload would build on optimistic parent") # `ACCEPTED` or `SYNCING` from the EL to get this far.
# https://github.com/ethereum/consensus-specs/blob/v1.1.9/specs/phase0/p2p-interface.md#beacon_block # https://github.com/ethereum/consensus-specs/blob/v1.1.9/specs/phase0/p2p-interface.md#beacon_block
# https://github.com/ethereum/consensus-specs/blob/v1.2.0-rc.3/specs/bellatrix/p2p-interface.md#beacon_block # https://github.com/ethereum/consensus-specs/blob/v1.2.0-rc.3/specs/bellatrix/p2p-interface.md#beacon_block