status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

remove redundant attestation check (#1433) 

only viable blocks (descendants of the finalized checkpoint) are in the
dag already
This commit is contained in:
Jacek Sieka 2020-08-04 17:52:46 +02:00 committed by GitHub
parent b70462acf8
commit 196bc6ea3b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
beacon_chain/attestation_aggregation.nim
View File

@ -177,27 +177,14 @@ proc isValidAttestation*(
pool.quarantine.addMissing(attestation.data.beacon_block_root) pool.quarantine.addMissing(attestation.data.beacon_block_root)
return false return false
# The following rule follows implicitly from that we clear out any
# unviable blocks from the chain dag:
#
# The current finalized_checkpoint is an ancestor of the block defined by # The current finalized_checkpoint is an ancestor of the block defined by
# attestation.data.beacon_block_root -- i.e. get_ancestor(store, # attestation.data.beacon_block_root -- i.e. get_ancestor(store,
# attestation.data.beacon_block_root, # attestation.data.beacon_block_root,
# compute_start_slot_at_epoch(store.finalized_checkpoint.epoch)) == # compute_start_slot_at_epoch(store.finalized_checkpoint.epoch)) ==
# store.finalized_checkpoint.root # store.finalized_checkpoint.root
let
ancestor = get_ancestor(
attestationBlck,
compute_start_slot_at_epoch(
pool.chainDag.headState.data.data.finalized_checkpoint.epoch))
finalized_root =
pool.chainDag.headState.data.data.finalized_checkpoint.root
if ancestor.isNil:
debug "Can't find ancestor block"
return false
# TODO spec doesn't note the pre-finalization case, but maybe necessary
if not (finalized_root in [Eth2Digest(), ancestor.root]):
debug "Incorrect ancestor block",
ancestor_root = ancestor.root,
finalized_root = pool.chainDag.headState.data.data.finalized_checkpoint.root
return false
pool.chainDag.withState( pool.chainDag.withState(
pool.chainDag.tmpState, pool.chainDag.tmpState,