status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix aggregated attestation slot signature processing. 

Modify some comments.
This commit is contained in:
cheatfate 2023-05-16 23:32:45 +03:00
parent cf6610c01b
commit 0f9d3e4f39
No known key found for this signature in database
GPG Key ID: 46ADD633A7201F95
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
beacon_chain/validator_client/duties_service.nim
View File

@ -168,9 +168,9 @@ proc fillAttestationSlotSignatures*(
sorted(res, cmp, order = SortOrder.Ascending) sorted(res, cmp, order = SortOrder.Ascending)
# We creating signatures in chunks to make VC more responsive for big number # We creating signatures in chunks to make VC more responsive for big number
# of validators. In this case tasks which are running concurrently could # of validators. In this case tasks that run concurrently will be able to use
# get their slot signatures for first epoch's slots even before this # signatures for slots at the beginning of the epoch even before this
# processing ends. # processing will be completed.
for chunk in requests.chunks(ATTESTATION_SIGNING_CHUNK_SIZE): for chunk in requests.chunks(ATTESTATION_SIGNING_CHUNK_SIZE):
let pendingRequests = chunk.mapIt( let pendingRequests = chunk.mapIt(
getSlotSignature(it.validator, it.fork, genesisRoot, it.slot)) getSlotSignature(it.validator, it.fork, genesisRoot, it.slot))
@ -186,7 +186,7 @@ proc fillAttestationSlotSignatures*(
for index, fut in pendingRequests.pairs(): for index, fut in pendingRequests.pairs():
let let
request = requests[index] request = chunk[index]
signature = signature =
if fut.done(): if fut.done():
let sres = fut.read() let sres = fut.read()
@ -429,9 +429,9 @@ proc fillSyncSlotSignatures*(
res res
# We creating signatures in chunks to make VC more responsive for big number # We creating signatures in chunks to make VC more responsive for big number
# of validators. In this case tasks which are running concurrently could # of validators. In this case tasks that run concurrently will be able to use
# get their slot signatures for first epoch's slots even before this # signatures for slots at the beginning of the epoch even before this
# processing ends. # processing will be completed.
for chunk in requests.chunks(SYNC_SIGNING_CHUNK_SIZE): for chunk in requests.chunks(SYNC_SIGNING_CHUNK_SIZE):
let pendingRequests = chunk.mapIt( let pendingRequests = chunk.mapIt(
getSyncCommitteeSelectionProof( getSyncCommitteeSelectionProof(