From 09663e00d87c0d3f43519c6073d27d2653f69b53 Mon Sep 17 00:00:00 2001 From: tersec Date: Wed, 1 Jun 2022 00:57:42 +0000 Subject: [PATCH] don't hide Nim 1.6 build failures (#3685) --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 747f029d9..96eb8c858 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -212,8 +212,8 @@ jobs: - name: Smoke test the Beacon Node and Validator Client with all tracing enabled run: | if [[ "${{ matrix.branch }}" == "version-1-6" ]]; then - # hide the CI failure in GitHub's UI - ${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} LOG_LEVEL=TRACE nimbus_beacon_node nimbus_validator_client || true + # change to "|| true" to hide the CI failures in GitHub's UI (escape hatch if a blocker is detected in 1.6) + ${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} LOG_LEVEL=TRACE nimbus_beacon_node nimbus_validator_client || false else ${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} LOG_LEVEL=TRACE nimbus_beacon_node nimbus_validator_client fi @@ -221,8 +221,8 @@ jobs: - name: Build all tools run: | if [[ "${{ matrix.branch }}" == "version-1-6" ]]; then - # hide the CI failure in GitHub's UI - ${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} || true + # change to "|| true" to hide the CI failures in GitHub's UI (escape hatch if a blocker is detected in 1.6) + ${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} || false else ${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} fi