status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-01-10 22:36:01 +00:00
Code Issues Projects Releases Wiki Activity

sendErrorResponse(): don't crash when unable to send to peer

Browse Source
This commit is contained in:
Ștefan Talpalaru 2020-01-13 17:12:49 +01:00
parent 13b9f61f6f
commit 003a4c90be
No known key found for this signature in database
GPG Key ID: CBF7934204F1B6F9
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
beacon_chain/libp2p_backends_common.nim
View File

@ -184,9 +184,12 @@ proc sendErrorResponse(peer: Peer,
debug "Received an invalid request",
peer, msgName, msgBytes, errMsg = err.formatMsg("<msg>")
let responseBytes = encodeErrorMsg(InvalidRequest, err.formatMsg("msg"))
await stream.writeAllBytes(responseBytes)
await stream.close()
try:
let responseBytes = encodeErrorMsg(InvalidRequest, err.formatMsg("msg"))
await stream.writeAllBytes(responseBytes)
await stream.close()
except CatchableError as err:
debug "Error during sendErrorResponse()", error = err.msg
proc sendErrorResponse(peer: Peer,
stream: P2PStream,
@ -194,9 +197,12 @@ proc sendErrorResponse(peer: Peer,
errMsg: string) {.async.} =
debug "Error processing request", peer, responseCode, errMsg
let responseBytes = encodeErrorMsg(ServerError, errMsg)
await stream.writeAllBytes(responseBytes)
await stream.close()
try:
let responseBytes = encodeErrorMsg(ServerError, errMsg)
await stream.writeAllBytes(responseBytes)
await stream.close()
except CatchableError as err:
debug "Error during sendErrorResponse()", error = err.msg
proc sendNotificationMsg(peer: Peer, protocolId: string, requestBytes: Bytes) {.async} =
var deadline = sleepAsync RESP_TIMEOUT