status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
nimbus-eth2/beacon_chain/consensus_object_pools/spec_cache.nim

319 lines
14 KiB
Nim
Raw Permalink Normal View History

removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
# beacon_chain
verify `genesis_time` more strictly (fixes #1667) (#5694) Bogus values lead to crashes down the line when timers overflow
2024-01-06 14:26:56 +00:00
# Copyright (c) 2018-2024 Status Research & Development GmbH
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
# Licensed and distributed under either of
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
# at your option. This file may not be copied, modified, or distributed except according to those terms.
remove Nim 1.2-compatible `push raise`s and update copyright notice years (#4528)
2023-01-20 14:14:37 +00:00
{.push raises: [].}
fix broken metrics during replay (#2090) * move metrics out of state transition * add validator count metric * remove expensive beacon_current_validators, beacon_previous_validators metrics (they should be reimplemented with cache), add cheap beacon_active_validators to approximate * remove unused validator count metrics * tidy imports/defects
2020-11-27 22:16:13 +00:00
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
import
refactor executionPayload tests; reduce HashSet creation (#3003)
2021-10-20 11:36:38 +00:00
std/sequtils,
update some deprecated stew/results to results imports (#5743)
2024-01-16 22:37:14 +00:00
results,
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
chronicles,
remove one cache, add another (#1449) * remove one cache, add another This cache removes the need for rewinding in most attestation validation flow since the attestations come from one of two epochs and must be targetting a viable block. Additionally, it also removes all state caches which are less likely to be used over-all - more metrics are needed to track the rewinding. On risk is that when chains don't finalize, we'll have lots of epochrefs in memory meaning lots of validator key databases, most being exactly the same. This can be addressed in any number of ways. Some of the memory usage is mitigated by the fact that we previously had lots of big state caches and now we're keeping only keys instead. * cleanups * doc
2020-08-06 19:48:47 +00:00
../extras,
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
../spec/[beaconstate, helpers, network, signatures, validator],
rework spec imports (#2779) The spec imports are a mess to work with, so this branch cleans them up a bit to ensure that we avoid generic sandwitches and that importing stuff generally becomes easier. * reexport crypto/digest/presets because these are part of the public symbol set of the rest of the spec types * don't export `merge` types from `base` - this causes circular deps * fix circular deps in `ssz/spec_types` - this is the first step in disentangling ssz from spec * be explicit about phase0 vs altair - longer term, `altair` will become the "natural" type set, then merge and so on, so no point in giving `phase0` special preferential treatment
2021-08-12 13:08:20 +00:00
../spec/datatypes/base,
./block_pools_types, blockchain_dag
rm debugRaiseAssert; clean up several debugComments (#6308) * rm debugRaiseAssert; clean up several debugComments * exception linting
2024-05-23 21:51:09 +00:00
from ../spec/datatypes/electra import shortLog
add Electra SSZ object test fixture (#6225)
2024-04-22 09:00:38 +00:00
rework spec imports (#2779) The spec imports are a mess to work with, so this branch cleans them up a bit to ensure that we avoid generic sandwitches and that importing stuff generally becomes easier. * reexport crypto/digest/presets because these are part of the public symbol set of the rest of the spec types * don't export `merge` types from `base` - this causes circular deps * fix circular deps in `ssz/spec_types` - this is the first step in disentangling ssz from spec * be explicit about phase0 vs altair - longer term, `altair` will become the "natural" type set, then merge and so on, so no point in giving `phase0` special preferential treatment
2021-08-12 13:08:20 +00:00
export
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
base, extras, block_pools_types, results
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
logScope: topics = "spec_cache"
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
# Spec functions implemented based on cached values instead of the full state
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
func count_active_validators*(shufflingRef: ShufflingRef): uint64 =
shufflingRef.shuffled_active_validator_indices.lenu64
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
some consensus spec v1.4.0 spec URL updates (#6208)
2024-04-17 03:51:16 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.4.0/specs/phase0/beacon-chain.md#get_committee_count_per_slot
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
func get_committee_count_per_slot*(shufflingRef: ShufflingRef): uint64 =
get_committee_count_per_slot(count_active_validators(shufflingRef))
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
iterator get_committee_indices*(shufflingRef: ShufflingRef): CommitteeIndex =
let committees_per_slot = get_committee_count_per_slot(shufflingRef)
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
for committee_index in get_committee_indices(committees_per_slot):
yield committee_index
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
func get_committee_index*(shufflingRef: ShufflingRef, index: uint64):
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
Result[CommitteeIndex, cstring] =
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
check_attestation_index(index, get_committee_count_per_slot(shufflingRef))
Perform attestation check before broadcast (#2550) Currently, we have a bit of a convoluted flow where when sending attestations, we start broadcasting them over gossip then pass them to the attestation validation to include them in the local attestation pool - it should be the other way around: we should be checking attestations _before_ gossipping them - this serves as an additional safety net to ensure that we don't publish junk - this becomes more important when publishing attestations from the API. Also, the REST API was performing its own validation meaning attestations coming from REST would be validated twice - finally, the JSON RPC wasn't pre-validating and would happily broadcast invalid attestations. * Unified attestation production pipeline with the same flow for gossip, locally and API-produced attestations: all are now validated and entered into the pool, then broadcast/republished * Refactor subnet handling with specific SubnetId alias, streamlining where subnets are computed, avoiding the need to pass around the number of active validators * Move some of the subnet handling code to eth2_network * Use BitArray throughout for subnet handling
2021-05-10 07:13:36 +00:00
automated consensus spec URL updating to v1.4.0-beta.6 (#5804)
2024-01-20 11:19:47 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.4.0-beta.6/specs/phase0/beacon-chain.md#get_beacon_committee
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
iterator get_beacon_committee*(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef: ShufflingRef, slot: Slot, committee_index: CommitteeIndex):
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
(int, ValidatorIndex) =
update 18 spec URLs to v1.1.2; switch from eth2.0-specs to consensus-specs (#2990)
2021-10-14 06:30:21 +00:00
## Return the beacon committee at ``slot`` for ``index``.
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
doAssert slot.epoch == shufflingRef.epoch
let committees_per_slot = get_committee_count_per_slot(shufflingRef)
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
for index_in_committee, idx in compute_committee(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef.shuffled_active_validator_indices,
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
(slot mod SLOTS_PER_EPOCH) * committees_per_slot + committee_index.asUInt64,
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
committees_per_slot * SLOTS_PER_EPOCH
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
): yield (index_in_committee, idx)
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
automated consensus spec URL updating to v1.5.0-alpha.8 (#6617)
2024-10-09 06:37:35 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.8/specs/phase0/beacon-chain.md#get_beacon_committee
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
func get_beacon_committee*(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef: ShufflingRef, slot: Slot, committee_index: CommitteeIndex):
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
seq[ValidatorIndex] =
update 18 spec URLs to v1.1.2; switch from eth2.0-specs to consensus-specs (#2990)
2021-10-14 06:30:21 +00:00
## Return the beacon committee at ``slot`` for ``index``.
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
doAssert slot.epoch == shufflingRef.epoch
let committees_per_slot = get_committee_count_per_slot(shufflingRef)
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
compute_committee(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef.shuffled_active_validator_indices,
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
(slot mod SLOTS_PER_EPOCH) * committees_per_slot + committee_index.asUInt64,
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
committees_per_slot * SLOTS_PER_EPOCH
)
automated consensus spec URL updating to v1.4.0-beta.6 (#5804)
2024-01-20 11:19:47 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.4.0-beta.6/specs/phase0/beacon-chain.md#get_beacon_committee
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
func get_beacon_committee_len*(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef: ShufflingRef, slot: Slot, committee_index: CommitteeIndex): uint64 =
update 18 spec URLs to v1.1.2; switch from eth2.0-specs to consensus-specs (#2990)
2021-10-14 06:30:21 +00:00
## Return the number of members in the beacon committee at ``slot`` for ``index``.
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
doAssert slot.epoch == shufflingRef.epoch
let committees_per_slot = get_committee_count_per_slot(shufflingRef)
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
compute_committee_len(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
count_active_validators(shufflingRef),
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
(slot mod SLOTS_PER_EPOCH) * committees_per_slot + committee_index.asUInt64,
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
committees_per_slot * SLOTS_PER_EPOCH
)
automated consensus spec URL updating to v1.4.0-beta.6 (#5804)
2024-01-20 11:19:47 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.4.0-beta.6/specs/phase0/beacon-chain.md#get_attesting_indices
reorder gossip validation checks (#5610) * reorder gossip validation checks Doing the coverage check only after the corresponding committee index is known allows optimization by early rejecting invalid data. * use same helper for individual attestations as well
2023-11-20 14:42:29 +00:00
func compatible_with_shuffling*(
add Electra SSZ object test fixture (#6225)
2024-04-22 09:00:38 +00:00
bits: CommitteeValidatorsBits | ElectraCommitteeValidatorsBits,
reorder gossip validation checks (#5610) * reorder gossip validation checks Doing the coverage check only after the corresponding committee index is known allows optimization by early rejecting invalid data. * use same helper for individual attestations as well
2023-11-20 14:42:29 +00:00
shufflingRef: ShufflingRef,
slot: Slot,
committee_index: CommitteeIndex): bool =
bits.lenu64 == get_beacon_committee_len(shufflingRef, slot, committee_index)
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
iterator get_attesting_indices*(shufflingRef: ShufflingRef,
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
slot: Slot,
committee_index: CommitteeIndex,
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
bits: CommitteeValidatorsBits | ElectraCommitteeValidatorsBits):
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
ValidatorIndex =
reorder gossip validation checks (#5610) * reorder gossip validation checks Doing the coverage check only after the corresponding committee index is known allows optimization by early rejecting invalid data. * use same helper for individual attestations as well
2023-11-20 14:42:29 +00:00
if not bits.compatible_with_shuffling(shufflingRef, slot, committee_index):
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
trace "get_attesting_indices: inconsistent aggregation and committee length"
else:
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
for index_in_committee, validator_index in get_beacon_committee(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef, slot, committee_index):
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
if bits[index_in_committee]:
yield validator_index
misc memory and perf fixes (#1899) * misc memory and perf fixes * use EpochRef for attestation aggregation * compress effective balances in memory (medalla unfinalized: 4gb -> 1gb) * avoid hitting db when rewinding to head or clearance state * avoid hitting db when blocks can be applied to in-memory state - speeds up startup considerably * avoid storing epochref in fork choice * simplify and speed up beacon block creation flow - avoids state reload thanks to head rewind optimization * iterator-based committee and attestation participation help avoid lots of small memory allocations throughout epoch transition (40% speedup on epoch processing, for example during startup) * add constant for threshold
2020-10-22 10:53:33 +00:00
add EF consensus spec test Electra attestation operations fixture (#6248)
2024-04-28 00:52:14 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.0/specs/electra/beacon-chain.md#modified-get_attesting_indices
iterator get_attesting_indices*(shufflingRef: ShufflingRef,
slot: Slot,
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
committee_bits: AttestationCommitteeBits,
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
aggregation_bits: ElectraCommitteeValidatorsBits, on_chain: static bool):
add EF consensus spec test Electra attestation operations fixture (#6248)
2024-04-28 00:52:14 +00:00
ValidatorIndex =
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
when on_chain:
var pos = 0
for committee_index in get_committee_indices(committee_bits):
for _, validator_index in get_beacon_committee(
shufflingRef, slot, committee_index):
if aggregation_bits[pos]:
yield validator_index
pos += 1
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
else:
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
let committee_index = get_committee_index_one(committee_bits)
for validator_index in get_attesting_indices(
shufflingRef, slot, committee_index, aggregation_bits, on_chain):
yield validator_index
add EF consensus spec test Electra attestation operations fixture (#6248)
2024-04-28 00:52:14 +00:00
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
iterator get_attesting_indices*(
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
dag: ChainDAGRef, attestation: phase0.TrustedAttestation,
on_chain: static bool = true): ValidatorIndex =
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
block gaiBlock: # `return` is not allowed in an inline iterator
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
let
slot =
check_attestation_slot_target(attestation.data).valueOr:
add some log data for fishy trusted attestations (#4049)
2022-08-30 02:59:42 +00:00
warn "Invalid attestation slot in trusted attestation",
log attestation/block when slashing protection is activated (#4148)
2022-09-19 19:50:19 +00:00
attestation = shortLog(attestation)
rename verifyFinalization internal flag to strictVerification (#3866) * rename verifyFinalization internal flag to strictVerification * Update beacon_chain/extras.nim Co-authored-by: Etan Kissling <etan@status.im> Co-authored-by: Etan Kissling <etan@status.im>
2022-07-13 13:48:09 +00:00
doAssert strictVerification notin dag.updateFlags
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
blck =
dag.getBlockRef(attestation.data.beacon_block_root).valueOr:
add some log data for fishy trusted attestations (#4049)
2022-08-30 02:59:42 +00:00
# Attestation block unknown - this is fairly common because we
# discard alternative histories on restart
Harden EpochRef loading against bogus block root at tail (#4178) * add more error information when things go wrong with database * lower log level when reloading attestations from no-block epoch start slot
2022-09-27 16:56:08 +00:00
debug "Pruned block in trusted attestation",
attestation = shortLog(attestation)
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
target =
blck.atCheckpoint(attestation.data.target).valueOr:
Harden EpochRef loading against bogus block root at tail (#4178) * add more error information when things go wrong with database * lower log level when reloading attestations from no-block epoch start slot
2022-09-27 16:56:08 +00:00
# This may happen when there's no block at the epoch boundary slot
# leading to the case where the attestation block root is the
# finalized head (exists as BlockRef) but its target vote has
# already been pruned
notice "Pruned target in trusted attestation",
add some log data for fishy trusted attestations (#4049)
2022-08-30 02:59:42 +00:00
blck = shortLog(blck),
log attestation/block when slashing protection is activated (#4148)
2022-09-19 19:50:19 +00:00
attestation = shortLog(attestation)
rename verifyFinalization internal flag to strictVerification (#3866) * rename verifyFinalization internal flag to strictVerification * Update beacon_chain/extras.nim Co-authored-by: Etan Kissling <etan@status.im> Co-authored-by: Etan Kissling <etan@status.im>
2022-07-13 13:48:09 +00:00
doAssert strictVerification notin dag.updateFlags
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef =
dag.getShufflingRef(target.blck, target.slot.epoch, false).valueOr:
add some log data for fishy trusted attestations (#4049)
2022-08-30 02:59:42 +00:00
warn "Attestation shuffling not found",
blck = shortLog(blck),
log attestation/block when slashing protection is activated (#4148)
2022-09-19 19:50:19 +00:00
attestation = shortLog(attestation)
add some log data for fishy trusted attestations (#4049)
2022-08-30 02:59:42 +00:00
rename verifyFinalization internal flag to strictVerification (#3866) * rename verifyFinalization internal flag to strictVerification * Update beacon_chain/extras.nim Co-authored-by: Etan Kissling <etan@status.im> Co-authored-by: Etan Kissling <etan@status.im>
2022-07-13 13:48:09 +00:00
doAssert strictVerification notin dag.updateFlags
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
committeesPerSlot = get_committee_count_per_slot(shufflingRef)
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
committeeIndex =
CommitteeIndex.init(attestation.data.index, committeesPerSlot).valueOr:
add some log data for fishy trusted attestations (#4049)
2022-08-30 02:59:42 +00:00
warn "Unexpected committee index in trusted attestation",
blck = shortLog(blck),
log attestation/block when slashing protection is activated (#4148)
2022-09-19 19:50:19 +00:00
attestation = shortLog(attestation)
add some log data for fishy trusted attestations (#4049)
2022-08-30 02:59:42 +00:00
rename verifyFinalization internal flag to strictVerification (#3866) * rename verifyFinalization internal flag to strictVerification * Update beacon_chain/extras.nim Co-authored-by: Etan Kissling <etan@status.im> Co-authored-by: Etan Kissling <etan@status.im>
2022-07-13 13:48:09 +00:00
doAssert strictVerification notin dag.updateFlags
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
for validator in get_attesting_indices(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef, slot, committeeIndex, attestation.aggregation_bits):
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
yield validator
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
iterator get_attesting_indices*(
implement SingleAttestation (#6783) * implement SingleAttestation * improve SingleAttestation shortLog * avoid double ShuffleRef lookups in majority/happy case * restore full electra check_aggregation_count, separately from phase0 one
2024-12-23 16:32:29 +00:00
dag: ChainDAGRef,
attestation: electra.Attestation | electra.TrustedAttestation,
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
on_chain: static bool): ValidatorIndex =
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
block gaiBlock: # `return` is not allowed in an inline iterator
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
let
slot =
check_attestation_slot_target(attestation.data).valueOr:
implement SingleAttestation (#6783) * implement SingleAttestation * improve SingleAttestation shortLog * avoid double ShuffleRef lookups in majority/happy case * restore full electra check_aggregation_count, separately from phase0 one
2024-12-23 16:32:29 +00:00
warn "Invalid attestation slot in attestation",
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
attestation = shortLog(attestation)
doAssert strictVerification notin dag.updateFlags
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
blck =
dag.getBlockRef(attestation.data.beacon_block_root).valueOr:
# Attestation block unknown - this is fairly common because we
# discard alternative histories on restart
implement SingleAttestation (#6783) * implement SingleAttestation * improve SingleAttestation shortLog * avoid double ShuffleRef lookups in majority/happy case * restore full electra check_aggregation_count, separately from phase0 one
2024-12-23 16:32:29 +00:00
debug "Pruned block in attestation",
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
attestation = shortLog(attestation)
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
target =
blck.atCheckpoint(attestation.data.target).valueOr:
# This may happen when there's no block at the epoch boundary slot
# leading to the case where the attestation block root is the
# finalized head (exists as BlockRef) but its target vote has
# already been pruned
implement SingleAttestation (#6783) * implement SingleAttestation * improve SingleAttestation shortLog * avoid double ShuffleRef lookups in majority/happy case * restore full electra check_aggregation_count, separately from phase0 one
2024-12-23 16:32:29 +00:00
notice "Pruned target in attestation",
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
blck = shortLog(blck),
attestation = shortLog(attestation)
doAssert strictVerification notin dag.updateFlags
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
shufflingRef =
dag.getShufflingRef(target.blck, target.slot.epoch, false).valueOr:
warn "Attestation shuffling not found",
blck = shortLog(blck),
attestation = shortLog(attestation)
doAssert strictVerification notin dag.updateFlags
fix UnnamedBreak deprecation build warnings (#6388)
2024-06-26 08:48:49 +00:00
break gaiBlock
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
for validator in get_attesting_indices(
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
shufflingRef, slot, attestation.committee_bits,
attestation.aggregation_bits, on_chain):
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
yield validator
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
func get_attesting_indices_one*(shufflingRef: ShufflingRef,
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
slot: Slot,
committee_index: CommitteeIndex,
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
bits: CommitteeValidatorsBits | ElectraCommitteeValidatorsBits):
remove attestation/aggregate queue (#2519) With the introduction of batching and lazy attestation aggregation, it no longer makes sense to enqueue attestations between the signature check and adding them to the attestation pool - this only takes up valuable CPU without any real benefit. * add successfully validated attestations to attestion pool directly * avoid copying participant list around for single-vote attestations, pass single validator index instead * release decompressed gossip memory earlier, specially during async message validation * use cooked signatures in a few more places to avoid reloads and errors * remove some Defect-raising versions of signature-loading * release decompressed data memory before validating message
2021-04-26 20:39:44 +00:00
Option[ValidatorIndex] =
# A variation on get_attesting_indices that returns the validator index only
# if only one validator index is set
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
var res = none(ValidatorIndex)
for validator_index in get_attesting_indices(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef, slot, committee_index, bits):
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
if res.isSome(): return none(ValidatorIndex)
res = some(validator_index)
res
remove attestation/aggregate queue (#2519) With the introduction of batching and lazy attestation aggregation, it no longer makes sense to enqueue attestations between the signature check and adding them to the attestation pool - this only takes up valuable CPU without any real benefit. * add successfully validated attestations to attestion pool directly * avoid copying participant list around for single-vote attestations, pass single validator index instead * release decompressed gossip memory earlier, specially during async message validation * use cooked signatures in a few more places to avoid reloads and errors * remove some Defect-raising versions of signature-loading * release decompressed data memory before validating message
2021-04-26 20:39:44 +00:00
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
func get_attesting_indices_one*(shufflingRef: ShufflingRef,
slot: Slot,
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
committee_bits: AttestationCommitteeBits,
aggregation_bits: ElectraCommitteeValidatorsBits,
on_chain: static bool):
Opt[ValidatorIndex] =
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
# A variation on get_attesting_indices that returns the validator index only
# if only one validator index is set
attestation and aggregated attestation BN fixes for Electra (#6641) * attestation and aggregated attestation BN fixes for Electra * disable electra transition for this PR * use cleaned-up verification function everywhere
2024-10-14 14:20:26 +00:00
static: doAssert not on_chain, "only not on_chain supported"
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
var res = Opt.none(ValidatorIndex)
let committee_index = ? get_committee_index_one(committee_bits)
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
for validator_index in get_attesting_indices(
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
shufflingRef, slot, committee_index, aggregation_bits):
if res.isSome(): return Opt.none(ValidatorIndex)
res = Opt.some(validator_index)
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
res
automated consensus spec URL updating to v1.4.0-beta.6 (#5804)
2024-01-20 11:19:47 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.4.0-beta.6/specs/phase0/beacon-chain.md#get_attesting_indices
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
func get_attesting_indices*(shufflingRef: ShufflingRef,
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
slot: Slot,
committee_index: CommitteeIndex,
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
bits: CommitteeValidatorsBits):
remove several IntSet usages in lieu of seq[ValidatorIndex] (#2288) * remove several IntSet usages in lieu of seq[ValidatorIndex] * convert smaller types to larger types * larger type, again
2021-02-08 07:27:30 +00:00
seq[ValidatorIndex] =
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
for idx in get_attesting_indices(shufflingRef, slot, committee_index, bits):
result.add(idx)
func get_attesting_indices*(shufflingRef: ShufflingRef,
slot: Slot,
committee_index: CommitteeIndex,
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
bits: ElectraCommitteeValidatorsBits,
restore electra aggregate gossip validation to parity (#6787)
2024-12-23 16:10:23 +00:00
on_chain: static bool = true):
electra attestation gossip plumbing (#6287)
2024-05-14 16:01:26 +00:00
seq[ValidatorIndex] =
restore electra aggregate gossip validation to parity (#6787)
2024-12-23 16:10:23 +00:00
static: doAssert on_chain, "only on_chain supported"
electra attestation updates (#6295) * electra attestation updates In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list. This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient. * more attestations in the blocks * signing and aggregation fixes * tool fix * test, import
2024-05-17 12:37:41 +00:00
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
for idx in get_attesting_indices(shufflingRef, slot, committee_index, bits):
remove several IntSet usages in lieu of seq[ValidatorIndex] (#2288) * remove several IntSet usages in lieu of seq[ValidatorIndex] * convert smaller types to larger types * larger type, again
2021-02-08 07:27:30 +00:00
result.add(idx)
removed the BlockPool type and all of the proxy functions around it (#1401) * removed the BlockPool type and all of the proxy functions around it - passing the chain DAG and the quarantine explicitly where appropriately - they don't need to be bundled in a type * fixed the build after the rebase
2020-07-30 19:18:17 +00:00
use epochcache for attesting (#1478)
2020-08-10 13:21:31 +00:00
func makeAttestationData*(
epochRef: EpochRef, bs: BlockSlot,
Datatype cleanup (#1953) * clear up spec todo * test fix * remove unnecessary toSszType * type * one more
2020-11-04 21:52:47 +00:00
committee_index: CommitteeIndex): AttestationData =
use epochcache for attesting (#1478)
2020-08-10 13:21:31 +00:00
## Create an attestation / vote for the block `bs` using the
## data in `epochRef` to fill in the rest of the fields.
## `epochRef` is the epoch information corresponding to the `bs` advanced to
## the slot we're attesting to.
let
slot = bs.slot
time: spring cleaning (#3262) Time in the beacon chain is expressed relative to the genesis time - this PR creates a `beacon_time` module that collects helpers and utilities for dealing the time units - the new module does not deal with actual wall time (that's remains in `beacon_clock`). Collecting the time related stuff in one place makes it easier to find, avoids some circular imports and allows more easily identifying the code actually needs wall time to operate. * move genesis-time-related functionality into `spec/beacon_time` * avoid using `chronos.Duration` for time differences - it does not support negative values (such as when something happens earlier than it should) * saturate conversions between `FAR_FUTURE_XXX`, so as to avoid overflows * fix delay reporting in validator client so it uses the expected deadline of the slot, not "closest wall slot" * simplify looping over the slots of an epoch * `compute_start_slot_at_epoch` -> `start_slot` * `compute_epoch_at_slot` -> `epoch` A follow-up PR will (likely) introduce saturating arithmetic for the time units - this is merely code moves, renames and fixing of small bugs.
2022-01-11 10:01:54 +00:00
current_epoch = slot.epoch()
epoch_boundary_slot = current_epoch.start_slot()
use epochcache for attesting (#1478)
2020-08-10 13:21:31 +00:00
epoch_boundary_block = bs.blck.atSlot(epoch_boundary_slot)
doAssert current_epoch == epochRef.epoch
automated consensus spec URL updating to v1.5.0-alpha.10 (#6762)
2024-12-15 16:36:50 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.10/specs/phase0/validator.md#attestation-data
use epochcache for attesting (#1478)
2020-08-10 13:21:31 +00:00
AttestationData(
slot: slot,
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
index: committee_index.asUInt64,
use epochcache for attesting (#1478)
2020-08-10 13:21:31 +00:00
beacon_block_root: bs.blck.root,
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
source: epochRef.checkpoints.justified,
use epochcache for attesting (#1478)
2020-08-10 13:21:31 +00:00
target: Checkpoint(
epoch: current_epoch,
group justified and finalized `Checkpoint` (#3841) The justified and finalized `Checkpoint` are frequently passed around together. This introduces a new `FinalityCheckpoint` data structure that combines them into one. Due to the large usage of this structure in fork choice, also took this opportunity to update fork choice tests to the latest v1.2.0-rc.1 spec. Many additional tests enabled, some need more work, e.g. EL mock blocks. Also implemented `discard_equivocations` which was skipped in #3661, and improved code reuse across fork choice logic while at it.
2022-07-06 10:33:02 +00:00
root: epoch_boundary_block.blck.root))
use epochref for get_committee_assignments() to avoid repeated shuffling (#2463) * use epochref for get_committee_assignments() to avoid repeated shuffling * remove unnecessary imports and StateCache() construction
2021-03-30 15:01:47 +00:00
automated consensus spec URL updating to v1.4.0 (#6074)
2024-03-14 06:26:36 +00:00
# https://github.com/ethereum/consensus-specs/blob/v1.4.0/specs/phase0/validator.md#validator-assignments
use epochref for get_committee_assignments() to avoid repeated shuffling (#2463) * use epochref for get_committee_assignments() to avoid repeated shuffling * remove unnecessary imports and StateCache() construction
2021-03-30 15:01:47 +00:00
iterator get_committee_assignments*(
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
shufflingRef: ShufflingRef, validator_indices: HashSet[ValidatorIndex]):
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
tuple[committee_index: CommitteeIndex,
Perform attestation check before broadcast (#2550) Currently, we have a bit of a convoluted flow where when sending attestations, we start broadcasting them over gossip then pass them to the attestation validation to include them in the local attestation pool - it should be the other way around: we should be checking attestations _before_ gossipping them - this serves as an additional safety net to ensure that we don't publish junk - this becomes more important when publishing attestations from the API. Also, the REST API was performing its own validation meaning attestations coming from REST would be validated twice - finally, the JSON RPC wasn't pre-validating and would happily broadcast invalid attestations. * Unified attestation production pipeline with the same flow for gossip, locally and API-produced attestations: all are now validated and entered into the pool, then broadcast/republished * Refactor subnet handling with specific SubnetId alias, streamlining where subnets are computed, avoiding the need to pass around the number of active validators * Move some of the subnet handling code to eth2_network * Use BitArray throughout for subnet handling
2021-05-10 07:13:36 +00:00
subnet_id: SubnetId, slot: Slot] =
use epochref for get_committee_assignments() to avoid repeated shuffling (#2463) * use epochref for get_committee_assignments() to avoid repeated shuffling * remove unnecessary imports and StateCache() construction
2021-03-30 15:01:47 +00:00
let
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
committees_per_slot = get_committee_count_per_slot(shufflingRef)
epoch = shufflingRef.epoch
use epochref for get_committee_assignments() to avoid repeated shuffling (#2463) * use epochref for get_committee_assignments() to avoid repeated shuffling * remove unnecessary imports and StateCache() construction
2021-03-30 15:01:47 +00:00
time: spring cleaning (#3262) Time in the beacon chain is expressed relative to the genesis time - this PR creates a `beacon_time` module that collects helpers and utilities for dealing the time units - the new module does not deal with actual wall time (that's remains in `beacon_clock`). Collecting the time related stuff in one place makes it easier to find, avoids some circular imports and allows more easily identifying the code actually needs wall time to operate. * move genesis-time-related functionality into `spec/beacon_time` * avoid using `chronos.Duration` for time differences - it does not support negative values (such as when something happens earlier than it should) * saturate conversions between `FAR_FUTURE_XXX`, so as to avoid overflows * fix delay reporting in validator client so it uses the expected deadline of the slot, not "closest wall slot" * simplify looping over the slots of an epoch * `compute_start_slot_at_epoch` -> `start_slot` * `compute_epoch_at_slot` -> `epoch` A follow-up PR will (likely) introduce saturating arithmetic for the time units - this is merely code moves, renames and fixing of small bugs.
2022-01-11 10:01:54 +00:00
for slot in epoch.slots():
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
for committee_index in get_committee_indices(committees_per_slot):
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
if anyIt(get_beacon_committee(shufflingRef, slot, committee_index), it in validator_indices):
use epochref for get_committee_assignments() to avoid repeated shuffling (#2463) * use epochref for get_committee_assignments() to avoid repeated shuffling * remove unnecessary imports and StateCache() construction
2021-03-30 15:01:47 +00:00
yield (
Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex (#3259) * Harden CommitteeIndex, SubnetId, SyncSubcommitteeIndex Harden the use of `CommitteeIndex` et al to prevent future issues by using a distinct type, then validating before use in several cases - datatypes in spec are kept simple though so that invalid data still can be read. * fix invalid epoch used in REST `/eth/v1/beacon/states/{state_id}/committees` committee length (could return invalid data) * normalize some variable names * normalize committee index loops * fix `RestAttesterDuty` to use `uint64` for `validator_committee_index` * validate `CommitteeIndex` on ingress in REST API * update rest rules with stricter parsing * better REST serializers * save lots of memory by not using `zip` ...at least a few bytes!
2022-01-08 23:28:49 +00:00
committee_index,
compute_subnet_for_attestation(committees_per_slot, slot, committee_index),
use epochref for get_committee_assignments() to avoid repeated shuffling (#2463) * use epochref for get_committee_assignments() to avoid repeated shuffling * remove unnecessary imports and StateCache() construction
2021-03-30 15:01:47 +00:00
slot)
cleanups (#2809) * cleanups * use ForkedTrustedSignedBeaconBlock.ionit where appropriate * move `is_aggregator` to `spec/` * use `errReject` in a few more places * update enr fork id when time is auspicious * use network broadcast functions * Return Ignore for aggregate signature validation timeouts ...consistently between aggregates and attestations. * clean up some more reject/ignore rules * shorten texts a bit * errReject->checkedReject, use err helpers throughout * get rid of quarantine in exitpool as well
2021-08-24 19:49:51 +00:00
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
func is_aggregator*(shufflingRef: ShufflingRef, slot: Slot,
index: CommitteeIndex, slot_signature: ValidatorSig): bool =
cleanups (#2809) * cleanups * use ForkedTrustedSignedBeaconBlock.ionit where appropriate * move `is_aggregator` to `spec/` * use `errReject` in a few more places * update enr fork id when time is auspicious * use network broadcast functions * Return Ignore for aggregate signature validation timeouts ...consistently between aggregates and attestations. * clean up some more reject/ignore rules * shorten texts a bit * errReject->checkedReject, use err helpers throughout * get rid of quarantine in exitpool as well
2021-08-24 19:49:51 +00:00
let
cache shuffling separately from other EpochRef data (fixes #2677) (#3990) In order to avoid full replays when validating attestations hailing from untaken forks, it's better to keep shufflings separate from `EpochRef` and perform a lookahead on the shuffling when processing the block that determines them. This also helps performance in the case where REST clients are trying to perform lookahead on attestation duties and decreases memory usage by sharing shufflings between EpochRef instances of the same dependent root.
2022-08-18 18:07:01 +00:00
committee_len = get_beacon_committee_len(shufflingRef, slot, index)
cleanups (#2809) * cleanups * use ForkedTrustedSignedBeaconBlock.ionit where appropriate * move `is_aggregator` to `spec/` * use `errReject` in a few more places * update enr fork id when time is auspicious * use network broadcast functions * Return Ignore for aggregate signature validation timeouts ...consistently between aggregates and attestations. * clean up some more reject/ignore rules * shorten texts a bit * errReject->checkedReject, use err helpers throughout * get rid of quarantine in exitpool as well
2021-08-24 19:49:51 +00:00
return is_aggregator(committee_len, slot_signature)