mirror of
https://github.com/status-im/nimbus-eth1.git
synced 2025-01-18 00:01:07 +00:00
d39c589ec3
* replace rocksdb row cache with larger rdb lru caches - these serve the same purpose but are more efficient because they skips serialization, locking and rocksdb layering * don't append fresh items to cache - this has the effect of evicting the existing items and replacing them with low-value entries that might never be read - during write-heavy periods of processing, the newly-added entries were evicted during the store loop * allow tuning rdb lru size at runtime * add (hidden) option to print lru stats at exit (replacing the compile-time flag) pre: ``` INF 2024-09-03 15:07:01.136+02:00 Imported blocks blockNumber=20012001 blocks=12000 importedSlot=9216851 txs=1837042 mgas=181911.265 bps=11.675 tps=1870.397 mgps=176.819 avgBps=10.288 avgTps=1574.889 avgMGps=155.952 elapsed=19m26s458ms ``` post: ``` INF 2024-09-03 13:54:26.730+02:00 Imported blocks blockNumber=20012001 blocks=12000 importedSlot=9216851 txs=1837042 mgas=181911.265 bps=11.637 tps=1864.384 mgps=176.250 avgBps=11.202 avgTps=1714.920 avgMGps=169.818 elapsed=17m51s211ms ``` 9%:ish import perf improvement on similar mem usage :)
179 lines
5.4 KiB
Nim
179 lines
5.4 KiB
Nim
# nimbus-eth1
|
|
# Copyright (c) 2023-2024 Status Research & Development GmbH
|
|
# Licensed under either of
|
|
# * Apache License, version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or
|
|
# http://www.apache.org/licenses/LICENSE-2.0)
|
|
# * MIT license ([LICENSE-MIT](LICENSE-MIT) or
|
|
# http://opensource.org/licenses/MIT)
|
|
# at your option. This file may not be copied, modified, or distributed
|
|
# except according to those terms.
|
|
|
|
## Rocks DB fetch data record
|
|
## ==========================
|
|
|
|
{.push raises: [].}
|
|
|
|
import
|
|
eth/common,
|
|
rocksdb,
|
|
results,
|
|
stew/keyed_queue,
|
|
../../[aristo_blobify, aristo_desc],
|
|
../init_common,
|
|
./rdb_desc,
|
|
metrics,
|
|
std/concurrency/atomics
|
|
|
|
const
|
|
extraTraceMessages = false
|
|
## Enable additional logging noise
|
|
|
|
when extraTraceMessages:
|
|
import
|
|
chronicles
|
|
|
|
logScope:
|
|
topics = "aristo-rocksdb"
|
|
|
|
type
|
|
RdbVtxLruCounter = ref object of Counter
|
|
RdbKeyLruCounter = ref object of Counter
|
|
|
|
var
|
|
rdbVtxLruStatsMetric {.used.} = RdbVtxLruCounter.newCollector(
|
|
"aristo_rdb_vtx_lru_total",
|
|
"Vertex LRU lookup (hit/miss, world/account, branch/leaf)",
|
|
labels = ["state", "vtype", "hit"],
|
|
)
|
|
rdbKeyLruStatsMetric {.used.} = RdbKeyLruCounter.newCollector(
|
|
"aristo_rdb_key_lru_total", "HashKey LRU lookup", labels = ["state", "hit"]
|
|
)
|
|
|
|
method collect*(collector: RdbVtxLruCounter, output: MetricHandler) =
|
|
let timestamp = collector.now()
|
|
|
|
# We don't care about synchronization between each type of metric or between
|
|
# the metrics thread and others since small differences like this don't matter
|
|
for state in RdbStateType:
|
|
for vtype in VertexType:
|
|
for hit in [false, true]:
|
|
output(
|
|
name = "aristo_rdb_vtx_lru_total",
|
|
value = float64(rdbVtxLruStats[state][vtype].get(hit)),
|
|
labels = ["state", "vtype", "hit"],
|
|
labelValues = [$state, $vtype, $ord(hit)],
|
|
timestamp = timestamp,
|
|
)
|
|
|
|
method collect*(collector: RdbKeyLruCounter, output: MetricHandler) =
|
|
let timestamp = collector.now()
|
|
|
|
for state in RdbStateType:
|
|
for hit in [false, true]:
|
|
output(
|
|
name = "aristo_rdb_key_lru_total",
|
|
value = float64(rdbKeyLruStats[state].get(hit)),
|
|
labels = ["state", "hit"],
|
|
labelValues = [$state, $ord(hit)],
|
|
timestamp = timestamp,
|
|
)
|
|
|
|
# ------------------------------------------------------------------------------
|
|
# Public functions
|
|
# ------------------------------------------------------------------------------
|
|
|
|
proc getAdm*(rdb: RdbInst; xid: AdminTabID): Result[Blob,(AristoError,string)] =
|
|
var res: Blob
|
|
let onData = proc(data: openArray[byte]) =
|
|
res = @data
|
|
|
|
let gotData = rdb.admCol.get(xid.toOpenArray, onData).valueOr:
|
|
const errSym = RdbBeDriverGetAdmError
|
|
when extraTraceMessages:
|
|
trace logTxt "getAdm", xid, error=errSym, info=error
|
|
return err((errSym,error))
|
|
|
|
# Correct result if needed
|
|
if not gotData:
|
|
res = EmptyBlob
|
|
ok move(res)
|
|
|
|
proc getKey*(
|
|
rdb: var RdbInst;
|
|
rvid: RootedVertexID;
|
|
): Result[HashKey,(AristoError,string)] =
|
|
# Try LRU cache first
|
|
var rc = rdb.rdKeyLru.lruFetch(rvid.vid)
|
|
if rc.isOK:
|
|
rdbKeyLruStats[rvid.to(RdbStateType)].inc(true)
|
|
return ok(move(rc.value))
|
|
|
|
rdbKeyLruStats[rvid.to(RdbStateType)].inc(false)
|
|
|
|
# Otherwise fetch from backend database
|
|
# A threadvar is used to avoid allocating an environment for onData
|
|
var res{.threadvar.}: Opt[HashKey]
|
|
let onData = proc(data: openArray[byte]) =
|
|
res = HashKey.fromBytes(data)
|
|
|
|
let gotData = rdb.keyCol.get(rvid.blobify().data(), onData).valueOr:
|
|
const errSym = RdbBeDriverGetKeyError
|
|
when extraTraceMessages:
|
|
trace logTxt "getKey", rvid, error=errSym, info=error
|
|
return err((errSym,error))
|
|
|
|
# Correct result if needed
|
|
if not gotData:
|
|
res.ok(VOID_HASH_KEY)
|
|
elif res.isErr():
|
|
return err((RdbHashKeyExpected,"")) # Parsing failed
|
|
|
|
# Update cache and return
|
|
if rdb.rdKeySize > 0:
|
|
ok rdb.rdKeyLru.lruAppend(rvid.vid, res.value(), rdb.rdKeySize)
|
|
else:
|
|
ok res.value()
|
|
|
|
proc getVtx*(
|
|
rdb: var RdbInst;
|
|
rvid: RootedVertexID;
|
|
): Result[VertexRef,(AristoError,string)] =
|
|
# Try LRU cache first
|
|
if rdb.rdVtxSize > 0:
|
|
var rc = rdb.rdVtxLru.lruFetch(rvid.vid)
|
|
if rc.isOK:
|
|
rdbVtxLruStats[rvid.to(RdbStateType)][rc.value().vType].inc(true)
|
|
return ok(move(rc.value))
|
|
|
|
# Otherwise fetch from backend database
|
|
# A threadvar is used to avoid allocating an environment for onData
|
|
var res {.threadvar.}: Result[VertexRef,AristoError]
|
|
let onData = proc(data: openArray[byte]) =
|
|
res = data.deblobify(VertexRef)
|
|
|
|
let gotData = rdb.vtxCol.get(rvid.blobify().data(), onData).valueOr:
|
|
const errSym = RdbBeDriverGetVtxError
|
|
when extraTraceMessages:
|
|
trace logTxt "getVtx", vid, error=errSym, info=error
|
|
return err((errSym,error))
|
|
|
|
if not gotData:
|
|
# As a hack, we count missing data as leaf nodes
|
|
rdbVtxLruStats[rvid.to(RdbStateType)][VertexType.Leaf].inc(false)
|
|
return ok(VertexRef(nil))
|
|
|
|
if res.isErr():
|
|
return err((res.error(), "Parsing failed")) # Parsing failed
|
|
|
|
rdbVtxLruStats[rvid.to(RdbStateType)][res.value().vType].inc(false)
|
|
|
|
# Update cache and return
|
|
if rdb.rdVtxSize > 0:
|
|
ok rdb.rdVtxLru.lruAppend(rvid.vid, res.value(), rdb.rdVtxSize)
|
|
else:
|
|
ok res.value()
|
|
|
|
# ------------------------------------------------------------------------------
|
|
# End
|
|
# ------------------------------------------------------------------------------
|