mirror of
https://github.com/status-im/nimbus-eth1.git
synced 2025-01-17 15:50:57 +00:00
a84a2131cd
* Imported/rebase from `no-ext`, PR #2485 Store extension nodes together with the branch Extension nodes must be followed by a branch - as such, it makes sense to store the two together both in the database and in memory: * fewer reads, writes and updates to traverse the tree * simpler logic for maintaining the node structure * less space used, both memory and storage, because there are fewer nodes overall There is also a downside: hashes can no longer be cached for an extension - instead, only the extension+branch hash can be cached - this seems like a fine tradeoff since computing it should be fast. TODO: fix commented code * Fix merge functions and `toNode()` * Update `merkleSignCommit()` prototype why: Result is always a 32bit hash * Update short Merkle hash key generation details: Ethereum reference MPTs use Keccak hashes as node links if the size of an RLP encoded node is at least 32 bytes. Otherwise, the RLP encoded node value is used as a pseudo node link (rather than a hash.) This is specified in the yellow paper, appendix D. Different to the `Aristo` implementation, the reference MPT would not store such a node on the key-value database. Rather the RLP encoded node value is stored instead of a node link in a parent node is stored as a node link on the parent database. Only for the root hash, the top level node is always referred to by the hash. * Fix/update `Extension` sections why: Were commented out after removal of a dedicated `Extension` type which left the system disfunctional. * Clean up unused error codes * Update unit tests * Update docu --------- Co-authored-by: Jacek Sieka <jacek@status.im>
114 lines
3.8 KiB
Nim
114 lines
3.8 KiB
Nim
# nimbus-eth1
|
|
# Copyright (c) 2023-2024 Status Research & Development GmbH
|
|
# Licensed under either of
|
|
# * Apache License, version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or
|
|
# http://www.apache.org/licenses/LICENSE-2.0)
|
|
# * MIT license ([LICENSE-MIT](LICENSE-MIT) or
|
|
# http://opensource.org/licenses/MIT)
|
|
# at your option. This file may not be copied, modified, or distributed
|
|
# except according to those terms.
|
|
|
|
{.push raises: [].}
|
|
|
|
import
|
|
std/[sets, tables],
|
|
eth/common,
|
|
results,
|
|
stew/interval_set,
|
|
../../aristo,
|
|
../aristo_walk/persistent,
|
|
".."/[aristo_desc, aristo_get, aristo_layers]
|
|
|
|
# ------------------------------------------------------------------------------
|
|
# Public functions
|
|
# ------------------------------------------------------------------------------
|
|
|
|
proc checkBE*[T: RdbBackendRef|MemBackendRef|VoidBackendRef](
|
|
_: type T;
|
|
db: AristoDbRef; # Database, top layer
|
|
): Result[void,(VertexID,AristoError)] =
|
|
## Make sure that each vertex has a Merkle hash and vice versa. Also check
|
|
## the vertex ID generator state.
|
|
var topVidBe: RootedVertexID = (VertexID(0), VertexID(0))
|
|
|
|
for (rvid,vtx) in T.walkVtxBe db:
|
|
if topVidBe.vid < rvid.vid:
|
|
topVidBe = rvid
|
|
if not vtx.isValid:
|
|
return err((rvid.vid,CheckBeVtxInvalid))
|
|
case vtx.vType:
|
|
of Leaf:
|
|
discard
|
|
of Branch:
|
|
block check42Links:
|
|
var seen = false
|
|
for n in 0 .. 15:
|
|
if vtx.bVid[n].isValid:
|
|
if seen:
|
|
break check42Links
|
|
seen = true
|
|
return err((rvid.vid,CheckBeVtxBranchLinksMissing))
|
|
|
|
for (rvid,key) in T.walkKeyBe db:
|
|
if topVidBe.vid < rvid.vid:
|
|
topVidBe = rvid
|
|
let vtx = db.getVtxBE(rvid).valueOr:
|
|
return err((rvid.vid,CheckBeVtxMissing))
|
|
|
|
# Compare calculated `vTop` against database state
|
|
# TODO
|
|
# if topVidBe.isValid:
|
|
# let vidTuvBe = block:
|
|
# let rc = db.getTuvBE()
|
|
# if rc.isOk:
|
|
# rc.value
|
|
# elif rc.error == GetTuvNotFound:
|
|
# VertexID(0)
|
|
# else:
|
|
# return err((VertexID(0),rc.error))
|
|
# if vidTuvBe != topVidBe:
|
|
# # All vertices and keys between `topVidBe` and `vidTuvBe` must have
|
|
# # been deleted.
|
|
# for vid in max(topVidBe + 1, VertexID(LEAST_FREE_VID)) .. vidTuvBe:
|
|
# if db.getVtxBE(vid).isOk or db.getKeyBE(vid).isOk:
|
|
# return err((vid,CheckBeGarbledVTop))
|
|
|
|
# Check layer cache against backend
|
|
block:
|
|
var topVidCache: RootedVertexID = (VertexID(0), VertexID(0))
|
|
|
|
# Check structural table
|
|
for (rvid,vtx) in db.layersWalkVtx:
|
|
if vtx.isValid and topVidCache.vid < rvid.vid:
|
|
topVidCache = rvid
|
|
let key = db.layersGetKey(rvid).valueOr: VOID_HASH_KEY
|
|
if not vtx.isValid:
|
|
# Some vertex is to be deleted, the key must be empty
|
|
if key.isValid:
|
|
return err((rvid.vid,CheckBeCacheKeyNonEmpty))
|
|
|
|
# Check key table
|
|
var list: seq[RootedVertexID]
|
|
for (rvid,key) in db.layersWalkKey:
|
|
if key.isValid and topVidCache.vid < rvid.vid:
|
|
topVidCache = rvid
|
|
list.add rvid
|
|
let vtx = db.getVtx rvid
|
|
if db.layersGetVtx(rvid).isErr and not vtx.isValid:
|
|
return err((rvid.vid,CheckBeCacheKeyDangling))
|
|
|
|
# Check vTop
|
|
# TODO
|
|
# if topVidCache.isValid and topVidCache != db.vTop:
|
|
# # All vertices and keys between `topVidCache` and `db.vTop` must have
|
|
# # been deleted.
|
|
# for vid in max(db.vTop + 1, VertexID(LEAST_FREE_VID)) .. topVidCache:
|
|
# if db.layersGetVtxOrVoid(vid).isValid or
|
|
# db.layersGetKeyOrVoid(vid).isValid:
|
|
# return err((db.vTop,CheckBeCacheGarbledVTop))
|
|
ok()
|
|
|
|
# ------------------------------------------------------------------------------
|
|
# End
|
|
# ------------------------------------------------------------------------------
|