5462c05dc6
* Fix copyright year * Show elapsed times with enabled `CoreDb` API tracking * Show elapsed times with enabled `LedgerRef` API tracking * Reorg `CoreDb` auto destructors for `Aristo` DB why: While `Aristo` supports some parallelism for concurrent database access, this comes with a price of management overhead. With a naive approach, the auto-destructor will slow down execution because the ledger and evm treat the database in a shared mode where a DB descriptor is just created and thrown away shortly after. This is reflected in the `Coredb` abstraction layer above `Aristo`/`Kvt` where a few `Shared` type descriptors are cached and a shared reference is returned rather than a disposable new object. * For `CoreDb` support transaction level tracking details: This is mainly an extra for the legacy DB as `Aristo` and `Kvt` support this already. Also return an error on the legacy DB backend when `persistent()` is called while there are transactions pending (the `persistent()` call does nothing otherwise on the legacy backend.) * Clear compiler warnings (remove unused variables etc.)
The file accounts_cache.nim has been relocated
Background
The new LedgerRef module unifies different implementations of the accounts_cache. It is intended to be used as new base method for all of the AccountsCache implementations. Only constructors differ, depending on the implementation.
This was needed to accomodate for different CoreDb API paradigms. While the overloaded legacy AccountsCache implementation is just a closure based wrapper around the accounts_cache module, the overloaded AccountsLedgerRef is a closure based wrapper around the accounts_ledger module with the new CoreDb API returning Result[] values and saparating the meaning of trie root hash and trie root reference.
This allows to use the legacy hexary database (with the new CoreDb API) as well as the Aristo database (only supported on new API.)
Instructions
| Legacy notation | LedgerRef replacement | Comment |
|---|---|---|
| import accounts_cache | import ledger | preferred method, |
| AccountsCache.init(..) | AccountsCache.init(..) | wraps AccountsCache |
| methods | ||
| or | ||
| import ledger/accounts_cache | stay with legacy | |
| AccountsCache.init(..) | version of | |
| AccountsCache | ||
| -- | ||
| fn(ac: AccountsCache) | fn(ac: LedgerRef) | function example for |
| preferred wrapper | ||
| or | method | |
| fn(ac: AccountsCache) | with legacy version, | |
| no change here |
The constructor decides which CoreDb API is to be used
| Legacy API constructor | new API Constructor |
|---|---|
| import ledger | import ledger |
| let w = AccountsCache.init(..) | let w = AccountsLedgerRef.init(..) |