nimbus-eth1/nimbus/core
Jacek Sieka 0b32078c4b
Consolidate block type for block processing (#2325)
This PR consolidates the split header-body sequences into a single EthBlock
sequence and cleans up the fallout from that which significantly reduces
block processing overhead during import thanks to less garbage collection
and fewer copies of things all around.

Notably, since the number of headers must always match the number of bodies,
we also get rid of a pointless degree of freedom that in the future could
introduce unnecessary bugs.

* only read header and body from era file
* avoid several unnecessary copies along the block processing way
* simplify signatures, cleaning up unused arguemnts and returns
* use `stew/assign2` in a few strategic places where the generated
  nim assignent is slow and add a few `move` to work around poor
  analysis in nim 1.6 (will need to be revisited for 2.0)

```
stats-20240607_2223-a814aa0b.csv vs stats-20240608_0714-21c1d0a9.csv
                       bps_x     bps_y     tps_x        tps_y    bpsd    tpsd    timed
block_number
(498305, 713245]    1,540.52  1,809.73  2,361.58  2775.340189  17.63%  17.63%  -14.92%
(713245, 928185]      730.36    865.26  1,715.90  2028.973852  18.01%  18.01%  -15.21%
(928185, 1143126]     663.03    789.10  2,529.26  3032.490771  19.79%  19.79%  -16.28%
(1143126, 1358066]    393.46    508.05  2,152.50  2777.578119  29.13%  29.13%  -22.50%
(1358066, 1573007]    370.88    440.72  2,351.31  2791.896052  18.81%  18.81%  -15.80%
(1573007, 1787947]    283.65    335.11  2,068.93  2441.373402  17.60%  17.60%  -14.91%
(1787947, 2002888]    287.29    342.11  2,078.39  2474.179448  18.99%  18.99%  -15.91%
(2002888, 2217828]    293.38    343.16  2,208.83   2584.77457  17.16%  17.16%  -14.61%
(2217828, 2432769]    140.09    167.86  1,081.87  1296.336926  18.82%  18.82%  -15.80%

blocks: 1934464, baseline: 3h13m1s, contender: 2h43m47s
bpsd (mean): 19.55%
tpsd (mean): 19.55%
Time (total): -29m13s, -15.14%
```
2024-06-09 16:32:20 +02:00
..
chain Consolidate block type for block processing (#2325) 2024-06-09 16:32:20 +02:00
executor Consolidate block type for block processing (#2325) 2024-06-09 16:32:20 +02:00
pow rm some proof of work mining support (#2227) 2024-05-27 21:49:07 +02:00
tx_pool Cleanup stateless and block witness code. (#2295) 2024-06-08 15:05:00 +07:00
block_import.nim Consolidate block type for block processing (#2325) 2024-06-09 16:32:20 +02:00
casper.nim processBeaconBlockRoot in TxPool(EIP-4788) 2023-10-19 07:50:07 +07:00
chain.nim saner source code grouping 2022-12-02 13:51:42 +07:00
dao.nim Ledger activate unified accounts cache wrapper (#1939) 2023-12-12 19:12:56 +00:00
eip4844.nim results: use canonical import (#2248) 2024-05-30 14:54:03 +02:00
executor.nim saner source code grouping 2022-12-02 13:51:42 +07:00
gaslimit.nim results: use canonical import (#2248) 2024-05-30 14:54:03 +02:00
pow.nim Replace some usage of std/options with results Opt (#2323) 2024-06-07 23:39:58 +02:00
tx_pool.nim results: use canonical import (#2248) 2024-05-30 14:54:03 +02:00
validate.nim Consolidate block type for block processing (#2325) 2024-06-09 16:32:20 +02:00
withdrawals.nim Consolidate block type for block processing (#2325) 2024-06-09 16:32:20 +02:00