mirror of
https://github.com/status-im/nimbus-eth1.git
synced 2025-01-29 13:35:38 +00:00
01ca415721
Currently, computed hash keys are stored in a separate column family with respect to the MPT data they're generated from - this has several disadvantages: * A lot of space is wasted because the lookup key (`RootedVertexID`) is repeated in both tables - this is 30% of the `AriKey` content! * rocksdb must maintain in-memory bloom filters and LRU caches for said keys, doubling its "minimal efficient cache size" * An extra disk traversal must be made to check for existence of cached hash key * Doubles the amount of files on disk due to each column family being its own set of files Here, the two CFs are joined such that both key and data is stored in `AriVtx`. This means: * we save ~30% disk space on repeated lookup keys * we save ~2gb of memory overhead that can be used to cache data instead of indices * we can skip storing hash keys for MPT leaf nodes - these are trivial to compute and waste a lot of space - previously they had to present in the `AriKey` CF to avoid having to look in two tables on the happy path. * There is a small increase in write amplification because when a hash value is updated for a branch node, we must write both key and branch data - previously we would write only the key * There's a small shift in CPU usage - instead of performing lookups in the database, hashes for leaf nodes are (re)-computed on the fly * We can return to slightly smaller on-disk SST files since there's fewer of them, which should reduce disk traffic a bit Internally, there are also other advantages: * when clearing keys, we no longer have to store a zero hash in memory - instead, we deduce staleness of the cached key from the presence of an updated VertexRef - this saves ~1gb of mem overhead during import * hash key cache becomes dedicated to branch keys since leaf keys are no longer stored in memory, reducing churn * key computation is a lot faster thanks to the skipped second disk traversal - a key computation for mainnet can be completed in 11 hours instead of ~2 days (!) thanks to better cache usage and less read amplification - with additional improvements to the on-disk format, we can probably get rid of the initial full traversal method of seeding the key cache on first start after import All in all, this PR reduces the size of a mainnet database from 160gb to 110gb and the peak memory footprint during import by ~1-2gb.
143 lines
3.7 KiB
Nim
143 lines
3.7 KiB
Nim
# nimbus-eth1
|
|
# Copyright (c) 2023-2024 Status Research & Development GmbH
|
|
# Licensed under either of
|
|
# * Apache License, version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or
|
|
# http://www.apache.org/licenses/LICENSE-2.0)
|
|
# * MIT license ([LICENSE-MIT](LICENSE-MIT) or
|
|
# http://opensource.org/licenses/MIT)
|
|
# at your option. This file may not be copied, modified, or distributed
|
|
# except according to those terms.
|
|
|
|
## Rocks DB store data iterator
|
|
## ============================
|
|
##
|
|
{.push raises: [].}
|
|
|
|
import
|
|
eth/common,
|
|
stew/endians2,
|
|
rocksdb,
|
|
./rdb_desc,
|
|
../../aristo_blobify,
|
|
../../aristo_desc/desc_identifiers
|
|
|
|
const
|
|
extraTraceMessages = false
|
|
## Enable additional logging noise
|
|
|
|
when extraTraceMessages:
|
|
import
|
|
chronicles
|
|
|
|
logScope:
|
|
topics = "aristo-rocksdb"
|
|
|
|
# ------------------------------------------------------------------------------
|
|
# Public iterators
|
|
# ------------------------------------------------------------------------------
|
|
|
|
iterator walkAdm*(rdb: RdbInst): tuple[xid: uint64, data: seq[byte]] =
|
|
## Walk over key-value pairs of the admin column of the database.
|
|
##
|
|
## Non-decodable entries are are ignored.
|
|
##
|
|
block walkBody:
|
|
let rit = rdb.admCol.openIterator().valueOr:
|
|
when extraTraceMessages:
|
|
trace logTxt "walkAdm()", error
|
|
break walkBody
|
|
defer: rit.close()
|
|
|
|
for (key,val) in rit.pairs:
|
|
if key.len == 8 and val.len != 0:
|
|
yield (uint64.fromBytesBE key, val)
|
|
|
|
iterator walkKey*(rdb: RdbInst): tuple[rvid: RootedVertexID, data: HashKey] =
|
|
## Walk over key-value pairs of the hash key column of the database.
|
|
##
|
|
## Non-decodable entries are are ignored.
|
|
##
|
|
block walkBody:
|
|
let rit = rdb.vtxCol.openIterator().valueOr:
|
|
when extraTraceMessages:
|
|
trace logTxt "walkVtx()", error
|
|
break walkBody
|
|
defer: rit.close()
|
|
|
|
rit.seekToFirst()
|
|
var key: RootedVertexID
|
|
var value: HashKey
|
|
var valid: bool
|
|
|
|
proc readKey(data: openArray[byte]) =
|
|
key = deblobify(data, RootedVertexID).valueOr:
|
|
valid = false
|
|
default(RootedVertexID)
|
|
|
|
proc readValue(data: openArray[byte]) =
|
|
value = deblobify(data, HashKey).valueOr:
|
|
valid = false
|
|
default(HashKey)
|
|
|
|
while rit.isValid():
|
|
valid = true
|
|
rit.value(readValue)
|
|
|
|
if valid:
|
|
rit.key(readKey)
|
|
if valid:
|
|
yield (key, value)
|
|
|
|
rit.next()
|
|
|
|
iterator walkVtx*(
|
|
rdb: RdbInst, kinds: set[VertexType]): tuple[rvid: RootedVertexID, data: VertexRef] =
|
|
## Walk over key-value pairs of the vertex column of the database.
|
|
##
|
|
## Non-decodable entries are are ignored.
|
|
##
|
|
block walkBody:
|
|
let rit = rdb.vtxCol.openIterator().valueOr:
|
|
when extraTraceMessages:
|
|
trace logTxt "walkVtx()", error
|
|
break walkBody
|
|
defer: rit.close()
|
|
|
|
rit.seekToFirst()
|
|
var key: RootedVertexID
|
|
var value: VertexRef
|
|
var valid: bool
|
|
|
|
proc readKey(data: openArray[byte]) =
|
|
key = deblobify(data, RootedVertexID).valueOr:
|
|
valid = false
|
|
default(RootedVertexID)
|
|
|
|
proc readValue(data: openArray[byte]) =
|
|
let vType = deblobifyType(data, VertexRef).valueOr:
|
|
valid = false
|
|
return
|
|
|
|
if vType notin kinds:
|
|
valid = false
|
|
return
|
|
|
|
value = deblobify(data, VertexRef).valueOr:
|
|
valid = false
|
|
default(VertexRef)
|
|
|
|
while rit.isValid():
|
|
valid = true
|
|
rit.value(readValue)
|
|
|
|
if valid:
|
|
rit.key(readKey)
|
|
if valid:
|
|
yield (key, value)
|
|
|
|
rit.next()
|
|
|
|
# ------------------------------------------------------------------------------
|
|
# End
|
|
# ------------------------------------------------------------------------------
|