add TODO comment and trigger ci rebuild

This commit is contained in:
andri lim 2018-11-29 10:19:59 +07:00 committed by zah
parent af84be0eea
commit f6d9308208
1 changed files with 2 additions and 0 deletions

View File

@ -325,6 +325,8 @@ proc setupEthRpc*(node: EthereumNode, chain: BaseChainDB, rpcsrv: RpcServer) =
blockHash = chain.getBlockHash(txDetails.blockNumber) blockHash = chain.getBlockHash(txDetails.blockNumber)
transaction = getBlockBody(blockHash).transactions[txDetails.index] transaction = getBlockBody(blockHash).transactions[txDetails.index]
populateTransactionObject(transaction, txDetails.index, header, blockHash) populateTransactionObject(transaction, txDetails.index, header, blockHash)
# TODO: if the requested transaction not in blockchain
# try to look for pending transaction in txpool
rpcsrv.rpc("eth_getTransactionByBlockHashAndIndex") do(data: HexDataStr, quantity: int) -> TransactionObject: rpcsrv.rpc("eth_getTransactionByBlockHashAndIndex") do(data: HexDataStr, quantity: int) -> TransactionObject:
## Returns information about a transaction by block hash and transaction index position. ## Returns information about a transaction by block hash and transaction index position.