From f32419c81f9441577ee96d0512cb1165ecbb5207 Mon Sep 17 00:00:00 2001
From: jangko <jangko128@gmail.com>
Date: Sun, 22 Oct 2023 10:24:19 +0700
Subject: [PATCH] Increase rpc server request limit to 2MB

This is to accomodate send_rawTransaction with
large blob tx of EIP-4844
---
 nimbus/nimbus.nim         |   8 +--
 nimbus/rpc.nim            |   6 ++-
 nimbus/rpc/rpc_server.nim | 101 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 109 insertions(+), 6 deletions(-)
 create mode 100644 nimbus/rpc/rpc_server.nim

diff --git a/nimbus/nimbus.nim b/nimbus/nimbus.nim
index ff9ea2c7a..d5f715ff4 100644
--- a/nimbus/nimbus.nim
+++ b/nimbus/nimbus.nim
@@ -270,8 +270,8 @@ proc localServices(nimbus: NimbusNode, conf: NimbusConf,
                 else:
                   @[httpCorsHook]
 
-    nimbus.rpcServer = newRpcHttpServer(
-      [initTAddress(conf.rpcAddress, conf.rpcPort)],
+    nimbus.rpcServer = newRpcHttpServerWithParams(
+      initTAddress(conf.rpcAddress, conf.rpcPort),
       authHooks = hooks
     )
     setupCommonRpc(nimbus.ethNode, conf, nimbus.rpcServer)
@@ -372,8 +372,8 @@ proc localServices(nimbus: NimbusNode, conf: NimbusConf,
   if conf.engineApiEnabled:
     #let maybeAsyncDataSource = maybeStatelessAsyncDataSource(nimbus, conf)
     if conf.engineApiPort != conf.rpcPort:
-      nimbus.engineApiServer = newRpcHttpServer(
-        [initTAddress(conf.engineApiAddress, conf.engineApiPort)],
+      nimbus.engineApiServer = newRpcHttpServerWithParams(
+        initTAddress(conf.engineApiAddress, conf.engineApiPort),
         authHooks = @[httpJwtAuthHook, httpCorsHook]
       )
       setupEngineAPI(nimbus.beaconEngine, nimbus.engineApiServer)
diff --git a/nimbus/rpc.nim b/nimbus/rpc.nim
index e59860742..88f5f528b 100644
--- a/nimbus/rpc.nim
+++ b/nimbus/rpc.nim
@@ -14,7 +14,8 @@ import
   ./rpc/p2p,
   ./rpc/jwt_auth,
   ./rpc/cors,
-  ./rpc/hexstrings
+  ./rpc/hexstrings,
+  ./rpc/rpc_server
 
 export
   common,
@@ -23,4 +24,5 @@ export
   p2p,
   jwt_auth,
   cors,
-  hexstrings
+  hexstrings,
+  rpc_server
diff --git a/nimbus/rpc/rpc_server.nim b/nimbus/rpc/rpc_server.nim
new file mode 100644
index 000000000..5ae516fc9
--- /dev/null
+++ b/nimbus/rpc/rpc_server.nim
@@ -0,0 +1,101 @@
+# Nimbus
+# Copyright (c) 2023 Status Research & Development GmbH
+# Licensed under either of
+#  * Apache License, version 2.0, ([LICENSE-APACHE](LICENSE-APACHE))
+#  * MIT license ([LICENSE-MIT](LICENSE-MIT))
+# at your option.
+# This file may not be copied, modified, or distributed except according to
+# those terms.
+
+import
+  chronos,
+  json_rpc/rpcserver
+
+type
+  RpcHttpServerParams = object
+    socketFlags: set[ServerFlags]
+    serverUri: Uri
+    serverIdent: string
+    maxConnections: int
+    bufferSize: int
+    backlogSize: int
+    httpHeadersTimeout: chronos.Duration
+    maxHeadersSize: int
+    maxRequestBodySize: int
+
+
+func defaultRpcHttpServerParams(): RpcHttpServerParams =
+  RpcHttpServerParams(
+    socketFlags: {ServerFlags.TcpNoDelay, ServerFlags.ReuseAddr},
+    serverUri: Uri(),
+    serverIdent: "",
+    maxConnections: -1,
+    bufferSize: 4096,
+    backlogSize: 100,
+    httpHeadersTimeout: 10.seconds,
+    maxHeadersSize: 8192,
+    maxRequestBodySize: 2 * 1024 * 1024,
+  )
+
+template processResolvedAddresses =
+  if tas4.len + tas6.len == 0:
+    # Addresses could not be resolved, critical error.
+    raise newException(RpcAddressUnresolvableError, "Unable to get address!")
+
+  for r in tas4:
+    yield r
+
+  if tas4.len == 0: # avoid ipv4 + ipv6 running together
+    for r in tas6:
+      yield r
+
+iterator resolvedAddresses(address: string): TransportAddress =
+  var
+    tas4: seq[TransportAddress]
+    tas6: seq[TransportAddress]
+
+  # Attempt to resolve `address` for IPv4 address space.
+  try:
+    tas4 = resolveTAddress(address, AddressFamily.IPv4)
+  except CatchableError:
+    discard
+
+  # Attempt to resolve `address` for IPv6 address space.
+  try:
+    tas6 = resolveTAddress(address, AddressFamily.IPv6)
+  except CatchableError:
+    discard
+
+  processResolvedAddresses()
+
+proc addServer*(server: RpcHttpServer, address: TransportAddress, params: RpcHttpServerParams) =
+  server.addHttpServer(
+    address,
+    params.socketFlags,
+    params.serverUri,
+    params.serverIdent,
+    params.maxConnections,
+    params.bufferSize,
+    params.backlogSize,
+    params.httpHeadersTimeout,
+    params.maxHeadersSize,
+    params.maxRequestBodySize)
+
+proc addServer*(server: RpcHttpServer, address: string, params: RpcHttpServerParams) =
+  ## Create new server and assign it to addresses ``addresses``.
+  for a in resolvedAddresses(address):
+    # TODO handle partial failures, ie when 1/N addresses fail
+    server.addServer(a, params)
+
+proc newRpcHttpServerWithParams*(address: TransportAddress, authHooks: seq[HttpAuthHook] = @[]): RpcHttpServer =
+  ## Create new server and assign it to addresses ``addresses``.
+  let server = RpcHttpServer.new(authHooks)
+  let params = defaultRpcHttpServerParams()
+  server.addServer(address, params)
+  server
+
+proc newRpcHttpServerWithParams*(address: string, authHooks: seq[HttpAuthHook] = @[]): RpcHttpServer =
+  let server = RpcHttpServer.new(authHooks)
+  let params = defaultRpcHttpServerParams()
+  server.addServer(address, params)
+  server