Change some spammy info/error logs to debug (#2840)

These logs are not really usful to an end user, and are rather
for developers, so we move them to debug.
This commit is contained in:
Kim De Mey 2024-11-06 15:44:20 +01:00 committed by GitHub
parent fcb668d23f
commit eaf98dccb1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 10 deletions

View File

@ -136,7 +136,7 @@ proc getVerifiedBlockHeader*(
# gets verified before storing. # gets verified before storing.
let localContent = n.getLocalContent(Header, contentKey, contentId) let localContent = n.getLocalContent(Header, contentKey, contentId)
if localContent.isSome(): if localContent.isSome():
info "Fetched block header locally" debug "Fetched block header locally"
return localContent return localContent
for i in 0 ..< (1 + n.contentRequestRetries): for i in 0 ..< (1 + n.contentRequestRetries):
@ -149,7 +149,7 @@ proc getVerifiedBlockHeader*(
warn "Validation of block header failed", error = error warn "Validation of block header failed", error = error
continue continue
info "Fetched valid block header from the network" debug "Fetched valid block header from the network"
# Content is valid, it can be stored and propagated to interested peers # Content is valid, it can be stored and propagated to interested peers
n.portalProtocol.storeContent( n.portalProtocol.storeContent(
contentKey, contentId, headerContent.content, cacheContent = true contentKey, contentId, headerContent.content, cacheContent = true
@ -180,7 +180,7 @@ proc getBlockBody*(
let localContent = n.getLocalContent(BlockBody, contentKey, contentId, header) let localContent = n.getLocalContent(BlockBody, contentKey, contentId, header)
if localContent.isSome(): if localContent.isSome():
info "Fetched block body locally" debug "Fetched block body locally"
return localContent return localContent
for i in 0 ..< (1 + n.contentRequestRetries): for i in 0 ..< (1 + n.contentRequestRetries):
@ -193,7 +193,7 @@ proc getBlockBody*(
warn "Validation of block body failed", error warn "Validation of block body failed", error
continue continue
info "Fetched block body from the network" debug "Fetched block body from the network"
# Content is valid, it can be stored and propagated to interested peers # Content is valid, it can be stored and propagated to interested peers
n.portalProtocol.storeContent( n.portalProtocol.storeContent(
contentKey, contentId, bodyContent.content, cacheContent = true contentKey, contentId, bodyContent.content, cacheContent = true
@ -255,7 +255,7 @@ proc getReceipts*(
let localContent = n.getLocalContent(seq[Receipt], contentKey, contentId) let localContent = n.getLocalContent(seq[Receipt], contentKey, contentId)
if localContent.isSome(): if localContent.isSome():
info "Fetched receipts locally" debug "Fetched receipts locally"
return localContent return localContent
for i in 0 ..< (1 + n.contentRequestRetries): for i in 0 ..< (1 + n.contentRequestRetries):
@ -267,7 +267,7 @@ proc getReceipts*(
warn "Validation of receipts failed", error warn "Validation of receipts failed", error
continue continue
info "Fetched receipts from the network" debug "Fetched receipts from the network"
# Content is valid, it can be stored and propagated to interested peers # Content is valid, it can be stored and propagated to interested peers
n.portalProtocol.storeContent( n.portalProtocol.storeContent(
contentKey, contentId, receiptsContent.content, cacheContent = true contentKey, contentId, receiptsContent.content, cacheContent = true
@ -367,14 +367,14 @@ proc validateContent(
let res = await n.validateContent(contentItem, contentKey) let res = await n.validateContent(contentItem, contentKey)
if res.isOk(): if res.isOk():
let contentId = n.portalProtocol.toContentId(contentKey).valueOr: let contentId = n.portalProtocol.toContentId(contentKey).valueOr:
error "Received offered content with invalid content key", contentKey warn "Received offered content with invalid content key", contentKey
return false return false
n.portalProtocol.storeContent(contentKey, contentId, contentItem) n.portalProtocol.storeContent(contentKey, contentId, contentItem)
debug "Received offered content validated successfully", contentKey debug "Received offered content validated successfully", contentKey
else: else:
error "Received offered content failed validation", contentKey, error = res.error debug "Received offered content failed validation", contentKey, error = res.error
return false return false
return true return true

View File

@ -985,9 +985,9 @@ proc offer(
return ok(m.contentKeys) return ok(m.contentKeys)
else: else:
warn "Offer failed due to accept request failure ", debug "Offer failed due to accept request failure ",
error = acceptMessageResponse.error error = acceptMessageResponse.error
return err("No accept response") return err("No or invalid accept response: " & acceptMessageResponse.error)
proc offer*( proc offer*(
p: PortalProtocol, dst: Node, contentKeys: ContentKeysList p: PortalProtocol, dst: Node, contentKeys: ContentKeysList