status-im/nimbus-eth1
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth1.git synced 2025-02-05 00:36:45 +00:00
Code Issues Projects Releases Wiki Activity

remove computedGoto pragma

Browse Source
This commit is contained in:
andri lim 2019-04-04 17:23:28 +07:00
parent fb97d8d0ce
commit d37d7fa6a5
No known key found for this signature in database
GPG Key ID: 31702AE10541E6B9
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
nimbus/vm/interpreter_dispatch.nim
View File

@ -211,7 +211,6 @@ proc opTableToCaseStmt(opTable: array[Op, NimNode], computation: NimNode): NimNo
`opImpl`(`computation`) `opImpl`(`computation`)
if `computation`.tracingEnabled: if `computation`.tracingEnabled:
`computation`.traceOpCodeEnded(`asOp`, `computation`.opIndex) `computation`.traceOpCodeEnded(`asOp`, `computation`.opIndex)
`instr` = `computation`.code.next()
else: else:
quote do: quote do:
if `computation`.tracingEnabled: if `computation`.tracingEnabled:
@ -221,8 +220,6 @@ proc opTableToCaseStmt(opTable: array[Op, NimNode], computation: NimNode): NimNo
`computation`.traceOpCodeEnded(`asOp`, `computation`.opIndex) `computation`.traceOpCodeEnded(`asOp`, `computation`.opIndex)
when `asOp` in {Return, Revert, SelfDestruct}: when `asOp` in {Return, Revert, SelfDestruct}:
break break
else:
`instr` = `computation`.code.next()
result.add nnkOfBranch.newTree( result.add nnkOfBranch.newTree(
newIdentNode($op), newIdentNode($op),
@ -233,9 +230,11 @@ proc opTableToCaseStmt(opTable: array[Op, NimNode], computation: NimNode): NimNo
result = quote do: result = quote do:
if `computation`.tracingEnabled: if `computation`.tracingEnabled:
`computation`.prepareTracer() `computation`.prepareTracer()
`computation`.instr = `computation`.code.next()
while true: while true:
{.computedGoto.} `instr` = `computation`.code.next()
#{.computedGoto.}
# computed goto causing stack overflow, it consumes a lot of space
# we could use manual jump table instead
# TODO lots of macro magic here to unravel, with chronicles... # TODO lots of macro magic here to unravel, with chronicles...
# `computation`.logger.log($`computation`.stack & "\n\n", fgGreen) # `computation`.logger.log($`computation`.stack & "\n\n", fgGreen)
`result` `result`