status-im
/
nimbus-eth1
mirror of https://github.com/status-im/nimbus-eth1.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove defunct comment

This commit is contained in:
coffeepots 2018-08-24 16:52:48 +01:00
parent 7542b42d32
commit c3f73860a4
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
nimbus/transaction.nim
View File

@ -44,13 +44,6 @@ proc toSignature*(transaction: Transaction): Signature =
var bytes: array[65, byte] var bytes: array[65, byte]
bytes[0..31] = transaction.R.toByteArrayBE() bytes[0..31] = transaction.R.toByteArrayBE()
bytes[32..63] = transaction.S.toByteArrayBE() bytes[32..63] = transaction.S.toByteArrayBE()
#[
TODO: In the yellow paper:
It is assumed that v is the ‘recovery id’, a 1 byte value
specifying the sign and finiteness of the curve point; this
value is in the range of [27,30].
Does this need to be checked that it is [0, 1] and inc by 27?
]#
# TODO: V will become a byte or range soon. # TODO: V will become a byte or range soon.
bytes[64] = (cast[uint64](transaction.V.data.lo) and 0xff'u64).uint8 bytes[64] = (cast[uint64](transaction.V.data.lo) and 0xff'u64).uint8
initSignature(bytes) initSignature(bytes)