status-im
/
nimbus-eth1
mirror of https://github.com/status-im/nimbus-eth1.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix collectTouchedAccounts

This commit is contained in:
andri lim 2019-05-01 21:47:30 +07:00 committed by zah
parent f809a864b1
commit b34ad8b507
3 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
GeneralStateTests.md
View File

@ -1700,12 +1700,12 @@ OK: 37/38 Fail: 0/38 Skip: 1/38
+ RevertOpcodeMultipleSubCalls.json OK + RevertOpcodeMultipleSubCalls.json OK
+ RevertOpcodeReturn.json OK + RevertOpcodeReturn.json OK
+ RevertOpcodeWithBigOutputInInit.json OK + RevertOpcodeWithBigOutputInInit.json OK
RevertPrecompiledTouch.json Skip + RevertPrecompiledTouch.json OK
+ RevertPrecompiledTouchCC.json OK + RevertPrecompiledTouchCC.json OK
+ RevertPrecompiledTouchDC.json OK + RevertPrecompiledTouchDC.json OK
+ RevertPrecompiledTouch_nonce.json OK + RevertPrecompiledTouch_nonce.json OK
+ RevertPrecompiledTouch_noncestorage.json OK + RevertPrecompiledTouch_noncestorage.json OK
RevertPrecompiledTouch_storage.json Skip + RevertPrecompiledTouch_storage.json OK
+ RevertPrefound.json OK + RevertPrefound.json OK
+ RevertPrefoundCall.json OK + RevertPrefoundCall.json OK
+ RevertPrefoundCallOOG.json OK + RevertPrefoundCallOOG.json OK
@ -1722,7 +1722,7 @@ OK: 37/38 Fail: 0/38 Skip: 1/38
+ TouchToEmptyAccountRevert2.json OK + TouchToEmptyAccountRevert2.json OK
+ TouchToEmptyAccountRevert3.json OK + TouchToEmptyAccountRevert3.json OK
``` ```
OK: 38/46 Fail: 0/46 Skip: 8/46 OK: 40/46 Fail: 0/46 Skip: 6/46
## stSStoreTest ## stSStoreTest
```diff ```diff
InitCollision.json Skip InitCollision.json Skip
@ -2645,4 +2645,4 @@ OK: 133/133 Fail: 0/133 Skip: 0/133
OK: 130/130 Fail: 0/130 Skip: 0/130 OK: 130/130 Fail: 0/130 Skip: 0/130
---TOTAL--- ---TOTAL---
OK: 2252/2447 Fail: 0/2447 Skip: 195/2447 OK: 2254/2447 Fail: 0/2447 Skip: 193/2447

2
nimbus/vm/computation.nim
View File

@ -308,7 +308,7 @@ proc collectTouchedAccounts*(c: BaseComputation, output: var HashSet[EthAddress]
else: else:
output.incl c.msg.storageAddress output.incl c.msg.storageAddress
if not c.isOriginComputation or not c.isError: if not c.isError:
for child in c.children: for child in c.children:
child.collectTouchedAccounts(output) child.collectTouchedAccounts(output)

4
tests/test_generalstate_failing.nim
View File

@ -17,10 +17,6 @@ func allowedFailingGeneralStateTest*(folder, name: string): bool =
"RevertInCreateInInit.json", "RevertInCreateInInit.json",
"modexp.json", "modexp.json",
# 29/04/2019
"RevertPrecompiledTouch.json",
"RevertPrecompiledTouch_storage.json",
# all these tests below actually pass # all these tests below actually pass
# but they are very slow # but they are very slow
# byzantium slow # byzantium slow