From 9097548a10afbf8a3f026d450a5b9f77bf979157 Mon Sep 17 00:00:00 2001 From: Kim De Mey Date: Tue, 9 May 2023 14:34:01 +0200 Subject: [PATCH] Adjust discv5_updateNodeInfo JSON-RPC to specify key and value (#1569) --- fluffy/rpc/rpc_discovery_api.nim | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fluffy/rpc/rpc_discovery_api.nim b/fluffy/rpc/rpc_discovery_api.nim index 1edb54ef4..27e7267d8 100644 --- a/fluffy/rpc/rpc_discovery_api.nim +++ b/fluffy/rpc/rpc_discovery_api.nim @@ -30,10 +30,9 @@ proc installDiscoveryApiHandlers*(rpcServer: RpcServer|RpcProxy, return d.routingTable.getNodeInfo() rpcServer.rpc("discv5_updateNodeInfo") do( - kvPairs: seq[(string, string)]) -> NodeInfo: - # TODO: Not according to spec, as spec parameters are weird. - # It is currently as in - # https://ddht.readthedocs.io/en/latest/jsonrpc.html#discv5-updatenodeinfo + kvPairs: seq[tuple[key: string, value: string]]) -> NodeInfo: + # TODO: Not according to spec, as spec only allows socket address. + # portal-specs PR has been created with suggested change as is here. let enrFields = kvPairs.map( proc(n: (string, string)): (string, seq[byte]) {.raises: [ValueError].} = (n[0], hexToSeqByte(n[1]))