Small updates and fixes for rlpx suite (#2571)

* Remove redundant `eth/68` message and clean up docu

details:
  There is only eth/68 available at the moment

* Allow to turn on chronicles line number logging in `Makefile`

* Accept (and forget) tx hashes announcements

why:
  Does no harm to just ignore it at the moment

* Bump nim-eth (rlp fix)

Makefile

@@ -168,6 +168,9 @@ ENABLE_EVMC := 0
 # "-d:release" cannot be added to config.nims
 
 NIM_PARAMS += -d:release
+ifneq ($(if $(ENABLE_LINE_NUMBERS),$(ENABLE_LINE_NUMBERS),0),0)
+NIM_PARAMS += -d:chronicles_line_numbers:1
+endif
 ifeq ($(BOEHM_GC),1)
 NIM_PARAMS += --mm:boehm
 endif

README.md

@@ -205,11 +205,14 @@ available.)
    cases when the `gc` is involved in a memory corruption or corruption
    camouflage.
 
+ * ENABLE_LINE_NUMBERS=1
+   Enables logger to print out source code location with log message
+
  * ENABLE_EVMC=1<br>
    Enable mostly EVMC compliant wrapper around the native Nim VM
 
  * ENABLE_VMLOWMEM=1<br>
-   Enable new re-factored version of the native Nim VM. This version is not
+   Enable low-memory version of the native Nim VM. This version is not
    optimised and coded in a way so that low memory compilers can handle it
    (observed on 32 bit windows 7.)
 

nimbus/compile_info.nim

@@ -19,10 +19,12 @@ func vmName(): string =
     "nimvm"
 
 const
+  chronicles_line_numbers {.strdefine.} = "0"
   VmName* = vmName()
   warningMsg = block:
     var rc = "*** Compiling with " & VmName
-    rc &= ", eth/68"
+    if chronicles_line_numbers notin ["0", "off"]:
+      rc &= ", logger line numbers"
     when defined(boehmgc):
       rc &= ", boehm/gc"
     when 0 < coreDbBaseConfigExtras.len:

nimbus/sync/handlers/eth.nim

@@ -448,8 +448,8 @@ method handleAnnouncedTxsHashes*(
       txSizes: openArray[int];
       txHashes: openArray[Hash256];
         ): Result[void, string] =
-  ## `Eth68` method
-  notImplemented "handleAnnouncedTxsHashes()/eth68"
+  trace "Wire handler ignoring txs hashes", nHashes=txHashes.len
+  ok()
 
 method handleNewBlock*(ctx: EthWireRef,
                        peer: Peer,

vendor/nim-eth

@@ -1 +1 @@
-Subproject commit 951150227350381bbabe596a714f9450571c16d0
+Subproject commit 98b2a34075614f9ea8bd629c18580c16e8065397