status-im/nimbus-eth1
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth1.git synced 2025-01-25 03:28:57 +00:00
Code Issues Projects Releases Wiki Activity

add comment about evmc and touched accounts

Browse Source
This commit is contained in:
andri lim 2019-12-20 12:32:07 +07:00 committed by zah
parent 7be6a4ea63
commit 3c33678949
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nimbus/vm/computation.nim
View File

@ -246,6 +246,10 @@ proc registerAccountForDeletion*(c: BaseComputation, beneficiary: EthAddress) =
raise newException(ValueError,
"invariant: should be impossible for an account to be " &
"registered for deletion multiple times")
# TODO: collecting touched accounts should be done in state db
# we should remove this accountsToDelete map delegate it to state db
# we will only keep suicides list here in order to make
# evmc integration easier
c.accountsToDelete[c.msg.storageAddress] = beneficiary
c.suicides.incl(c.msg.storageAddress)
@ -273,6 +277,7 @@ proc getGasRemaining*(c: BaseComputation): GasInt =
else:
result = c.gasMeter.gasRemaining
# TODO: collecting touched accounts should be done in account state db
proc collectTouchedAccounts*(c: BaseComputation, output: var HashSet[EthAddress], ancestorHadError: bool = false) =
## Collect all of the accounts that *may* need to be deleted based on EIP161:
## https://github.com/ethereum/EIPs/blob/master/EIPS/eip-161.md