Remove a socket.close after destroy + bump nim-eth for uTP fixes (#1604)

This commit is contained in:
Kim De Mey 2023-06-21 18:56:57 +02:00 committed by GitHub
parent 4b66f93274
commit 2de9c95770
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions

View File

@ -649,7 +649,10 @@ proc findContent*(p: PortalProtocol, dst: Node, contentKey: ByteList):
else :
debug "Socket read time-out",
socketKey = socket.socketKey
socket.close()
# Note: This might look a bit strange, be not doing a socket.close()
# here as this is already done internally. utp_socket `checkTimeouts`
# already does a socket.destroy() on timeout. Might want to change the
# API on this later though.
return err("Reading data from socket timed out, content request failed")
except CancelledError as exc:
# even though we already installed cancelCallback on readFut, it is worth

2
vendor/nim-eth vendored

@ -1 +1 @@
Subproject commit c608426d03167ff44a90ab6864c3b57eddb5512d
Subproject commit 6dacb2ca5ce4e5528924f56c87620f38e1d0c0d4