From 2269d16c4c67f6808d8429bc10cf9db5d7c0d3fa Mon Sep 17 00:00:00 2001 From: jangko Date: Tue, 22 Jun 2021 08:32:32 +0700 Subject: [PATCH] reintegrate test_rpc back into all_tests for a long time, test_rpc will crash all_tests if they are combined together. but now it works fine --- nimbus.nimble | 1 - tests/all_tests.nim | 2 +- tests/test_rpc.nim | 464 ++++++++++++++++++++++---------------------- 3 files changed, 235 insertions(+), 232 deletions(-) diff --git a/nimbus.nimble b/nimbus.nimble index 13b0890b3..faeb5c8d9 100644 --- a/nimbus.nimble +++ b/nimbus.nimble @@ -47,7 +47,6 @@ proc test(name: string, lang = "c") = task test, "Run tests": test "all_tests" - test "test_rpc" task nimbus, "Build Nimbus": buildBinary "nimbus", "nimbus/", "-d:chronicles_log_level=TRACE" diff --git a/tests/all_tests.nim b/tests/all_tests.nim index acca0b25d..672b181fb 100644 --- a/tests/all_tests.nim +++ b/tests/all_tests.nim @@ -99,7 +99,7 @@ cliBuilder: ./test_generalstate_json, ./test_tracer_json, ./test_persistblock_json, - #./test_rpc, # it crash if we combine it here + ./test_rpc, ./test_op_arith, ./test_op_bit, ./test_op_env, diff --git a/tests/test_rpc.nim b/tests/test_rpc.nim index 0b61d7328..b817a5e7a 100644 --- a/tests/test_rpc.nim +++ b/tests/test_rpc.nim @@ -114,288 +114,292 @@ proc setupEnv(chain: BaseChainDB, signer, ks2: EthAddress, conf: NimbusConfigura blockHash: header.hash ) -suite "Remote Procedure Calls": - # TODO: Include other transports such as Http - var - ethNode = setupEthNode(eth) - chain = newBaseChainDB(newMemoryDb()) +proc rpcMain*() = + suite "Remote Procedure Calls": + # TODO: Include other transports such as Http + var + ethNode = setupEthNode(eth) + chain = newBaseChainDB(newMemoryDb()) - let - signer: EthAddress = hexToByteArray[20]("0x0e69cde81b1aa07a45c32c6cd85d67229d36bb1b") - ks2: EthAddress = hexToByteArray[20]("0xa3b2222afa5c987da6ef773fde8d01b9f23d481f") - ks3: EthAddress = hexToByteArray[20]("0x597176e9a64aad0845d83afdaf698fbeff77703b") - conf = getConfiguration() + let + signer: EthAddress = hexToByteArray[20]("0x0e69cde81b1aa07a45c32c6cd85d67229d36bb1b") + ks2: EthAddress = hexToByteArray[20]("0xa3b2222afa5c987da6ef773fde8d01b9f23d481f") + ks3: EthAddress = hexToByteArray[20]("0x597176e9a64aad0845d83afdaf698fbeff77703b") + conf = getConfiguration() - ethNode.chain = newChain(chain) - conf.keyStore = "tests" / "keystore" - let res = conf.loadKeystoreFiles() - if res.isErr: - debugEcho res.error - doAssert(res.isOk) + ethNode.chain = newChain(chain) + conf.keyStore = "tests" / "keystore" + let res = conf.loadKeystoreFiles() + if res.isErr: + debugEcho res.error + doAssert(res.isOk) - let acc1 = conf.getAccount(signer).tryGet() - let unlock = conf.unlockAccount(signer, acc1.keystore["password"].getStr()) - if unlock.isErr: - debugEcho unlock.error - doAssert(unlock.isOk) + let acc1 = conf.getAccount(signer).tryGet() + let unlock = conf.unlockAccount(signer, acc1.keystore["password"].getStr()) + if unlock.isErr: + debugEcho unlock.error + doAssert(unlock.isOk) - defaultGenesisBlockForNetwork(conf.net.networkId).commit(chain) - doAssert(canonicalHeadHashKey().toOpenArray in chain.db) - let env = setupEnv(chain, signer, ks2, conf) + defaultGenesisBlockForNetwork(conf.net.networkId).commit(chain) + doAssert(canonicalHeadHashKey().toOpenArray in chain.db) + let env = setupEnv(chain, signer, ks2, conf) - # Create Ethereum RPCs - let RPC_PORT = 8545 - var - rpcServer = newRpcSocketServer(["localhost:" & $RPC_PORT]) - client = newRpcSocketClient() - setupCommonRpc(ethNode, rpcServer) - setupEthRpc(ethNode, chain, rpcServer) + # Create Ethereum RPCs + let RPC_PORT = 8545 + var + rpcServer = newRpcSocketServer(["localhost:" & $RPC_PORT]) + client = newRpcSocketClient() + setupCommonRpc(ethNode, rpcServer) + setupEthRpc(ethNode, chain, rpcServer) - # Begin tests - rpcServer.start() - waitFor client.connect("localhost", Port(RPC_PORT)) + # Begin tests + rpcServer.start() + waitFor client.connect("localhost", Port(RPC_PORT)) - # TODO: add more tests here - test "web3_clientVersion": - let res = await client.web3_clientVersion() - check res == NimbusIdent + # TODO: add more tests here + test "web3_clientVersion": + let res = await client.web3_clientVersion() + check res == NimbusIdent - test "web3_sha3": - expect ValueError: - discard await client.web3_sha3(NimbusName.HexDataStr) + test "web3_sha3": + expect ValueError: + discard await client.web3_sha3(NimbusName.HexDataStr) - let data = "0x" & byteutils.toHex(NimbusName.toOpenArrayByte(0, NimbusName.len-1)) - let res = await client.web3_sha3(data.hexDataStr) - let rawdata = nimcrypto.fromHex(data[2 .. ^1]) - let hash = "0x" & $keccak_256.digest(rawdata) - check hash == res + let data = "0x" & byteutils.toHex(NimbusName.toOpenArrayByte(0, NimbusName.len-1)) + let res = await client.web3_sha3(data.hexDataStr) + let rawdata = nimcrypto.fromHex(data[2 .. ^1]) + let hash = "0x" & $keccak_256.digest(rawdata) + check hash == res - test "net_version": - let res = await client.net_version() - check res == $conf.net.networkId + test "net_version": + let res = await client.net_version() + check res == $conf.net.networkId - test "net_listening": - let res = await client.net_listening() - let listening = ethNode.peerPool.connectedNodes.len < conf.net.maxPeers - check res == listening + test "net_listening": + let res = await client.net_listening() + let listening = ethNode.peerPool.connectedNodes.len < conf.net.maxPeers + check res == listening - test "net_peerCount": - let res = await client.net_peerCount() - let peerCount = ethNode.peerPool.connectedNodes.len - check isValidHexQuantity res.string - check res == encodeQuantity(peerCount.uint) + test "net_peerCount": + let res = await client.net_peerCount() + let peerCount = ethNode.peerPool.connectedNodes.len + check isValidHexQuantity res.string + check res == encodeQuantity(peerCount.uint) - test "eth_protocolVersion": - let res = await client.eth_protocolVersion() - check res == $eth_protocol.protocolVersion + test "eth_protocolVersion": + let res = await client.eth_protocolVersion() + check res == $eth_protocol.protocolVersion - test "eth_syncing": - let res = await client.eth_syncing() - if res.kind == JBool: - let syncing = ethNode.peerPool.connectedNodes.len > 0 - check res.getBool() == syncing - else: - check res.kind == JObject - check chain.startingBlock == UInt256.fromHex(res["startingBlock"].getStr()) - check chain.currentBlock == UInt256.fromHex(res["currentBlock"].getStr()) - check chain.highestBlock == UInt256.fromHex(res["highestBlock"].getStr()) + test "eth_syncing": + let res = await client.eth_syncing() + if res.kind == JBool: + let syncing = ethNode.peerPool.connectedNodes.len > 0 + check res.getBool() == syncing + else: + check res.kind == JObject + check chain.startingBlock == UInt256.fromHex(res["startingBlock"].getStr()) + check chain.currentBlock == UInt256.fromHex(res["currentBlock"].getStr()) + check chain.highestBlock == UInt256.fromHex(res["highestBlock"].getStr()) - test "eth_coinbase": - let res = await client.eth_coinbase() - # currently we don't have miner - check isValidEthAddress(res.string) - check res == ethAddressStr(EthAddress.default) + test "eth_coinbase": + let res = await client.eth_coinbase() + # currently we don't have miner + check isValidEthAddress(res.string) + check res == ethAddressStr(EthAddress.default) - test "eth_mining": - let res = await client.eth_mining() - # currently we don't have miner - check res == false + test "eth_mining": + let res = await client.eth_mining() + # currently we don't have miner + check res == false - test "eth_hashrate": - let res = await client.eth_hashrate() - # currently we don't have miner - check res == encodeQuantity(0.uint) + test "eth_hashrate": + let res = await client.eth_hashrate() + # currently we don't have miner + check res == encodeQuantity(0.uint) - test "eth_gasPrice": - let res = await client.eth_gasPrice() - check res.string == "0x47E" + test "eth_gasPrice": + let res = await client.eth_gasPrice() + check res.string == "0x47E" - test "eth_accounts": - let res = await client.eth_accounts() - check signer.ethAddressStr in res - check ks2.ethAddressStr in res - check ks3.ethAddressStr in res + test "eth_accounts": + let res = await client.eth_accounts() + check signer.ethAddressStr in res + check ks2.ethAddressStr in res + check ks3.ethAddressStr in res - test "eth_blockNumber": - let res = await client.eth_blockNumber() - check res.string == "0x1" + test "eth_blockNumber": + let res = await client.eth_blockNumber() + check res.string == "0x1" - test "eth_getBalance": - let a = await client.eth_getBalance(ethAddressStr("0xfff33a3bd36abdbd412707b8e310d6011454a7ae"), "0x0") - check a.string == "0x1b1ae4d6e2ef5000000" - let b = await client.eth_getBalance(ethAddressStr("0xfff4bad596633479a2a29f9a8b3f78eefd07e6ee"), "0x0") - check b.string == "0x56bc75e2d63100000" - let c = await client.eth_getBalance(ethAddressStr("0xfff7ac99c8e4feb60c9750054bdc14ce1857f181"), "0x0") - check c.string == "0x3635c9adc5dea00000" + test "eth_getBalance": + let a = await client.eth_getBalance(ethAddressStr("0xfff33a3bd36abdbd412707b8e310d6011454a7ae"), "0x0") + check a.string == "0x1b1ae4d6e2ef5000000" + let b = await client.eth_getBalance(ethAddressStr("0xfff4bad596633479a2a29f9a8b3f78eefd07e6ee"), "0x0") + check b.string == "0x56bc75e2d63100000" + let c = await client.eth_getBalance(ethAddressStr("0xfff7ac99c8e4feb60c9750054bdc14ce1857f181"), "0x0") + check c.string == "0x3635c9adc5dea00000" - test "eth_getStorageAt": - let res = await client.eth_getStorageAt(ethAddressStr("0xfff33a3bd36abdbd412707b8e310d6011454a7ae"), hexQuantityStr "0x0", "0x0") - check hexDataStr(0.u256).string == hexDataStr(res).string + test "eth_getStorageAt": + let res = await client.eth_getStorageAt(ethAddressStr("0xfff33a3bd36abdbd412707b8e310d6011454a7ae"), hexQuantityStr "0x0", "0x0") + check hexDataStr(0.u256).string == hexDataStr(res).string - test "eth_getTransactionCount": - let res = await client.eth_getTransactionCount(ethAddressStr("0xfff7ac99c8e4feb60c9750054bdc14ce1857f181"), "0x0") - check res.string == "0x0" + test "eth_getTransactionCount": + let res = await client.eth_getTransactionCount(ethAddressStr("0xfff7ac99c8e4feb60c9750054bdc14ce1857f181"), "0x0") + check res.string == "0x0" - test "eth_getBlockTransactionCountByHash": - let hash = chain.getBlockHash(0.toBlockNumber) - let res = await client.eth_getBlockTransactionCountByHash(hash) - check res.string == "0x0" + test "eth_getBlockTransactionCountByHash": + let hash = chain.getBlockHash(0.toBlockNumber) + let res = await client.eth_getBlockTransactionCountByHash(hash) + check res.string == "0x0" - test "eth_getBlockTransactionCountByNumber": - let res = await client.eth_getBlockTransactionCountByNumber("0x0") - check res.string == "0x0" + test "eth_getBlockTransactionCountByNumber": + let res = await client.eth_getBlockTransactionCountByNumber("0x0") + check res.string == "0x0" - test "eth_getUncleCountByBlockHash": - let hash = chain.getBlockHash(0.toBlockNumber) - let res = await client.eth_getUncleCountByBlockHash(hash) - check res.string == "0x0" + test "eth_getUncleCountByBlockHash": + let hash = chain.getBlockHash(0.toBlockNumber) + let res = await client.eth_getUncleCountByBlockHash(hash) + check res.string == "0x0" - test "eth_getUncleCountByBlockNumber": - let res = await client.eth_getUncleCountByBlockNumber("0x0") - check res.string == "0x0" + test "eth_getUncleCountByBlockNumber": + let res = await client.eth_getUncleCountByBlockNumber("0x0") + check res.string == "0x0" - test "eth_getCode": - let res = await client.eth_getCode(ethAddressStr("0xfff7ac99c8e4feb60c9750054bdc14ce1857f181"), "0x0") - check res.string == "0x" + test "eth_getCode": + let res = await client.eth_getCode(ethAddressStr("0xfff7ac99c8e4feb60c9750054bdc14ce1857f181"), "0x0") + check res.string == "0x" - test "eth_sign": - let msg = "hello world" - let msgHex = hexDataStr(msg.toOpenArrayByte(0, msg.len-1)) + test "eth_sign": + let msg = "hello world" + let msgHex = hexDataStr(msg.toOpenArrayByte(0, msg.len-1)) - expect ValueError: - discard await client.eth_sign(ethAddressStr(ks2), msgHex) + expect ValueError: + discard await client.eth_sign(ethAddressStr(ks2), msgHex) - let res = await client.eth_sign(ethAddressStr(signer), msgHex) - let sig = Signature.fromHex(res.string).tryGet() + let res = await client.eth_sign(ethAddressStr(signer), msgHex) + let sig = Signature.fromHex(res.string).tryGet() - # now let us try to verify signature - let msgData = "\x19Ethereum Signed Message:\n" & $msg.len & msg - let msgDataHex = hexDataStr(msgData.toOpenArrayByte(0, msgData.len-1)) - let sha3Data = await client.web3_sha3(msgDataHex) - let msgHash = hexToByteArray[32](sha3Data) - let pubkey = recover(sig, SkMessage(msgHash)).tryGet() - let recoveredAddr = pubkey.toCanonicalAddress() - check recoveredAddr == signer # verified + # now let us try to verify signature + let msgData = "\x19Ethereum Signed Message:\n" & $msg.len & msg + let msgDataHex = hexDataStr(msgData.toOpenArrayByte(0, msgData.len-1)) + let sha3Data = await client.web3_sha3(msgDataHex) + let msgHash = hexToByteArray[32](sha3Data) + let pubkey = recover(sig, SkMessage(msgHash)).tryGet() + let recoveredAddr = pubkey.toCanonicalAddress() + check recoveredAddr == signer # verified - test "eth_signTransaction, eth_sendTransaction, eth_sendRawTransaction": - var unsignedTx = TxSend( - source: ethAddressStr(signer), - to: ethAddressStr(ks2).some, - gas: encodeQuantity(100000'u).some, - gasPrice: none(HexQuantityStr), - value: encodeQuantity(100'u).some, - data: HexDataStr("0x"), - nonce: none(HexQuantityStr) - ) + test "eth_signTransaction, eth_sendTransaction, eth_sendRawTransaction": + var unsignedTx = TxSend( + source: ethAddressStr(signer), + to: ethAddressStr(ks2).some, + gas: encodeQuantity(100000'u).some, + gasPrice: none(HexQuantityStr), + value: encodeQuantity(100'u).some, + data: HexDataStr("0x"), + nonce: none(HexQuantityStr) + ) - let signedTxHex = await client.eth_signTransaction(unsignedTx) - let signedTx = rlp.decode(hexToSeqByte(signedTxHex.string), Transaction) - check signer == signedTx.getSender() # verified + let signedTxHex = await client.eth_signTransaction(unsignedTx) + let signedTx = rlp.decode(hexToSeqByte(signedTxHex.string), Transaction) + check signer == signedTx.getSender() # verified - let hashAhex = await client.eth_sendTransaction(unsignedTx) - let hashBhex = await client.eth_sendRawTransaction(signedTxHex) - check hashAhex.string == hashBhex.string + let hashAhex = await client.eth_sendTransaction(unsignedTx) + let hashBhex = await client.eth_sendRawTransaction(signedTxHex) + check hashAhex.string == hashBhex.string - test "eth_call": - var ec = EthCall( - source: ethAddressStr(signer).some, - to: ethAddressStr(ks2).some, - gas: encodeQuantity(100000'u).some, - gasPrice: none(HexQuantityStr), - value: encodeQuantity(100'u).some - ) + test "eth_call": + var ec = EthCall( + source: ethAddressStr(signer).some, + to: ethAddressStr(ks2).some, + gas: encodeQuantity(100000'u).some, + gasPrice: none(HexQuantityStr), + value: encodeQuantity(100'u).some + ) - let res = await client.eth_call(ec, "latest") - check hexToByteArray[4](res.string) == hexToByteArray[4]("deadbeef") + let res = await client.eth_call(ec, "latest") + check hexToByteArray[4](res.string) == hexToByteArray[4]("deadbeef") - test "eth_estimateGas": - var ec = EthCall( - source: ethAddressStr(signer).some, - to: ethAddressStr(ks3).some, - gas: encodeQuantity(42000'u).some, - gasPrice: encodeQuantity(100'u).some, - value: encodeQuantity(100'u).some - ) + test "eth_estimateGas": + var ec = EthCall( + source: ethAddressStr(signer).some, + to: ethAddressStr(ks3).some, + gas: encodeQuantity(42000'u).some, + gasPrice: encodeQuantity(100'u).some, + value: encodeQuantity(100'u).some + ) - let res = await client.eth_estimateGas(ec, "latest") - check hexToInt(res.string, int) == 21000 + let res = await client.eth_estimateGas(ec, "latest") + check hexToInt(res.string, int) == 21000 - test "eth_getBlockByHash": - let res = await client.eth_getBlockByHash(env.blockHash, true) - check res.isSome - check res.get().hash.get() == env.blockHash - let res2 = await client.eth_getBlockByHash(env.txHash, true) - check res2.isNone + test "eth_getBlockByHash": + let res = await client.eth_getBlockByHash(env.blockHash, true) + check res.isSome + check res.get().hash.get() == env.blockHash + let res2 = await client.eth_getBlockByHash(env.txHash, true) + check res2.isNone - test "eth_getBlockByNumber": - let res = await client.eth_getBlockByNumber("latest", true) - check res.isSome - check res.get().hash.get() == env.blockHash - let res2 = await client.eth_getBlockByNumber($1, true) - check res2.isNone + test "eth_getBlockByNumber": + let res = await client.eth_getBlockByNumber("latest", true) + check res.isSome + check res.get().hash.get() == env.blockHash + let res2 = await client.eth_getBlockByNumber($1, true) + check res2.isNone - test "eth_getTransactionByHash": - let res = await client.eth_getTransactionByHash(env.txHash) - check res.isSome - check res.get().blockNumber.get().string.hexToInt(int) == 1 - let res2 = await client.eth_getTransactionByHash(env.blockHash) - check res2.isNone + test "eth_getTransactionByHash": + let res = await client.eth_getTransactionByHash(env.txHash) + check res.isSome + check res.get().blockNumber.get().string.hexToInt(int) == 1 + let res2 = await client.eth_getTransactionByHash(env.blockHash) + check res2.isNone - test "eth_getTransactionByBlockHashAndIndex": - let res = await client.eth_getTransactionByBlockHashAndIndex(env.blockHash, encodeQuantity(0)) - check res.isSome - check res.get().blockNumber.get().string.hexToInt(int) == 1 + test "eth_getTransactionByBlockHashAndIndex": + let res = await client.eth_getTransactionByBlockHashAndIndex(env.blockHash, encodeQuantity(0)) + check res.isSome + check res.get().blockNumber.get().string.hexToInt(int) == 1 - let res2 = await client.eth_getTransactionByBlockHashAndIndex(env.blockHash, encodeQuantity(3)) - check res2.isNone + let res2 = await client.eth_getTransactionByBlockHashAndIndex(env.blockHash, encodeQuantity(3)) + check res2.isNone - let res3 = await client.eth_getTransactionByBlockHashAndIndex(env.txHash, encodeQuantity(3)) - check res3.isNone + let res3 = await client.eth_getTransactionByBlockHashAndIndex(env.txHash, encodeQuantity(3)) + check res3.isNone - test "eth_getTransactionByBlockNumberAndIndex": - let res = await client.eth_getTransactionByBlockNumberAndIndex("latest", encodeQuantity(1)) - check res.isSome - check res.get().blockNumber.get().string.hexToInt(int) == 1 + test "eth_getTransactionByBlockNumberAndIndex": + let res = await client.eth_getTransactionByBlockNumberAndIndex("latest", encodeQuantity(1)) + check res.isSome + check res.get().blockNumber.get().string.hexToInt(int) == 1 - let res2 = await client.eth_getTransactionByBlockNumberAndIndex("latest", encodeQuantity(3)) - check res2.isNone + let res2 = await client.eth_getTransactionByBlockNumberAndIndex("latest", encodeQuantity(3)) + check res2.isNone - test "eth_getTransactionReceipt": - let res = await client.eth_getTransactionReceipt(env.txHash) - check res.isSome - check res.get().blockNumber.string.hexToInt(int) == 1 + test "eth_getTransactionReceipt": + let res = await client.eth_getTransactionReceipt(env.txHash) + check res.isSome + check res.get().blockNumber.string.hexToInt(int) == 1 - let res2 = await client.eth_getTransactionReceipt(env.blockHash) - check res2.isNone + let res2 = await client.eth_getTransactionReceipt(env.blockHash) + check res2.isNone - test "eth_getUncleByBlockHashAndIndex": - let res = await client.eth_getUncleByBlockHashAndIndex(env.blockHash, encodeQuantity(0)) - check res.isSome - check res.get().number.get().string.hexToInt(int) == 1 + test "eth_getUncleByBlockHashAndIndex": + let res = await client.eth_getUncleByBlockHashAndIndex(env.blockHash, encodeQuantity(0)) + check res.isSome + check res.get().number.get().string.hexToInt(int) == 1 - let res2 = await client.eth_getUncleByBlockHashAndIndex(env.blockHash, encodeQuantity(1)) - check res2.isNone + let res2 = await client.eth_getUncleByBlockHashAndIndex(env.blockHash, encodeQuantity(1)) + check res2.isNone - let res3 = await client.eth_getUncleByBlockHashAndIndex(env.txHash, encodeQuantity(0)) - check res3.isNone + let res3 = await client.eth_getUncleByBlockHashAndIndex(env.txHash, encodeQuantity(0)) + check res3.isNone - test "eth_getUncleByBlockNumberAndIndex": - let res = await client.eth_getUncleByBlockNumberAndIndex("latest", encodeQuantity(0)) - check res.isSome - check res.get().number.get().string.hexToInt(int) == 1 + test "eth_getUncleByBlockNumberAndIndex": + let res = await client.eth_getUncleByBlockNumberAndIndex("latest", encodeQuantity(0)) + check res.isSome + check res.get().number.get().string.hexToInt(int) == 1 - let res2 = await client.eth_getUncleByBlockNumberAndIndex("latest", encodeQuantity(1)) - check res2.isNone + let res2 = await client.eth_getUncleByBlockNumberAndIndex("latest", encodeQuantity(1)) + check res2.isNone - rpcServer.stop() - rpcServer.close() + rpcServer.stop() + rpcServer.close() + +when isMainModule: + rpcMain()