2023-05-30 21:21:15 +00:00
|
|
|
# nimbus-eth1
|
Core db update storage root management for sub tries (#1964)
* Aristo: Re-phrase `LayerDelta` and `LayerFinal` as object references
why:
Avoids copying in some cases
* Fix copyright header
* Aristo: Verify `leafTie.root` function argument for `merge()` proc
why:
Zero root will lead to inconsistent DB entry
* Aristo: Update failure condition for hash labels compiler `hashify()`
why:
Node need not be rejected as long as links are on the schedule. In
that case, `redo[]` is to become `wff.base[]` at a later stage.
This amends an earlier fix, part of #1952 by also testing against
the target nodes of the `wff.base[]` sets.
* Aristo: Add storage root glue record to `hashify()` schedule
why:
An account leaf node might refer to a non-resolvable storage root ID.
Storage root node chains will end up at the storage root. So the link
`storage-root->account-leaf` needs an extra item in the schedule.
* Aristo: fix error code returned by `fetchPayload()`
details:
Final error code is implied by the error code form the `hikeUp()`
function.
* CoreDb: Discard `createOk` argument in API `getRoot()` function
why:
Not needed for the legacy DB. For the `Arsto` DB, a lazy approach is
implemented where a stprage root node is created on-the-fly.
* CoreDb: Prevent `$$` logging in some cases
why:
Logging the function `$$` is not useful when it is used for internal
use, i.e. retrieving an an error text for logging.
* CoreDb: Add `tryHashFn()` to API for pretty printing
why:
Pretty printing must not change the hashification status for the
`Aristo` DB. So there is an independent API wrapper for getting the
node hash which never updated the hashes.
* CoreDb: Discard `update` argument in API `hash()` function
why:
When calling the API function `hash()`, the latest state is always
wanted. For a version that uses the current state as-is without checking,
the function `tryHash()` was added to the backend.
* CoreDb: Update opaque vertex ID objects for the `Aristo` backend
why:
For `Aristo`, vID objects encapsulate a numeric `VertexID`
referencing a vertex (rather than a node hash as used on the
legacy backend.) For storage sub-tries, there might be no initial
vertex known when the descriptor is created. So opaque vertex ID
objects are supported without a valid `VertexID` which will be
initalised on-the-fly when the first item is merged.
* CoreDb: Add pretty printer for opaque vertex ID objects
* Cosmetics, printing profiling data
* CoreDb: Fix segfault in `Aristo` backend when creating MPT descriptor
why:
Missing initialisation error
* CoreDb: Allow MPT to inherit shared context on `Aristo` backend
why:
Creates descriptors with different storage roots for the same
shared `Aristo` DB descriptor.
* Cosmetics, update diagnostic message items for `Aristo` backend
* Fix Copyright year
2024-01-11 19:11:38 +00:00
|
|
|
# Copyright (c) 2023-2024 Status Research & Development GmbH
|
2023-05-30 21:21:15 +00:00
|
|
|
# Licensed under either of
|
|
|
|
# * Apache License, version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0)
|
|
|
|
# * MIT license ([LICENSE-MIT](LICENSE-MIT) or
|
|
|
|
# http://opensource.org/licenses/MIT)
|
|
|
|
# at your option. This file may not be copied, modified, or distributed
|
|
|
|
# except according to those terms.
|
|
|
|
|
|
|
|
{.push raises: [].}
|
|
|
|
|
|
|
|
import
|
|
|
|
eth/common,
|
2023-09-15 15:23:53 +00:00
|
|
|
results,
|
2024-06-28 15:03:12 +00:00
|
|
|
"."/[aristo_desc, aristo_get, aristo_layers, aristo_serialise]
|
2023-08-17 13:42:01 +00:00
|
|
|
|
2024-06-28 15:03:12 +00:00
|
|
|
proc computeKey*(
|
2024-07-04 13:46:52 +00:00
|
|
|
db: AristoDbRef; # Database, top layer
|
|
|
|
rvid: RootedVertexID; # Vertex to convert
|
2024-06-28 15:03:12 +00:00
|
|
|
): Result[HashKey, AristoError] =
|
|
|
|
# This is a variation on getKeyRc which computes the key instead of returning
|
|
|
|
# an error
|
|
|
|
# TODO it should not always write the key to the persistent storage
|
|
|
|
|
2024-07-04 13:46:52 +00:00
|
|
|
proc getKey(db: AristoDbRef; rvid: RootedVertexID): HashKey =
|
2024-06-28 15:03:12 +00:00
|
|
|
block body:
|
2024-07-04 13:46:52 +00:00
|
|
|
let key = db.layersGetKey(rvid).valueOr:
|
2024-06-28 15:03:12 +00:00
|
|
|
break body
|
|
|
|
if key.isValid:
|
|
|
|
return key
|
2024-02-22 08:24:58 +00:00
|
|
|
else:
|
2024-06-28 15:03:12 +00:00
|
|
|
return VOID_HASH_KEY
|
2024-07-04 13:46:52 +00:00
|
|
|
let rc = db.getKeyBE rvid
|
2024-06-28 15:03:12 +00:00
|
|
|
if rc.isOk:
|
|
|
|
return rc.value
|
|
|
|
VOID_HASH_KEY
|
|
|
|
|
2024-07-04 13:46:52 +00:00
|
|
|
let key = getKey(db, rvid)
|
2024-06-28 15:03:12 +00:00
|
|
|
if key.isValid():
|
|
|
|
return ok key
|
|
|
|
|
2024-07-04 13:46:52 +00:00
|
|
|
let vtx = ? db.getVtxRc rvid
|
2024-06-28 15:03:12 +00:00
|
|
|
|
|
|
|
# TODO this is the same code as when serializing NodeRef, without the NodeRef
|
2024-07-04 23:48:45 +00:00
|
|
|
var writer = initRlpWriter()
|
2024-06-28 15:03:12 +00:00
|
|
|
|
|
|
|
case vtx.vType:
|
|
|
|
of Leaf:
|
2024-07-04 23:48:45 +00:00
|
|
|
writer.startList(2)
|
|
|
|
writer.append(vtx.lPfx.toHexPrefix(isLeaf = true))
|
2024-06-28 15:03:12 +00:00
|
|
|
# Need to resolve storage root for account leaf
|
|
|
|
case vtx.lData.pType
|
|
|
|
of AccountData:
|
2024-07-04 13:46:52 +00:00
|
|
|
let
|
|
|
|
stoID = vtx.lData.stoID
|
|
|
|
key = if stoID.isValid:
|
|
|
|
?db.computeKey((stoID, stoID))
|
|
|
|
else:
|
|
|
|
VOID_HASH_KEY
|
2024-06-28 15:03:12 +00:00
|
|
|
|
2024-07-04 23:48:45 +00:00
|
|
|
writer.append(encode Account(
|
2024-06-28 15:03:12 +00:00
|
|
|
nonce: vtx.lData.account.nonce,
|
|
|
|
balance: vtx.lData.account.balance,
|
|
|
|
storageRoot: key.to(Hash256),
|
|
|
|
codeHash: vtx.lData.account.codeHash)
|
|
|
|
)
|
|
|
|
of RawData:
|
2024-07-04 23:48:45 +00:00
|
|
|
writer.append(vtx.lData.rawBlob)
|
|
|
|
of StoData:
|
|
|
|
# TODO avoid memory allocation when encoding storage data
|
|
|
|
writer.append(rlp.encode(vtx.lData.stoData))
|
2024-06-28 15:03:12 +00:00
|
|
|
|
|
|
|
of Branch:
|
No ext update (#2494)
* Imported/rebase from `no-ext`, PR #2485
Store extension nodes together with the branch
Extension nodes must be followed by a branch - as such, it makes sense
to store the two together both in the database and in memory:
* fewer reads, writes and updates to traverse the tree
* simpler logic for maintaining the node structure
* less space used, both memory and storage, because there are fewer
nodes overall
There is also a downside: hashes can no longer be cached for an
extension - instead, only the extension+branch hash can be cached - this
seems like a fine tradeoff since computing it should be fast.
TODO: fix commented code
* Fix merge functions and `toNode()`
* Update `merkleSignCommit()` prototype
why:
Result is always a 32bit hash
* Update short Merkle hash key generation
details:
Ethereum reference MPTs use Keccak hashes as node links if the size of
an RLP encoded node is at least 32 bytes. Otherwise, the RLP encoded
node value is used as a pseudo node link (rather than a hash.) This is
specified in the yellow paper, appendix D.
Different to the `Aristo` implementation, the reference MPT would not
store such a node on the key-value database. Rather the RLP encoded node value is stored instead of a node link in a parent node
is stored as a node link on the parent database.
Only for the root hash, the top level node is always referred to by the
hash.
* Fix/update `Extension` sections
why:
Were commented out after removal of a dedicated `Extension` type which
left the system disfunctional.
* Clean up unused error codes
* Update unit tests
* Update docu
---------
Co-authored-by: Jacek Sieka <jacek@status.im>
2024-07-16 19:47:59 +00:00
|
|
|
template writeBranch(w: var RlpWriter) =
|
|
|
|
w.startList(17)
|
|
|
|
for n in 0..15:
|
|
|
|
let vid = vtx.bVid[n]
|
|
|
|
if vid.isValid:
|
|
|
|
w.append(?db.computeKey((rvid.root, vid)))
|
|
|
|
else:
|
|
|
|
w.append(VOID_HASH_KEY)
|
|
|
|
w.append EmptyBlob
|
|
|
|
if vtx.ePfx.len > 0: # Extension node
|
|
|
|
var bwriter = initRlpWriter()
|
|
|
|
writeBranch(bwriter)
|
2023-12-04 20:39:26 +00:00
|
|
|
|
No ext update (#2494)
* Imported/rebase from `no-ext`, PR #2485
Store extension nodes together with the branch
Extension nodes must be followed by a branch - as such, it makes sense
to store the two together both in the database and in memory:
* fewer reads, writes and updates to traverse the tree
* simpler logic for maintaining the node structure
* less space used, both memory and storage, because there are fewer
nodes overall
There is also a downside: hashes can no longer be cached for an
extension - instead, only the extension+branch hash can be cached - this
seems like a fine tradeoff since computing it should be fast.
TODO: fix commented code
* Fix merge functions and `toNode()`
* Update `merkleSignCommit()` prototype
why:
Result is always a 32bit hash
* Update short Merkle hash key generation
details:
Ethereum reference MPTs use Keccak hashes as node links if the size of
an RLP encoded node is at least 32 bytes. Otherwise, the RLP encoded
node value is used as a pseudo node link (rather than a hash.) This is
specified in the yellow paper, appendix D.
Different to the `Aristo` implementation, the reference MPT would not
store such a node on the key-value database. Rather the RLP encoded node value is stored instead of a node link in a parent node
is stored as a node link on the parent database.
Only for the root hash, the top level node is always referred to by the
hash.
* Fix/update `Extension` sections
why:
Were commented out after removal of a dedicated `Extension` type which
left the system disfunctional.
* Clean up unused error codes
* Update unit tests
* Update docu
---------
Co-authored-by: Jacek Sieka <jacek@status.im>
2024-07-16 19:47:59 +00:00
|
|
|
writer.startList(2)
|
|
|
|
writer.append(vtx.ePfx.toHexPrefix(isleaf = false))
|
|
|
|
writer.append(bwriter.finish().digestTo(HashKey, forceRoot=false))
|
|
|
|
else:
|
|
|
|
writeBranch(writer)
|
Core db update storage root management for sub tries (#1964)
* Aristo: Re-phrase `LayerDelta` and `LayerFinal` as object references
why:
Avoids copying in some cases
* Fix copyright header
* Aristo: Verify `leafTie.root` function argument for `merge()` proc
why:
Zero root will lead to inconsistent DB entry
* Aristo: Update failure condition for hash labels compiler `hashify()`
why:
Node need not be rejected as long as links are on the schedule. In
that case, `redo[]` is to become `wff.base[]` at a later stage.
This amends an earlier fix, part of #1952 by also testing against
the target nodes of the `wff.base[]` sets.
* Aristo: Add storage root glue record to `hashify()` schedule
why:
An account leaf node might refer to a non-resolvable storage root ID.
Storage root node chains will end up at the storage root. So the link
`storage-root->account-leaf` needs an extra item in the schedule.
* Aristo: fix error code returned by `fetchPayload()`
details:
Final error code is implied by the error code form the `hikeUp()`
function.
* CoreDb: Discard `createOk` argument in API `getRoot()` function
why:
Not needed for the legacy DB. For the `Arsto` DB, a lazy approach is
implemented where a stprage root node is created on-the-fly.
* CoreDb: Prevent `$$` logging in some cases
why:
Logging the function `$$` is not useful when it is used for internal
use, i.e. retrieving an an error text for logging.
* CoreDb: Add `tryHashFn()` to API for pretty printing
why:
Pretty printing must not change the hashification status for the
`Aristo` DB. So there is an independent API wrapper for getting the
node hash which never updated the hashes.
* CoreDb: Discard `update` argument in API `hash()` function
why:
When calling the API function `hash()`, the latest state is always
wanted. For a version that uses the current state as-is without checking,
the function `tryHash()` was added to the backend.
* CoreDb: Update opaque vertex ID objects for the `Aristo` backend
why:
For `Aristo`, vID objects encapsulate a numeric `VertexID`
referencing a vertex (rather than a node hash as used on the
legacy backend.) For storage sub-tries, there might be no initial
vertex known when the descriptor is created. So opaque vertex ID
objects are supported without a valid `VertexID` which will be
initalised on-the-fly when the first item is merged.
* CoreDb: Add pretty printer for opaque vertex ID objects
* Cosmetics, printing profiling data
* CoreDb: Fix segfault in `Aristo` backend when creating MPT descriptor
why:
Missing initialisation error
* CoreDb: Allow MPT to inherit shared context on `Aristo` backend
why:
Creates descriptors with different storage roots for the same
shared `Aristo` DB descriptor.
* Cosmetics, update diagnostic message items for `Aristo` backend
* Fix Copyright year
2024-01-11 19:11:38 +00:00
|
|
|
|
No ext update (#2494)
* Imported/rebase from `no-ext`, PR #2485
Store extension nodes together with the branch
Extension nodes must be followed by a branch - as such, it makes sense
to store the two together both in the database and in memory:
* fewer reads, writes and updates to traverse the tree
* simpler logic for maintaining the node structure
* less space used, both memory and storage, because there are fewer
nodes overall
There is also a downside: hashes can no longer be cached for an
extension - instead, only the extension+branch hash can be cached - this
seems like a fine tradeoff since computing it should be fast.
TODO: fix commented code
* Fix merge functions and `toNode()`
* Update `merkleSignCommit()` prototype
why:
Result is always a 32bit hash
* Update short Merkle hash key generation
details:
Ethereum reference MPTs use Keccak hashes as node links if the size of
an RLP encoded node is at least 32 bytes. Otherwise, the RLP encoded
node value is used as a pseudo node link (rather than a hash.) This is
specified in the yellow paper, appendix D.
Different to the `Aristo` implementation, the reference MPT would not
store such a node on the key-value database. Rather the RLP encoded node value is stored instead of a node link in a parent node
is stored as a node link on the parent database.
Only for the root hash, the top level node is always referred to by the
hash.
* Fix/update `Extension` sections
why:
Were commented out after removal of a dedicated `Extension` type which
left the system disfunctional.
* Clean up unused error codes
* Update unit tests
* Update docu
---------
Co-authored-by: Jacek Sieka <jacek@status.im>
2024-07-16 19:47:59 +00:00
|
|
|
let h = writer.finish().digestTo(HashKey, rvid.root == rvid.vid)
|
2024-06-28 15:03:12 +00:00
|
|
|
# TODO This shouldn't necessarily go into the database if we're just computing
|
|
|
|
# a key ephemerally - it should however be cached for some tiem since
|
|
|
|
# deep hash computations are expensive
|
2024-07-04 13:46:52 +00:00
|
|
|
db.layersPutKey(rvid, h)
|
2024-06-28 15:03:12 +00:00
|
|
|
ok h
|
2023-05-30 21:21:15 +00:00
|
|
|
|
2024-02-08 16:32:16 +00:00
|
|
|
|
2023-05-30 21:21:15 +00:00
|
|
|
|
|
|
|
# ------------------------------------------------------------------------------
|
|
|
|
# End
|
|
|
|
# ------------------------------------------------------------------------------
|