nimbus-eth1/nimbus/db/aristo/TODO.md

* Check whether `HashKey` can be reduced to a simple 32 byte array (see
  *desc_identifiers.nim*)

* Re-visit `delTree()`. Suggestion is deleting small trees on the memory later,
  otherwise only deleting the root vertex (so it becomes inaccessible) and
  remember the follow up vertices which can travel through the tx-layers
  to be picked up by the backend store.

* Consider changing fetch/merge/delete prototypes for account and storage. At
  the moment they all use `openArray[]` for strictly 32 byte arrays (which is
  only implicitely enforced at run time -- i.e. it would fail otherwise.)

* Mental note: For *proof-mode* with pre-allocated locked vertices and Merkle
  keys, verification of a patyion tree must be done by computing sub-tree keys
  at the relative roots and comparing them with the pre-allocated Merkle keys.

* Remove legacy state format import from `deblobifyTo()` after a while (last
  updated 28/06/24).
Aristo avoid storage trie update race conditions (#2251) * Update TDD suite logger output format choices why: New format is not practical for TDD as it just dumps data across a wide range (considerably larder than 80 columns.) So the new format can be turned on by function argument. * Update unit tests samples configuration why: Slightly changed the way to find the `era1` directory * Remove compiler warnings (fix deprecated expressions and phrases) * Update `Aristo` debugging tools * Always update the `storageID` field of account leaf vertices why: Storage tries are weekly linked to an account leaf object in that the `storageID` field is updated by the application. Previously, `Aristo` verified that leaf objects make sense when passed to the database. As a consequence * the database was inconsistent for a short while * the burden for correctness was all on the application which led to delayed error handling which is hard to debug. So `Aristo` will internally update the account leaf objects so that there are no race conditions due to the storage trie handling * Aristo: Let `stow()`/`persist()` bail out unless there is a `VertexID(1)` why: The journal and filter logic depends on the hash of the `VertexID(1)` which is commonly known as the state root. This implies that all changes to the database are somehow related to that. * Make sure that a `Ledger` account does not overwrite the storage trie reference why: Due to the abstraction of a sub-trie (now referred to as column with a hash describing its state) there was a weakness in the `Aristo` handler where an account leaf could be overwritten though changing the validity of the database. This has been changed and the database will now reject such changes. This patch fixes the behaviour on the application layer. In particular, the column handle returned by the `CoreDb` needs to be updated by the `Aristo` database state. This mitigates the problem that a storage trie might have vanished or re-apperaed with a different vertex ID. * Fix sub-trie deletion test why: Was originally hinged on `VertexID(1)` which cannot be wholesale deleted anymore after the last Aristo update. Also, running with `VertexID(2)` needs an artificial `VertexID(1)` for making `stow()` or `persist()` work. * Cosmetics * Activate `test_generalstate_json` * Temporarily `deactivate test_tracer_json` * Fix copyright header --------- Co-authored-by: jordan <jordan@dry.pudding> Co-authored-by: Jacek Sieka <jacek@status.im> 2024-05-30 18:48:38 +01:00			* Check whether `HashKey` can be reduced to a simple 32 byte array (see
			`desc_identifiers.nim)`

Coredb fix storage tree issues (#2317) * Code cosmetics * Re-org `aristo_merge`, internally split into sub-modules why: Became a burden for maintenance because it hosts two different functionalities under the same merge paradigm: account/data merge and snap proof merge where the latter produces a partial trie. * Fix CoreDb tracer * Ledger: fix potential account vs. storage tree sync problems * Remove bound on the size of removable whole storage trees * Activate `test_tracer_json` 2024-06-07 10:56:31 +00:00			* Re-visit `delTree()`. Suggestion is deleting small trees on the memory later,
			`otherwise only deleting the root vertex (so it becomes inaccessible) and`
			`remember the follow up vertices which can travel through the tx-layers`
			`to be picked up by the backend store.`
Aristo code cosmetics and tests update (#2434) * Update some docu * Resolve obsolete compile time option why: Not optional anymore * Update checks why: The notion of what constitutes a valid `Aristo` db has changed due to (even more) lazy calculating Merkle hash keys. * Disable redundant unit test for production 2024-07-01 10:59:18 +00:00
			`* Consider changing fetch/merge/delete prototypes for account and storage. At`
			the moment they all use `openArray[]` for strictly 32 byte arrays (which is
			`only implicitely enforced at run time -- i.e. it would fail otherwise.)`

			`* Mental note: For proof-mode with pre-allocated locked vertices and Merkle`
			`keys, verification of a patyion tree must be done by computing sub-tree keys`
			`at the relative roots and comparing them with the pre-allocated Merkle keys.`

			* Remove legacy state format import from `deblobifyTo()` after a while (last
			`updated 28/06/24).`