status-im
/
nim-stew
mirror of https://github.com/status-im/nim-stew.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Revert "Allow comparing Result[void, E] (#71)" (#73) 

This reverts commit 068412ff4e.
This commit is contained in:
Mamy Ratsimbazafy 2021-01-26 14:20:09 +01:00 committed by GitHub
parent 068412ff4e
commit b4b3841a85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
stew/results.nim
View File

@ -442,14 +442,11 @@ template capture*[E: Exception](T: type, someExceptionExpr: ref E): Result[T, re
ret = R.err(caught) ret = R.err(caught)
ret ret
func `==`*[T, E](lhs: Result[T, E], rhs: Result[T, E]): bool {.inline.} = func `==`*[T0, E0, T1, E1](lhs: Result[T0, E0], rhs: Result[T1, E1]): bool {.inline.} =
if lhs.o != rhs.o: if lhs.o != rhs.o:
false false
elif lhs.o: # and rhs.o implied elif lhs.o: # and rhs.o implied
when T is void: lhs.v == rhs.v
true
else:
lhs.v == rhs.v
else: else:
lhs.e == rhs.e lhs.e == rhs.e

5
tests/test_results.nim
View File

@ -275,8 +275,3 @@ func cstringF(s: string): CSRes =
doAssert false doAssert false
discard cstringF("test") discard cstringF("test")
# Compare void
block:
var a, b: Result[void, bool]
discard a == b