work around pointless copy in isZeroMemory due to https://github.com/nim-lang/Nim/issues/24093 (#233)

This commit is contained in:
tersec 2024-09-26 15:49:08 +00:00 committed by GitHub
parent 41f48efee9
commit 1c9190a632
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 31 additions and 16 deletions

View File

@ -1,6 +1,16 @@
# stew
# Copyright 2018-2024 Status Research & Development GmbH
# Licensed under either of
#
# * Apache License, version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
# * MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)
#
# at your option. This file may not be copied, modified, or distributed except according to those terms.
{.push raises: [].}
import import
macros, std/[macros, sequtils]
sequtils
template init*(lvalue: var auto) = template init*(lvalue: var auto) =
mixin init mixin init
@ -18,10 +28,7 @@ template init*(lvalue: var auto, a1, a2, a3: auto) =
mixin init mixin init
lvalue = init(type(lvalue), a1, a2, a3) lvalue = init(type(lvalue), a1, a2, a3)
when not declared(default): func toArray*[T](N: static int, data: openArray[T]): array[N, T] =
proc default*(T: type): T = discard
proc toArray*[T](N: static int, data: openArray[T]): array[N, T] =
doAssert data.len == N doAssert data.len == N
copyMem(addr result[0], unsafeAddr data[0], N) copyMem(addr result[0], unsafeAddr data[0], N)
@ -86,7 +93,7 @@ macro hasHoles*(T: type[enum]): bool =
quote: `T`.high.ord - `T`.low.ord != `len` quote: `T`.high.ord - `T`.low.ord != `len`
proc contains*[I: SomeInteger](e: type[enum], v: I): bool = func contains*[I: SomeInteger](e: type[enum], v: I): bool =
when I is uint64: when I is uint64:
if v > int.high.uint64: if v > int.high.uint64:
return false return false
@ -105,14 +112,15 @@ func checkedEnumAssign*[E: enum, I: SomeInteger](res: var E, value: I): bool =
return false return false
res = cast[E](value) res = cast[E](value)
return true true
func isZeroMemory*[T](x: T): bool = func isZeroMemory*[T](x: T): bool =
# TODO: iterate over words here # TODO: iterate over words here
for b in cast[ptr array[sizeof(T), byte]](unsafeAddr x)[]: # bufPtr avoids pointless https://github.com/nim-lang/Nim/issues/24093 copy
if b != 0: let bufPtr = cast[ptr array[sizeof(T), byte]](unsafeAddr x)
return false for b in bufPtr[]:
return true if b != 0: return false
true
func isDefaultValue*[T](x: T): bool = func isDefaultValue*[T](x: T): bool =
# TODO: There are ways to optimise this for simple POD types # TODO: There are ways to optimise this for simple POD types

View File

@ -1,8 +1,15 @@
import std/sets, ../objects, ../templateutils # stew
# Copyright 2019-2024 Status Research & Development GmbH
# Licensed under either of
#
# * Apache License, version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
# * MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)
#
# at your option. This file may not be copied, modified, or distributed except according to those terms.
when not declared(initHashSet): {.push raises: [].}
template initHashSet*[T](initialSize = 64): auto =
initSet[T](initialSize) import std/sets, ../objects, ../templateutils
template init*[T](_: type HashSet[T]): auto = initHashSet[T]() template init*[T](_: type HashSet[T]): auto = initHashSet[T]()
template init*[T](_: type HashSet[T], defaultSize: int): auto = initHashSet[T](defaultSize) template init*[T](_: type HashSet[T], defaultSize: int): auto = initHashSet[T](defaultSize)