status-im
/
nim-stew
mirror of https://github.com/status-im/nim-stew.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

assign2: guard against self-assignment / overlapping openArray (#182)

This commit is contained in:
Jacek Sieka 2023-04-25 21:32:22 +02:00 committed by GitHub
parent 8caa977199
commit 111d939940
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
stew/assign2.nim
View File

@ -15,7 +15,7 @@ func assignImpl[T](tgt: var openArray[T], src: openArray[T]) =
mixin assign mixin assign
when supportsCopyMem(T): when supportsCopyMem(T):
if tgt.len > 0: if tgt.len > 0:
copyMem(addr tgt[0], unsafeAddr src[0], sizeof(tgt[0]) * tgt.len) moveMem(addr tgt[0], unsafeAddr src[0], sizeof(tgt[0]) * tgt.len)
else: else:
for i in 0..<tgt.len: for i in 0..<tgt.len:
assign(tgt[i], src[i]) assign(tgt[i], src[i])
@ -52,7 +52,7 @@ func assign*[T](tgt: var T, src: T) =
when sizeof(src) <= sizeof(int): when sizeof(src) <= sizeof(int):
tgt = src tgt = src
else: else:
copyMem(addr tgt, unsafeAddr src, sizeof(tgt)) moveMem(addr tgt, unsafeAddr src, sizeof(tgt))
elif T is object|tuple: elif T is object|tuple:
for t, s in fields(tgt, src): for t, s in fields(tgt, src):
when supportsCopyMem(type s) and sizeof(s) <= sizeof(int) * 2: when supportsCopyMem(type s) and sizeof(s) <= sizeof(int) * 2: