Dmitriy Ryajov
3d44fcb8b3
use cancelAndAwait to mitigate further hangs ( #459 )
2020-11-28 09:48:06 -06:00
Dmitriy Ryajov
a8f5f7a8bb
move dialing logic to it's own proc to avoid try/finally bugs ( #461 )
...
* move dialing logic to it's own proc to avoid try/finally bugs
* re-export transport
* lint
* add cancelation test
* test remote conn close on dial
2020-11-28 09:05:12 +01:00
Giovanni Petrantoni
02b20440f2
Limit ihave emission ( #462 )
...
* add some limits to ihave emission, go has them, rust does not actually
* restore shuffling of IDs
* add some context
2020-11-28 16:27:39 +09:00
Giovanni Petrantoni
12db9a4cf2
TopicParams validation tuning
2020-11-28 00:23:09 +09:00
Giovanni Petrantoni
809df8d04d
add some extra gossip metrics
2020-11-26 16:20:34 +09:00
Giovanni Petrantoni
6c7f2766fe
expose seenTTL parameters ( #457 )
2020-11-26 14:45:10 +09:00
Dmitriy Ryajov
ca9c5c85e4
dont break chronicles logging streamline connsetup ( #455 )
2020-11-25 13:34:48 -06:00
Dmitriy Ryajov
7b1e652224
Allow custom identify agent string ( #451 )
...
* allow custom agent version string
* rework tests and add test for custom agent version
2020-11-25 07:42:02 -06:00
Dmitriy Ryajov
164892776b
get rid of hangs cleanup ( #453 )
2020-11-25 07:35:25 -06:00
Dmitriy Ryajov
21110636cb
fixing log level to avoid sacring users ( #452 )
2020-11-24 12:07:27 -06:00
Giovanni Petrantoni
a3b21f7cbb
update create-pull-request
2020-11-24 17:23:28 +09:00
Dmitriy Ryajov
351489bfa9
getMuxedStream to more appropriate getStream ( #448 )
2020-11-24 00:37:45 -06:00
Dmitriy Ryajov
69ae24dc8d
less leak prone cleanup ( #447 )
...
* less leak prone cleanup
* fix double allFinished
2020-11-23 18:22:15 -06:00
Dmitriy Ryajov
6cc3f4283a
update conn peerinfo instead of replacing ( #445 )
...
* update conn peerinfo instead of replacing
* remove unnecesary peerid var
2020-11-23 15:15:55 -06:00
Dmitriy Ryajov
034a1e8b1b
small cleanups from tcp-limits2 ( #446 )
2020-11-23 15:02:23 -06:00
Dmitriy Ryajov
1d16d22f5f
Don't allow concurrent pushdata ( #444 )
...
* handle resets properly with/without pushes/reads
* add clarifying comments
* pushEof should also not be concurrent
* move channel reset to bufferstream
this is where the action happens - lpchannel merely redefines how close
is done
Co-authored-by: Jacek Sieka <jacek@status.im>
2020-11-23 09:07:11 -06:00
Dmitriy Ryajov
c42009d56e
don't quit accept prematurelly ( #443 )
2020-11-19 09:10:25 -06:00
Giovanni Petrantoni
93b6c4dc52
Gossip runtime params ( #437 )
...
* move gossip parameters to runtime
* internal test fixes
* add missing params
* restore const parameters are soldi base and use them in init
* more constants tuning
2020-11-19 16:48:17 +09:00
Dmitriy Ryajov
92fa4110c1
Rework transport to use chronos accept ( #420 )
...
* rework transport to use the new accept api
* use the new chronos primits
* fixup tests to use the new transport api
* handle all exceptions in upgradeIncoming
* master merge
* add multiaddress exception type
* raise appropriate exception on invalida address
* allow retrying on TransportTooManyError
* adding TODO
* wip
* merge master
* add sleep if nil is returned
* accept loop handles all exceptions
* avoid issues with tray/except/finally
* make consistent with master
* cleanup accept loop
* logging
* Update libp2p/transports/tcptransport.nim
Co-authored-by: Jacek Sieka <jacek@status.im>
* use Direction enum instead of initiator flag
* use consistent import style
* remove experimental `closeWithEOF()`
Co-authored-by: Jacek Sieka <jacek@status.im>
2020-11-18 20:06:42 -06:00
Dmitriy Ryajov
8c8d73380f
Re-add connection manager tests ( #441 )
...
* use table.getOrDefault()
* re-add missing connection manager tests
2020-11-17 18:48:26 -06:00
Jacek Sieka
74acd0a33a
fix channels not being reset ( #439 )
...
* fix channels not being reset
silly for loop..
* allow only one concurrent read
* fix mplex test race condition
* add some bufferstream eof tests
* deadlock, lost data and hung channel fixes
* prevent concurrent `reset` calls
* reset LPChannel when read is cancelled (since data is lost)
* ensure there's one, and one only, 0-byte readOnce on EOF
* ensure that all data is returned before EOF is returned
* keep running activity monitor for half-closed channels (or they never
get closed)
2020-11-17 08:59:25 -06:00
Jacek Sieka
51a0aec058
read failure ( #436 )
...
* read failure
Test showing read failure on cancel
* adding one more test case from jacek
Co-authored-by: Dmitriy Ryajov <dryajov@gmail.com>
2020-11-13 12:30:14 -06:00
Jacek Sieka
5e6ec6f422
Revert "failing test"
...
This reverts commit 5dbed426c2
.
2020-11-13 12:26:08 +01:00
Jacek Sieka
5dbed426c2
failing test
2020-11-13 12:24:23 +01:00
Dmitriy Ryajov
55b763264e
Cleanup tests ( #435 )
...
* add async testing methods
* refactor with async testing methods
* use iffy in async tests
2020-11-12 21:44:02 -06:00
Dmitriy Ryajov
23ffd1f9f9
remove unnecesary sleeps ( #434 )
2020-11-12 14:18:17 -06:00
Dmitriy Ryajov
da37eee285
Test disconnect from conn event ( #432 )
...
* logs
* adding disconnect test in connection events
* adding immediate disconnect from connection event
2020-11-11 13:20:14 -06:00
Giovanni Petrantoni
a9948b0b05
clarify validation messages ( #431 )
...
* clarify validation messages
* add codecov threshold
2020-11-12 01:42:12 +09:00
Giovanni Petrantoni
e85569800c
Codecov extras ( #430 )
...
* try fix codecov html artifacts path
* wip
* wip
* wip
* wip
* fix options matrix
2020-11-11 23:22:39 +09:00
Giovanni Petrantoni
96ed9fbe85
start by building with codecov on (linux) ( #424 )
...
* start by building with codecov on (linux)
* travis coverage builds
* wip
* wip
* wip
* wip
* codecov.io integration
* merge multiple coverage
* improve nimble codecov
* fileExists
* wip codecov CI refactor
* add nimble install
* wip
* fix path
* wip
* add lcov command
* try bump ubuntu...
* wip
* add genhtml to debug
* wip
* wip
* fix lcov extract
* wip
* wip
* try again exporting coverage htmls
* make artifacts unique
* another attempt
* fix env var
* restore regular travis and nimble file
2020-11-10 17:16:39 +09:00
Dmitriy Ryajov
90921bff09
move some importance trace logs to debug ( #428 )
2020-11-09 22:14:46 -06:00
Dmitriy Ryajov
331961ef14
dont use double allFinished in mplex tests ( #427 )
2020-11-06 12:20:59 -06:00
Dmitriy Ryajov
4fb3f50d2c
Reset channels on close ( #425 )
...
* reset when failed to read/write muxed conn
* add more comprehensive resource cleanup tests
* style
* cleanup tests
2020-11-06 09:24:24 -06:00
Dmitriy Ryajov
3956f3fd69
make sure all streams are tracked ( #422 )
...
* make sure all streams are tracked
* revert unnecesary change
2020-11-04 21:52:54 -06:00
Dmitriy Ryajov
6040cb4ef1
fix debugutils ( #423 )
2020-11-04 19:56:28 -06:00
Giovanni Petrantoni
7cc42ce219
start adding more tests + minor fixes ( #419 )
...
* start adding more tests + minor fixes
* add wrong secure negotiation test
* add noise failed handshake test
2020-11-04 23:24:41 +09:00
Giovanni Petrantoni
e496802943
Least expensive metrics ( #421 )
...
* add more general and useful metrics
* fix gossipsub peers metrics in heartbeat
2020-11-04 15:18:00 +01:00
Dmitriy Ryajov
7b5259dbc7
Move triggers ( #416 )
...
* move event triggers to connmanager
* use base error type
* avoid deadlocks
* handle eof and closed when identifying incoming
* use `closeWait`
2020-11-02 14:35:26 -06:00
Dmitriy Ryajov
43a77e60a1
split stream counts by direction ( #418 )
2020-11-01 16:23:26 -06:00
Jacek Sieka
03639f1446
Revert "Channel leaks ( #413 )" ( #417 )
...
This reverts commit 1de1d49223
.
2020-11-01 14:49:25 -06:00
Giovanni Petrantoni
9c1633bf87
fix ValidIpAddress multiaddress init return type
2020-10-31 13:20:29 +09:00
cheatfate
04c95cb7b0
Fix write should be writeArray.
2020-10-31 03:23:34 +02:00
cheatfate
ff48d0b1a2
Proper fix for init(ValidIpAddress).
2020-10-30 17:52:38 +02:00
Giovanni Petrantoni
3d9948a65e
ensure all multiaddress routines use Result
2020-10-30 23:50:04 +09:00
Giovanni Petrantoni
75b023c9e5
gossipsub audit fixes ( #412 )
...
* [SEC] gossipsub - rebalanceMesh grafts peers giving preference to low scores #405
* comment score choices
* compiler warning fixes/bug fixes (unsubscribe)
* rebalanceMesh does not enforce D_out quota
* fix outbound grafting
* fight the nim compiler
* fix closure capture bs...
* another closure fix
* #403 rebalance prune fixes
* more test fixing
* #403 fixes
* #402 avoid removing scores on unsub
* #401 handleGraft improvements
* [SEC] handleIHAVE/handleIWANT recommendations
* add a note about peer exchange handling
2020-10-30 21:49:54 +09:00
Dmitriy Ryajov
1de1d49223
Channel leaks ( #413 )
...
* break stream tracking by type
* use closeWithEOF to await wrapped stream
* fix cancelation leaks
* fix channel leaks
* logging
* use close monitor and always call closeUnderlying
* don't use closeWithEOF
* removing close monitor
* logging
2020-10-27 11:21:03 -06:00
Giovanni Petrantoni
eeaa62feec
add more debug details to multiaddress assertions
2020-10-21 18:29:59 +09:00
Giovanni Petrantoni
462da1f7a8
gossip MessageID as seq[byte] ( #391 )
...
* gossip MessageID as seq[byte]
* combina hashes in defaultMsgIdProvider
* wip
* fix defaultMsgIdProvider
2020-10-21 12:26:04 +09:00
Giovanni Petrantoni
27b9bf436e
fix validation according to specification ( #410 )
2020-10-21 12:25:42 +09:00
Giovanni Petrantoni
5c19668b2d
avoid verbose EOF messages in readOnce(secure) ( #411 )
...
* avoid verbose EOF messages in readOnce(secure)
* shorten azure tests further
2020-10-21 10:08:24 +09:00