From 40ab9ff6d18f82f04b6bf1168a43aa429590d460 Mon Sep 17 00:00:00 2001 From: Tanguy Date: Mon, 20 Jun 2022 15:44:02 +0200 Subject: [PATCH] address review comments --- libp2p/transports/quictransport.nim | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/libp2p/transports/quictransport.nim b/libp2p/transports/quictransport.nim index 0dceac133..2601e22ae 100644 --- a/libp2p/transports/quictransport.nim +++ b/libp2p/transports/quictransport.nim @@ -44,14 +44,9 @@ method readOnce*(stream: QuicStream, nbytes: int): Future[int] {.async.} = if stream.cached.len == 0: stream.cached = await mapExceptions(stream.stream.read()) - if stream.cached.len <= nbytes: - copyMem(pbytes, addr stream.cached[0], stream.cached.len) - result = stream.cached.len - stream.cached = @[] - else: - copyMem(pbytes, addr stream.cached[0], nbytes) - result = nbytes - stream.cached = stream.cached[nbytes..^1] + result = min(nbytes, stream.cached.len) + copyMem(pbytes, addr stream.cached[0], result) + stream.cached = stream.cached[result..^1] {.push warning[LockLevel]: off.} method write*(stream: QuicStream, bytes: seq[byte]) {.async.} =