From 21a444197cf22896fe086b2d359bb3ada972f191 Mon Sep 17 00:00:00 2001 From: diegomrsantos Date: Tue, 10 Sep 2024 13:51:54 +0200 Subject: [PATCH] chore: move mm:refc config and remove skipParentCfg (#1190) - Moving the `mm:refc` configuration to the main `config.nims` file makes it be used in tests and tasks that build examples. - It's not clear why `skipParentCfg`was being used and it doesn't seem to be necessary. --- config.nims | 3 +++ libp2p.nimble | 4 ++-- tests/config.nims | 4 ---- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/config.nims b/config.nims index 0414dfc75..51ae23a84 100644 --- a/config.nims +++ b/config.nims @@ -12,6 +12,9 @@ switch("warning", "LockLevel:off") switch("warningAsError", "UseBase:on") --styleCheck: error +--mm: + refc + # reconsider when there's a version-2-2 branch worth testing with as we might switch to orc # Avoid some rare stack corruption while using exceptions with a SEH-enabled # toolchain: https://github.com/status-im/nimbus-eth2/issues/3121 diff --git a/libp2p.nimble b/libp2p.nimble index 08052e6ce..ad05d0ee5 100644 --- a/libp2p.nimble +++ b/libp2p.nimble @@ -19,8 +19,8 @@ let verbose = getEnv("V", "") notin ["", "0"] let cfg = " --styleCheck:usages --styleCheck:error" & - (if verbose: "" else: " --verbosity:0 --hints:off") & - " --skipParentCfg --skipUserCfg -f" & " --threads:on --opt:speed" + (if verbose: "" else: " --verbosity:0 --hints:off") & " --skipUserCfg -f" & + " --threads:on --opt:speed" import hashes, strutils diff --git a/tests/config.nims b/tests/config.nims index 25930fa27..6f1a23994 100644 --- a/tests/config.nims +++ b/tests/config.nims @@ -17,10 +17,6 @@ import strutils, os libp2p_mplex_metrics --d: unittestPrintTime ---skipParentCfg ---mm: - refc - # reconsider when there's a version-2-2 branch worth testing with as we might switch to orc # Only add chronicles param if the # user didn't specify any