status-im
/
nim-libbacktrace
mirror of https://github.com/status-im/nim-libbacktrace.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

deal with functions inlined into "main()" 

and limit the number of "no debugging symbols available" error messages
per stack trace
This commit is contained in:
Ștefan Talpalaru 2021-03-14 18:24:59 +01:00
parent cfe5032ddb
commit d6d449446b
No known key found for this signature in database
GPG Key ID: CBF7934204F1B6F9
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libbacktrace_wrapper.c
View File

@ -74,6 +74,7 @@ struct callback_data {
int next_index;
int max_length;
int nim_main_module_seen; // Did we already see NimMainModule?
int missing_debugging_symbols_error_shown;
};
struct simple_callback_data {
@ -159,8 +160,10 @@ static int success_callback(void *data, uintptr_t pc __attribute__((unused)),
return 1; // Stop building the backtrace.
if (function == NULL || filename == NULL) {
if (cb_data->next_index == 0)
if (cb_data->missing_debugging_symbols_error_shown == 0) {
fprintf(stderr, "libbacktrace error: no debugging symbols available. Compile with '--debugger:native'.\n");
cb_data->missing_debugging_symbols_error_shown = 1;
}
// see https://github.com/status-im/nim-libbacktrace/issues/9, we need to keep going here.
return 0;
@ -170,7 +173,8 @@ static int success_callback(void *data, uintptr_t pc __attribute__((unused)),
// skip internal Nim functions
if ((strings_equal(demangled_function, "NimMainInner") ||
strings_equal(demangled_function, "NimMain")) &&
strings_equal(demangled_function, "NimMain") ||
strings_equal(demangled_function, "main")) &&
cb_data->nim_main_module_seen) {
/*
* If we skip them unconditionally, we may end up with an empty