status-im
/
nim-json-serialization
mirror of https://github.com/status-im/nim-json-serialization.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix stylecheck for BiggestUInt (#99) 

* fix reader_desc.nim

* fix test_serialization.nim

* workaround segfault on C++ related to unittest2

* link to nim issue as comment
This commit is contained in:
metagn 2024-10-10 15:26:09 +03:00 committed by GitHub
parent ab1a061756
commit 9110cc8d7a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
json_serialization/reader_desc.nim
View File

@ -60,7 +60,7 @@ type
IntOverflowError* = object of JsonReaderError
isNegative: bool
absIntVal: BiggestUint
absIntVal: BiggestUInt
Json.setReader JsonReader
@ -129,7 +129,7 @@ template raiseUnexpectedValue*(r: JsonReader, msg: string) =
raiseUnexpectedValue(r.lex, msg)
func raiseIntOverflow*(
lex: JsonLexer, absIntVal: BiggestUint, isNegative: bool)
lex: JsonLexer, absIntVal: BiggestUInt, isNegative: bool)
{.noreturn, raises: [JsonReaderError].} =
var ex = new IntOverflowError
ex.assignLineNumber(lex)
@ -137,7 +137,7 @@ func raiseIntOverflow*(
ex.isNegative = isNegative
raise ex
template raiseIntOverflow*(r: JsonReader, absIntVal: BiggestUint, isNegative: bool) =
template raiseIntOverflow*(r: JsonReader, absIntVal: BiggestUInt, isNegative: bool) =
raiseIntOverflow(r.lex, absIntVal, isNegative)
func raiseUnexpectedField*(

6
tests/test_reader.nim
View File

@ -142,8 +142,10 @@ suite "JsonReader basic test":
test "readValue":
try:
var r = toReader jsonText3
var val: MasterReader
r.readValue(val)
var valOrig: MasterReader
r.readValue(valOrig)
# workaround for https://github.com/nim-lang/Nim/issues/24274
let val = valOrig
check:
val.one == JsonString("[1,true,null]")
val.two.num == 123

6
tests/test_serialization.nim
View File

@ -678,14 +678,14 @@ suite "toJson tests":
"""
test "max unsigned value":
var uintVal = not BiggestUint(0)
var uintVal = not BiggestUInt(0)
let jsonValue = Json.encode(uintVal)
check:
jsonValue == "18446744073709551615"
Json.decode(jsonValue, BiggestUint) == uintVal
Json.decode(jsonValue, BiggestUInt) == uintVal
expect JsonReaderError:
discard Json.decode(jsonValue, BiggestUint, flags = {JsonReaderFlag.portableInt})
discard Json.decode(jsonValue, BiggestUInt, flags = {JsonReaderFlag.portableInt})
test "max signed value":
let intVal = BiggestInt.high