Commit Graph

143 Commits

Author SHA1 Message Date
Mark Spanbroek 131316de08 move error conversion from TransactionResponse to Confirmable
Ensures that provider no longer needs to know about error
conversion, it now localized in contract.nim.

Co-Authored-By: Eric Mastro <eric.mastro@gmail.com>
2024-05-21 13:19:24 +02:00
Mark Spanbroek ab10354910 wrap transaction response into Confirmable
This is a breaking change for the API of nim-ethers.
2024-05-21 13:19:24 +02:00
Mark Spanbroek cdb230d30f handle custom errors in confirm() calls 2024-05-21 13:19:24 +02:00
Mark Spanbroek 9cb033e865 keep error data intact when replaying transaction 2024-05-21 13:19:24 +02:00
Mark Spanbroek 241ce6e8f3 sendTransaction raises ProviderError instead of SignerError
Allows it to contain error data.
It is not the signing that fails, so it makes sense to
use an error type that indicates that the provider failed.
2024-05-21 13:19:24 +02:00
Mark Spanbroek 1ce9824738 EstimateGasError is a ProviderError instead of a SignerError
Which allows for it to contain error data
2024-05-21 13:19:24 +02:00
Mark Spanbroek 80fcb246f6 do not export encoding and decoding functions 2024-05-21 13:19:24 +02:00
Mark Spanbroek ce63c375f7 error messages for custom errors 2024-05-21 13:19:24 +02:00
Mark Spanbroek 955ac2d58f abi decoding of custom error fails on trailing bytes 2024-05-21 13:19:24 +02:00
Mark Spanbroek 9c76803302 support custom errors with arguments 2024-05-21 13:19:24 +02:00
Mark Spanbroek 74f15fca9c support custom errors in contract calls
Currently only errors without arguments
2024-05-21 13:19:24 +02:00
Mark Spanbroek 6b57e56a39 abi decoding of simple custom errors
Only supports errors without arguments for now
2024-05-21 13:19:24 +02:00
Mark Spanbroek 875900b493 jsonrpc: extract error data from JSON RPC error
Inspired by 'spelunk' from ethers.js:
f97b92bbb1/packages/providers/src.ts/json-rpc-provider.ts (L25)
2024-05-21 13:19:24 +02:00
Mark Spanbroek 52d7d3dbed jsonrpc: move error handling to separate module 2024-05-21 13:19:24 +02:00
Eric 027b5c37ad
fix: deserialize BlockTag from empty string (#73)
Allows BlockTag to be deserialized from an empty string
2024-05-21 13:10:06 +10:00
Eric 958d7b45d1
Remove overloaded UInt256.fromJson (#74)
* Remove overloaded UInt256.fromJson

Rely instead on UInt256.fromJson from nim-serde, which deserializes an empty string for ?UInt256 into UInt256.none. Previously, empty strings were deserialized into 0.u256. BlockNumber was using this deserialization, and it appears that deserializing a missing block number from a TransactionReceipt into 0 might actually cause some issues when waiting on block confirmations.

* bump version of serde

* Remove "v" from version in `.nimble`

* Fix nimble serde version again ¯\_(ツ)_/¯
2024-05-21 13:09:42 +10:00
markspanbroek 4ad5b6065e
Update dependencies (#70)
Updates hardhat and solidity

Uses personal_sign instead of eth_sign, because ethers.js also uses personal_sign, and eth_sign is now broken in hardhat (arguments are reversed).

Co-authored-by: Adam Uhlíř <adam@uhlir.dev>
2024-05-13 11:51:43 +02:00
Mark Spanbroek 14a7485a88 Handle getter functions for public state variables
Getter functions that are generated by the solidity
compiler do not wrap their return value in a tuple
like other functions do.
2024-03-12 09:27:18 +01:00
Mark Spanbroek b78463a299 Refactor: handle multiple returns earlier 2024-03-12 09:27:18 +01:00
Ben Bierens 942fe034fc
Fixes isSyncing issue where object is evaluated as false (#68) 2024-03-08 12:55:36 +01:00
Mark Spanbroek 877ff82ef6 Fix: overrides when simulating transaction 2024-03-03 06:33:52 +01:00
Mark Spanbroek af5a0f5fb4 Fix: ensure that gas estimations are done using the "pending" block 2024-02-27 09:40:20 +01:00
Ben Bierens e8196b3c82
Adds isSyncing to provider (#62) 2024-02-20 16:25:23 +01:00
Eric 43500c63d7
Upgrade to `nim-json-rpc` v0.4.2 and chronos v4 (#64)
* Add json de/serialization lib from codex to handle conversions

json-rpc now requires nim-json-serialization to convert types to/from json. Use the nim-json-serialization signatures to call the json serialization lib from nim-codex (should be moved to its own lib)

* Add ethers implementation for setMethodHandler

Was removed in json-rpc

* More json conversion updates

* Fix json_rpc.call returning JsonString instead of JsonNode

* Update exceptions

Use {.async: (raises: [...].} where needed
Annotate provider with {.push raises:[].}
Format signatures

* Start fixing tests (mainly conversion fixes)

* rename sender to `from`, update json error logging, add more conversions

* Refactor exceptions for providers and signers, fix more tests

- signer procs raise SignerError, provider procs raise ProviderError
- WalletError now inherits from SignerError
- move wallet module under signers
- create jsonrpo moudle under signers
- bump nim-json-rpc for null-handling fixes
- All jsonrpc provider tests passing, still need to fix others

* remove raises from async annotation for dynamic dispatch

- removes async: raises from getAddress and signTransaction because derived JsonRpcSigner methods were not being used when dynamically dispatched. Once `raises` was removed from the async annotation, the dynamic dispatch worked again. This is only the case for getAddress and signTransaction.
- add gcsafe annotation to wallet.provider so that it matches the base method

* Catch EstimateGasError before ProviderError

EstimateGasError is now a ProviderError (it is a SignerError, and SignerError is a ProviderError), so EstimateGasErrors were not being caught

* clean up - all tests passing

* support nim 2.0

* lock in chronos version

* Add serde options to the json util, along with tests

next step is to:
1. change back any ethers var names that were changed for serialization purposes, eg `from` and `type`
2. move the json util to its own lib

* bump json-rpc to 0.4.0 and fix test

* fix: specify raises for getAddress and sendTransaction

Fixes issue where getAddress and sendTransaction could not be found for MockSigner in tests. The problem was that the async: raises update had not been applied to the MockSigner.

* handle exceptions during jsonrpc init

There are too many exceptions to catch individually, including chronos raising CatchableError exceptions in await expansion. There are also many other errors captured inside of the new proc with CatchableError. Instead of making it more complicated and harder to read, I think sticking with excepting CatchableError inside of convertError is a sensible solution

* cleanup

* deserialize key defaults to serialize key

* Add more tests for OptIn/OptOut/Strict modes, fix logic

* use nim-serde instead of json util

Allows aliasing of de/serialized fields, so revert changes of sender to `from` and transactionType to `type`

* Move hash* shim to its own module

* address PR feedback

- add comments to hashes shim
- remove .catch from callback condition
- derive SignerError from EthersError instead of ProviderError. This allows Providers and Signers to be separate, as Ledger does it, to isolate functionality. Some signer functions now raise both ProviderError and SignerError
- Update reverts to check for SignerError
- Update ERC-20 method comment

* rename subscriptions.init > subscriptions.start
2024-02-19 16:50:46 +11:00
Mark Spanbroek c25de86656 remove upraises
we no longer support nim 1.2.x,
so upraises is no longer necessary
2023-12-12 09:28:06 +01:00
Mark Spanbroek abe8585f53 Do not decrease nonce when it wasn't increased 2023-12-12 09:08:01 +01:00
Eric 16b28f4535 wrap try/finally around populateTransaction logic to ensure the lock is always released in the case of an error 2023-12-12 09:08:01 +01:00
Eric 2428b756d6
On transaction failure, fetch revert reason with replayed transaction (#57)
When transaction fails (receipt.status is Failed), fetch revert reason by replaying transaction.
2023-10-25 11:36:00 +11:00
Eric 7eac8410af
prevent stuck transactions by async locking nonce sequencing (+ estimate gas) (#55)
- async lock during nonce sequencing + gas estimation
- simplified cancelTransaction (still exported) such that the new transaction is populated using populateTransaction, so that all gas and fees are reset
- moved reverting contract function into its own testing helpers module, and refactored any tests to use it
- updated the test helper reverts to check EstimateGasErrors
- combine ensureNonceSequence into populateTransaction
2023-10-25 10:42:25 +11:00
Adam Uhlíř 620b402a7d
feat: (de/in)crease allowance (#56) 2023-10-16 10:23:58 +02:00
Eric f0303473f6
Increment nonce count when populating transaction (#54)
Increment nonce count when populating transaction

Co-authored-by: markspanbroek <mark@spanbroek.net>
2023-09-15 09:54:08 +10:00
Mark Spanbroek 15ed76ebed Use Result to return error when wallet creation fails
Co-authored-by: Eric Mastro <eric.mastro@gmail.com>
2023-09-13 10:11:18 +02:00
Mark Spanbroek 81ec482fca Wallet: handle invalid key when instantiating new wallet 2023-09-13 10:11:18 +02:00
Mark Spanbroek 2b6f7b7a0d Fixes for Nim 2.0.0 2023-08-29 12:25:39 +02:00
Eric 12d7a35203
Query past contract events (#51)
Based on ethers.js's queryFilter, allows querying of past contract events, by querying the logs for a contract's event topic.

* queryFilter to query past logs
* Allow querying of past block log events
* Can query by block number or block hash
2023-07-20 15:51:28 +10:00
Mark Spanbroek 2b181aa0f7 Allow wallet to be instantiated with a PrivateKey 2023-07-05 15:08:35 +02:00
Mark Spanbroek 5ed3f15706 Return transaction response for ERC20 functions
Allows callers to wait for confirmation of the
transaction
2023-07-05 15:08:22 +02:00
Mark Spanbroek d7b7f67afb Formatting 2023-07-05 15:08:22 +02:00
Mark Spanbroek 842bf4d0a2 Refactor wallet signing 2023-07-05 15:07:52 +02:00
Mark Spanbroek f1a1221d14 Move WalletError into its own module 2023-07-05 15:07:52 +02:00
Mark Spanbroek c89701016a Fix EIP-155 signatures 2023-07-05 15:07:52 +02:00
Mark Spanbroek 5127991117 Add "value" to Transaction object 2023-07-05 15:07:52 +02:00
Mark Spanbroek 09810e73ff Move `confirm()` override into contract module
And simplify its test
2023-07-04 12:58:48 +02:00
Mark Spanbroek 4e4a55b13e Cleanup 2023-07-04 12:58:48 +02:00
Mark Spanbroek cb95cbc15a Make BlockHandler callback synchronous (breaking change)
Refactored the confirm() implementation to work
with a synchronous callback
2023-07-04 12:58:48 +02:00
Mark Spanbroek 82f6449374 Move JsonRpcSubscription type to jsonrpc module
Allows it to insert convertError to ensure that
any errors are re-raised as JsonRpcProviderError
2023-07-03 13:09:09 +02:00
Mark Spanbroek 738c6a87e2 Stop polling when provider is closed 2023-07-03 13:09:09 +02:00
Mark Spanbroek a27c2de41c Close provider by unsubscribing and closing client 2023-07-03 13:09:09 +02:00
Mark Spanbroek 2481bda6e4 Subscribe to logs with polling 2023-07-03 13:09:09 +02:00
Mark Spanbroek 0aea16047c Ignore errors when retrieving block by hash 2023-07-03 13:09:09 +02:00