status-im
/
nim-ethers
mirror of https://github.com/status-im/nim-ethers.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Stop polling when provider is closed

This commit is contained in:
Mark Spanbroek 2023-06-27 16:45:38 +02:00 committed by markspanbroek
parent a27c2de41c
commit 738c6a87e2
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ethers/providers/jsonrpc/subscriptions.nim
View File

@ -35,7 +35,7 @@ method unsubscribe(subscriptions: JsonRpcSubscriptions,
{.async, base.} =
raiseAssert "not implemented"
method close*(subscriptions: JsonRpcSubscriptions) {.async.} =
method close*(subscriptions: JsonRpcSubscriptions) {.async, base.} =
let ids = toSeq subscriptions.callbacks.keys
for id in ids:
await subscriptions.unsubscribe(id)
@ -103,6 +103,7 @@ method unsubscribe(subscriptions: WebSocketSubscriptions,
type
PollingSubscriptions = ref object of JsonRpcSubscriptions
polling: Future[void]
proc new*(_: type JsonRpcSubscriptions,
client: RpcHttpClient,
@ -127,10 +128,13 @@ proc new*(_: type JsonRpcSubscriptions,
await poll(id)
await sleepAsync(pollingInterval)
asyncSpawn poll()
subscriptions.polling = poll()
subscriptions
method close*(subscriptions: PollingSubscriptions) {.async.} =
await subscriptions.polling.cancelAndWait()
await procCall JsonRpcSubscriptions(subscriptions).close()
method subscribeBlocks(subscriptions: PollingSubscriptions,
onBlock: BlockHandler):
Future[JsonRpcSubscription]