status-im/nim-ethers
2
0
Fork 0
mirror of https://github.com/status-im/nim-ethers.git synced 2025-01-12 00:24:54 +00:00
Code Issues Projects Releases Wiki Activity

Add TODOs

Browse Source
This commit is contained in:
Jackie 2022-07-12 21:21:35 +02:00 committed by markspanbroek
parent d6c9151103
commit 39005a09be
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ethers/wallet.nim
View File

@ -51,6 +51,8 @@ method provider*(wallet: Wallet): Provider =
else: else:
raise newException(WalletError, "Wallet has no provider") raise newException(WalletError, "Wallet has no provider")
#TODO add other methods defined in signer. Currently you have to specify nonce, gaslimit, gasPrice.
method populateTransaction*(wallet: Wallet, tx: transaction.Transaction): Future[transaction.Transaction] {.async.} = method populateTransaction*(wallet: Wallet, tx: transaction.Transaction): Future[transaction.Transaction] {.async.} =
var populated = tx var populated = tx
if tx.nonce.isNone: if tx.nonce.isNone:
@ -130,4 +132,9 @@ proc signTransaction*(wallet: Wallet, tx: transaction.Transaction): Future[strin
s.payload = tx.data s.payload = tx.data
signTransaction(s, wallet.privateKey) signTransaction(s, wallet.privateKey)
return "0x" & rlp.encode(s).toHex return "0x" & rlp.encode(s).toHex
#TODO add functionality to sign messages
#TODO add functionality to create wallets from Mnemoniks or Keystores

4
testmodule/testWallet.nim
View File

@ -9,6 +9,10 @@ proc transfer*(erc20: Erc20, recipient: Address, amount: UInt256) {.contract.}
suite "Wallet": suite "Wallet":
#TODO add more tests. I am not sure if I am testing everything currently
#TODO take close look at current signing tests. I am not 100% sure they are correct and work
#TODO add setup/teardown if required. Currently doing all nonces manually
test "Can create Wallet with private key": test "Can create Wallet with private key":
discard Wallet.new(pk1) discard Wallet.new(pk1)