mirror of https://github.com/status-im/nim-eth.git
9a28ed7ef5
Don't treat 3 characters as special in `cmp`. `cmp` for `ProtocolInfo` was wrong because it ignored all characters after the first 3. In the wild we have seen protocol names longer than 3 characters. `snap`, `hive`, `istanbul`, `bzzeth`, `bzz-stream`, `bzz-retrieve`, `dbix`, `opera`, `pchain`, `pchain_child_0`, `sero`, `smilobft`, `spock`. There was never a 3 character limit in the [specification] (https://github.com/ethereum/devp2p/blob/master/rlpx.md). It always said "short ASCII name", until recently on 2021-02-25 it was changed to an 8 characters limit. Also `pi.nameStr` can be removed. Nothing uses it, and it has the same actual effect as just copying the string `pi.name`. Signed-off-by: Jamie Lokier <jamie@shareable.org> |
||
|---|---|---|
| .. | ||
| discoveryv5 | ||
| private | ||
| rlpx_protocols | ||
| auth.nim | ||
| blockchain_sync.nim | ||
| blockchain_utils.nim | ||
| bootnodes.nim | ||
| discovery.nim | ||
| ecies.nim | ||
| enode.nim | ||
| kademlia.nim | ||
| mock_peers.nim | ||
| p2p_backends_helpers.nim | ||
| p2p_protocol_dsl.nim | ||
| p2p_tracing.nim | ||
| p2p_tracing_ctail_plugin.nim | ||
| peer_pool.nim | ||
| rlpx.nim | ||
| rlpxcrypt.nim | ||
| sync.nim | ||
| whispernodes.nim | ||