nim-eth

mirror of https://github.com/status-im/nim-eth.git synced 2025-01-12 23:34:16 +00:00

History

Jamie Lokier 9a28ed7ef5 RLPx: Protocol names have never been limited to 3 characters

Don't treat 3 characters as special in `cmp`.  `cmp` for `ProtocolInfo` was
wrong because it ignored all characters after the first 3.

In the wild we have seen protocol names longer than 3 characters.  `snap`,
`hive`, `istanbul`, `bzzeth`, `bzz-stream`, `bzz-retrieve`, `dbix`, `opera`,
`pchain`, `pchain_child_0`, `sero`, `smilobft`, `spock`.

There was never a 3 character limit in the [specification]
(https://github.com/ethereum/devp2p/blob/master/rlpx.md).

It always said "short ASCII name", until recently on 2021-02-25 it was changed
to an 8 characters limit.

Also `pi.nameStr` can be removed.  Nothing uses it, and it has the same actual
effect as just copying the string `pi.name`.

Signed-off-by: Jamie Lokier <jamie@shareable.org>

2021-08-10 14:08:35 +03:00

discoveryv5

Let talkreq directly return the seq[byte] for easier API (#384 )

2021-07-30 16:04:14 +02:00

private

Add/update bunch of license headers

2021-05-11 09:37:33 +02:00

rlpx_protocols

Remove {.rlpInline.} which was never really implemented

2021-08-10 14:08:35 +03:00

auth.nim

Push raises Defect to rlpx and accompanying changes (#373 )