mirror of https://github.com/status-im/nim-eth.git
00ed6ad312
* Provide dedicated `DisconnectionReason` enum type RLP reader why: Without this reader, the program communicating via RLPX will crash when receiving out of bound reason codes disconnect message. Out of bound value assignments to an enum causes a `RangeError`defect and consequently the program to terminate. This `RangeError` is avoided here and a `MalformedRlpError` catchable error raised. * Using default exception type in bespoke `read(DisconnectionReason)` why: This should not differ from the default enum parser. The particular message is different and more targeted, here. Note: The default RLP parser was not used because ` `array[1,DisconnectionReason]` is currently not properly handled and should give a siliar error message as a `DisconnectionReason` error. * De-clutter, custom read() was not needed Co-authored-by: jordan <jordan@curd.mjh-it.com> |
||
---|---|---|
.. | ||
p2p_types.nim |